Re: [RFC/RFT] rtl8187: Protect the config callback from mac80211 with a mutex

[Michael Buesch <mb@bu3sch.de>]

On Wednesday 30 July 2008 20:11:11 Herton Ronaldo Krzesinski wrote:
> Em Wednesday 30 July 2008 14:46:40 Michael Buesch escreveu:
> > On Wednesday 30 July 2008 19:13:52 Herton Ronaldo Krzesinski wrote:
> > > > Yeah, I said exactly that.
> > > > You protect the loopback stuff. Not any config callback or anything else.
> > > 
> > > Ah ok, only protect the section, like this?
> > 
> > Yeah, well. In theory, yes. In practice: Aren't there other races possible, too?
> > I mean even races with other parts of the driver.
> > b43 needs to take the global driver mutex in the conf callback to make
> > sure nothing changes (device init state probably is the most important one.
> > Device going down while configuring would be a fatal crash).
> 
> In practice I don't get other problems, but better to stick to the patch posted
> by Larry,

Yeah, OK. I'm fine with that. I was just pointing out possible future problems.

> like he said to avoid config data from one call mixed to the other. 

Nah, we're not locking calls ;P

-- 
Greetings Michael.