From: Ivo van Doorn <ivdoorn@gmail.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 5/8] rfkill: add WARN_ON and BUG_ON paranoia
Date: Sun, 3 Aug 2008 15:53:57 +0200 [thread overview]
Message-ID: <200808031553.58030.IvDoorn@gmail.com> (raw)
In-Reply-To: <20080803132816.GC12118@khazad-dum.debian.net>
On Sunday 03 August 2008, Henrique de Moraes Holschuh wrote:
> On Sun, 03 Aug 2008, Ivo van Doorn wrote:
> > > BUG() never returns. Same for all the other places you pointed out.
> >
> > Ah right, that doesn't sound too good. I don't think rfkill should
> > become a blocker like that. WARN_ON should be sufficient. :)
>
> It would, if anyone ever tested the return from notify chain registering.
> But the core kernel doesn't do any checking when registering notifiers to
> the chains, and always either return zero or OOPS outright when it attempts
> to dereference a NULL pointer (at least on 2.6.25)...
>
> So, I went with BUG(). Given the above, do you still want me to WARN() and
> return -EINVAL instead? I can certainly do that, it would be more correct
> than what the core kernel is doing, anyway.
No, if notify chain doesn't check, and convention is to use BUG() in this case,
then BUG() is fine with me.
Ivo
next prev parent reply other threads:[~2008-08-03 13:30 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-02 18:10 [GIT PATCH] rfkill changes for 2.6.28, set 1 Henrique de Moraes Holschuh
2008-08-02 18:10 ` [PATCH 1/8] rfkill: detect bogus double-registering (v2) Henrique de Moraes Holschuh
2008-08-03 8:04 ` Ivo van Doorn
2008-08-02 18:10 ` [PATCH 2/8] rfkill: add default global states (v2) Henrique de Moraes Holschuh
2008-08-03 8:05 ` Ivo van Doorn
2008-08-02 18:10 ` [PATCH 3/8] rfkill: add __must_check annotations Henrique de Moraes Holschuh
2008-08-03 8:05 ` Ivo van Doorn
2008-08-02 18:11 ` [PATCH 4/8] rfkill: introduce RFKILL_STATE_MAX Henrique de Moraes Holschuh
2008-08-03 8:06 ` Ivo van Doorn
2008-08-02 18:11 ` [PATCH 5/8] rfkill: add WARN_ON and BUG_ON paranoia Henrique de Moraes Holschuh
2008-08-03 8:07 ` Ivo van Doorn
2008-08-03 8:57 ` Johannes Berg
2008-08-03 10:07 ` Ivo van Doorn
2008-08-03 13:28 ` Henrique de Moraes Holschuh
2008-08-03 13:53 ` Ivo van Doorn [this message]
2008-08-03 13:36 ` Henrique de Moraes Holschuh
2008-08-03 13:21 ` Henrique de Moraes Holschuh
2008-08-03 13:50 ` Ivo van Doorn
2008-08-03 18:12 ` Johannes Berg
2008-08-02 18:11 ` [PATCH 6/8] rfkill: use the new WARN() Henrique de Moraes Holschuh
2008-08-03 8:10 ` Ivo van Doorn
2008-08-03 13:32 ` Henrique de Moraes Holschuh
2008-08-02 18:11 ` [PATCH 7/8] rfkill: rename rfkill_mutex to rfkill_global_mutex Henrique de Moraes Holschuh
2008-08-02 18:11 ` [PATCH 8/8] rfkill: add support for wake-on-wireless-packet Henrique de Moraes Holschuh
2008-08-02 19:02 ` Johannes Berg
2008-08-02 19:27 ` Henrique de Moraes Holschuh
2008-08-02 21:21 ` Tomas Winkler
2008-08-03 3:55 ` Henrique de Moraes Holschuh
2008-08-03 6:03 ` Tomas Winkler
2008-08-03 13:52 ` Henrique de Moraes Holschuh
2008-08-03 15:49 ` Tomas Winkler
2008-08-03 18:25 ` Henrique de Moraes Holschuh
2008-08-03 22:36 ` Tomas Winkler
2008-08-04 2:52 ` Henrique de Moraes Holschuh
2008-08-03 8:12 ` Ivo van Doorn
2008-08-03 8:07 ` Tomas Winkler
2008-08-03 13:44 ` Henrique de Moraes Holschuh
2008-08-03 14:12 ` Tomas Winkler
2008-08-04 15:42 ` Dan Williams
2008-08-04 22:30 ` Henrique de Moraes Holschuh
2008-08-04 22:56 ` Dan Williams
2008-08-04 23:35 ` Henrique de Moraes Holschuh
2008-08-05 9:12 ` Johannes Berg
2008-08-05 12:48 ` Henrique de Moraes Holschuh
2008-08-05 12:50 ` Johannes Berg
2008-08-05 12:59 ` Johannes Berg
2008-08-05 20:44 ` Henrique de Moraes Holschuh
2008-08-05 20:54 ` Johannes Berg
2008-08-05 13:03 ` Dan Williams
2008-08-05 14:00 ` John W. Linville
2008-08-05 18:37 ` Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808031553.58030.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).