Linux wireless drivers development
 help / color / mirror / Atom feed
From: Jouni Malinen <j@w1.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Luis Carlos Cobo <luisca@cozybit.com>
Subject: Re: [RFC] mac80211/cfg80211: Add BSS configuration options for AP mode
Date: Thu, 7 Aug 2008 19:32:13 +0300	[thread overview]
Message-ID: <20080807163213.GA6602@jm.kir.nu> (raw)
In-Reply-To: <1218120388.23048.189.camel@johannes.berg>

On Thu, Aug 07, 2008 at 04:46:28PM +0200, Johannes Berg wrote:
> On Thu, 2008-08-07 at 17:27 +0300, Jouni Malinen wrote:
> > Well, I don't actually need it per-BSS for hardware that I'm most likely
> > to work with ;-), but yeah, this is a per-BSS parameter, so in that
> > sense your patch is doing the correct thing.
> 
> Yeah, ok, I guess I don't really care, do whichever way you want. It'd
> be a bit strange to set it with cfg80211 per BSS and have it show up on
> different BSSes, but that's about it, and a little strangeness hasn't
> hurt anyone ;)

It looks like it is easiest to make this a per-BSS parameter now and use
bss_info_changed() for it. However, I'm planning on leaving the other
parts of your patch out from the initial version. In other words, I will
not remove IEEE80211_CONF_SHORT_SLOT_TIME now (I just added a TODO note
to get it removed once drivers have been converted; mac80211 was never
actually setting this, anyway). This avoids the need to modify all
drivers with this change. In addition, I'm leaving out the client MLME
stuff for now, but the notification part will be available for it once
the MLME code is added.

-- 
Jouni Malinen                                            PGP id EFC895FA

  reply	other threads:[~2008-08-07 16:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-07 13:40 [RFC] mac80211/cfg80211: Add BSS configuration options for AP mode Jouni Malinen
2008-08-07 13:48 ` Johannes Berg
2008-08-07 14:15   ` Jouni Malinen
2008-08-07 14:18     ` Johannes Berg
2008-08-07 14:27       ` Jouni Malinen
2008-08-07 14:46         ` Johannes Berg
2008-08-07 16:32           ` Jouni Malinen [this message]
2008-08-07 14:25 ` Johannes Berg
2008-08-07 14:32   ` Jouni Malinen
2008-08-07 14:45     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080807163213.GA6602@jm.kir.nu \
    --to=j@w1.fi \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luisca@cozybit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox