Re: [PATCH] p54: Fix for TX sequence number problem that resulted from commit 741b4fbc44

[Chr <chunkeey@web.de>]

On Sunday 10 August 2008 16:19:10 Larry Finger wrote:
> Chr wrote:
> > the next one is at line 27188... and so down to end of packages at line
> > 329241. there isn't one single package where the sequence number is not
> > zero!
> >
> > So the problem must be somewhere else! what happens when:
> > if (info->flags & IEEE80211_TX_CTL_ASSIGN_SEQ) {
> > 	if (info->flags & IEEE80211_TX_CTL_FIRST_FRAGMENT)
> > 		priv->seqno += 0x10;
> >
> > 	ieee80211hdr->seq_ctrl &= cpu_to_le16(IEEE80211_SCTL_FRAG);
> > 	ieee80211hdr->seq_ctrl |= cpu_to_le16(priv->seqno);
> > 	ieee80211hdr->seq_ctrl &= cpu_to_le16(IEEE80211_SCTL_FRAG);
> > }
> > (yeah a new definition for idiotic! but it's about the same amount of of
> > clock cycles).
>
> There must be some situation where the firmware fails to assign a
> proper sequence number to some packets. With this patch in place, the
> device failed after 2 hours. Restoring my original patch, it has been
> up for 15 hours and still going.
well, if you don't ping around with -s 1400 of course ;-).

On the other hand, it doesn't break anything (that wasn't broken before) and 
if real helps, why not?

Acked-by: Christian Lamparter <chunkeey@web.de>