linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: John Linville <linville@tuxdriver.com>,
	stable@kernel.org, linux-wireless@vger.kernel.org,
	Peter Chubb <peterc@gelato.unsw.edu.au>,
	linux-kernel@vger.kernel.org
Subject: Re: [stable] Fixing rt2500pci [PATCH]
Date: Sat, 16 Aug 2008 16:32:49 -0700	[thread overview]
Message-ID: <20080816233249.GA9714@kroah.com> (raw)
In-Reply-To: <200808121201.26544.IvDoorn@gmail.com>

On Tue, Aug 12, 2008 at 12:01:26PM +0200, Ivo van Doorn wrote:
> On Thursday 31 July 2008, Peter Chubb wrote:
> > 
> > In kernel version 2.6.26-rc9 my wireless LAN card worked; but in the
> > released 2.6.26, my RaLink rt2500 card wouldn't associate.
> > 
> > Git-bisect led me to this patch:
> > 
> > 	61486e0f68d1f8966c09b734566a187d42d65c54
> > 	rt2x00: Remove ieee80211_tx_control argument from write_tx_desc()
> > 
> > I believe that there is a problem with that patch --- it
> > (inadvertantly) removes an extra line of code, that used to set the
> > DATABYTE_COUNT field.
> >  
> > This patch reinstates that line, and with it my card works again.
> >  
> > Signed-off-by: Peter Chubb <peterc@gelato.unsw.edu.au>
> > Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> 
> [stable@kernel.org added to CC]
> 
> The 2.6.27 version of the patch has already been pushed upstream,
> this one is for 2.6.26-stable since this fixes a regression introduced after 2.6.25.

Are you sure?  Looking at 2.6.26, the code in that function looks like
it is properly setting the TXD_W0_DATABYTE_COUNT, field.

If it's really a problem, can you send stable@kernel.org a patch that
applies to 2.6.26.2?

thanks,

greg k-h

  reply	other threads:[~2008-08-16 23:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-30  5:08 Fixing rt2500pci Peter Chubb
2008-07-30 19:05 ` Ivo van Doorn
2008-07-30 19:15   ` Ivo van Doorn
2008-07-31  0:56     ` Fixing rt2500pci [PATCH] Peter Chubb
2008-07-31  2:11       ` Peter Chubb
2008-07-31 21:51         ` John Daiker
2008-07-31  7:21       ` Ivo van Doorn
2008-08-12 10:01       ` Ivo van Doorn
2008-08-16 23:32         ` Greg KH [this message]
2008-08-17  8:58           ` [stable] " Ivo van Doorn
2008-07-31  4:07   ` Fixing rt2500pci Peter Chubb
2008-08-05  3:01     ` Peter Chubb
2008-08-05 18:44       ` Ivo van Doorn
2008-08-05 21:01         ` Peter Chubb
2008-08-06  1:10         ` Peter Chubb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080816233249.GA9714@kroah.com \
    --to=greg@kroah.com \
    --cc=ivdoorn@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=peterc@gelato.unsw.edu.au \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).