From: Ivo van Doorn <ivdoorn@gmail.com>
To: Philip Langdale <philipl@overt.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Matthew Garrett <mjg59@srcf.ucam.org>,
toshiba_acpi@memebeam.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/1] toshiba_acpi: Add support for bluetooth toggling through rfkill (v6)
Date: Wed, 20 Aug 2008 17:57:04 +0200 [thread overview]
Message-ID: <200808201757.04501.IvDoorn@gmail.com> (raw)
In-Reply-To: <48AB8902.3010406@overt.org>
Hi,
> + if (unlikely(state_changed)) {
> + rfkill_force_state(dev->rfk_dev,
> + new_rfk_state ?
> + RFKILL_STATE_SOFT_BLOCKED :
> + RFKILL_STATE_HARD_BLOCKED);
> + input_report_switch(poll_dev->input, SW_RFKILL_ALL, new_rfk_state);
> + }
> +}
This looks very nice, but is the switch really toggling between
soft and hard blocked only? ;)
I mean shouldn't there be some unblock signal at some point?
Ivo
next prev parent reply other threads:[~2008-08-20 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 3:01 [PATCH 1/1] toshiba_acpi: Add support for bluetooth toggling through rfkill (v6) Philip Langdale
2008-08-20 15:57 ` Ivo van Doorn [this message]
2008-08-20 17:01 ` Philip Langdale
2008-08-20 23:29 ` Henrique de Moraes Holschuh
2008-08-22 21:10 ` Andrew Morton
2008-08-22 22:25 ` [PATCH 1/1] toshiba_acpi: Add support for bluetooth togglingthrough " Philip Langdale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808201757.04501.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=philipl@overt.org \
--cc=toshiba_acpi@memebeam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).