linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: John Linville <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org, Ivo van Doorn <ivdoorn@gmail.com>,
	Matthew Garrett <mjg@redhat.com>,
	Andrew Bird <ajb@spheresystems.co.uk>,
	Cezary Jackiewicz <cezary.jackiewicz@gmail.com>,
	Philip Langdale <philipl@overt.org>
Subject: Re: [PATCH 5/5] rfkill: remove transmitter blocking on suspend
Date: Tue, 26 Aug 2008 08:39:48 -0700	[thread overview]
Message-ID: <20080826153948.GA18563@suse.de> (raw)
In-Reply-To: <1219762681-26911-6-git-send-email-hmh@hmh.eng.br>

On Tue, Aug 26, 2008 at 11:58:01AM -0300, Henrique de Moraes Holschuh wrote:
> Currently, rfkill would stand in the way of properly supporting wireless
> devices that are capable of waking the system up from sleep or hibernation
> when they receive a special wireless message.  It would also get in the way
> of mesh devices that need to remain operational even during platform
> suspend.
> 
> To avoid that, stop trying to block the transmitters on the rfkill class
> suspend handler.
> 
> Drivers that need rfkill's older behaviour will have to implement it by
> themselves in their own suspend handling.
> 
> Do note that rfkill *will* attempt to restore the transmitter state on
> resume in any situation.  This happens after the driver's resume method is
> called by the suspend core (class devices resume after the devices they are
> attached to have been resumed).
> 
> The following drivers need to check if they need to explicitly block
> their transmitters in their own suspend handlers (maintainers Cc'd):

Normally when you change a kernel-api to operate differently, you also
fix up the relevant parts of the kernel as well.  Have you looked into
these drivers to see if they do have this problem or not?

thanks,

greg k-h

  reply	other threads:[~2008-08-26 15:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-26 14:57 [GIT PATCH] rfkill changes for 2.6.28, set 1a Henrique de Moraes Holschuh
2008-08-26 14:57 ` [PATCH 1/5] rfkill: use strict_strtoul (v2) Henrique de Moraes Holschuh
2008-08-26 14:57 ` [PATCH 2/5] rfkill: add missing line break Henrique de Moraes Holschuh
2008-08-26 14:57 ` [PATCH 3/5] rfkill: add WARN and BUG_ON paranoia (v2) Henrique de Moraes Holschuh
2008-08-26 15:56   ` Ivo van Doorn
2008-08-26 14:58 ` [PATCH 4/5] rfkill: rename rfkill_mutex to rfkill_global_mutex Henrique de Moraes Holschuh
2008-08-26 14:58 ` [PATCH 5/5] rfkill: remove transmitter blocking on suspend Henrique de Moraes Holschuh
2008-08-26 15:39   ` Greg KH [this message]
2008-08-27  4:56     ` Henrique de Moraes Holschuh
2008-08-26 16:13   ` Ivo van Doorn
2008-08-26 19:49     ` Tomas Winkler
2008-08-27 23:01     ` Henrique de Moraes Holschuh
2008-08-28 14:29       ` Ivo van Doorn
2008-08-26 22:56   ` Philip Langdale
2008-09-03 19:05   ` John W. Linville
2008-09-03 21:20     ` Henrique de Moraes Holschuh
2008-09-03 21:31       ` Michael Buesch
2008-09-09 19:22       ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080826153948.GA18563@suse.de \
    --to=gregkh@suse.de \
    --cc=ajb@spheresystems.co.uk \
    --cc=cezary.jackiewicz@gmail.com \
    --cc=hmh@hmh.eng.br \
    --cc=ivdoorn@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mjg@redhat.com \
    --cc=philipl@overt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).