Re: [PATCH] mac80211: Fix debugfs union misuse and pointer corruption

[Jouni Malinen <j@w1.fi>]

On Thu, Aug 28, 2008 at 02:18:43PM +0200, Johannes Berg wrote:

> Acked-by: Johannes Berg <johannes@sipsolutions.net>
> 
> also the other similar patch, sorry about this, it's surely my mistake.

Dave already took the other fix. This new one is a bit less likely to
cause real problems for most users (i.e., I'm not too concerned about
getting this into 2.6.27).

I'm trying to fix the netdev:mon.wlan0 not being removed correctly
with my 802.11w patches (incorrect order in debugfs keys vs. netdev
deletion) and was seeing very strange behavior here.. I had just added
yet another dentry into the union since I was just duplicating the code
used for default_key symlink.. None of the debug prints made any sense
until I noticed that these "two" pointers were actually changing values
at the same time.. Unions are evil if you do not notice you are using
one ;-).

-- 
Jouni Malinen                                            PGP id EFC895FA