public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Jouni Malinen <j@w1.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] mac80211: Reorder debugfs calls during netdev deinit
Date: Thu, 28 Aug 2008 17:55:49 +0300	[thread overview]
Message-ID: <20080828145549.GF4863@jm.kir.nu> (raw)
In-Reply-To: <1219933734.25321.16.camel@johannes.berg>

On Thu, Aug 28, 2008 at 04:28:54PM +0200, Johannes Berg wrote:

> > It looks like someone has cleaned up the netdev uninit sequence (which
> > was quite a mess at the time I looked at it last and ended up just
> > delaying the fix till now..) and that seems to make it trivial to fix
> > the deinit order issue.
> 
> Yeah, that was me, I mostly rewrote the junk in iface.c.

Thanks! That saved lots of work.

> Seems sane to me.
> 
> Not that I like the workaround of setting keys on the monitor, in fact,
> I think it shouldn't be allowed ;)

Well, I don't like it either and it is next on my list for 802.11w
work.. I just needed to get mac80211 into a state where 802.11w works
and I do not need to reboot every time when I re-load mac80211 ;-).
Anyway, this reordering of the calls is correct even if the key was not
set for the monitor netdev; I just don't know whether there is any other
way to trigger this particular issue.

-- 
Jouni Malinen                                            PGP id EFC895FA

      reply	other threads:[~2008-08-28 14:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-28 13:56 [RFC] mac80211: Reorder debugfs calls during netdev deinit Jouni Malinen
2008-08-28 14:28 ` Johannes Berg
2008-08-28 14:55   ` Jouni Malinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080828145549.GF4863@jm.kir.nu \
    --to=j@w1.fi \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox