Re: [PATCH 5/5] rfkill: remove transmitter blocking on suspend

[Ivo van Doorn <ivdoorn@gmail.com>]

On Thursday 28 August 2008, Henrique de Moraes Holschuh wrote:
> On Tue, 26 Aug 2008, Ivo van Doorn wrote:
> > > 	drivers/net/wireless/rt2x00/* (USB might need it?)
> > 
> > rt2x00 doesn't have rfkill support for the USB drivers, only the PCI drivers,
> > (because only those cards could have an actual rfkill switch.
> 
> Well, rfkill support is not related only to input devices, but also to
> transmitters.  And EVERY transmitter MUST have one (and a single one) rfkill
> class attached to it, unless the hardware is completely and utterly unable
> to block its transmitter(s).  I hope no rt2x00 device is like that...

True, but at the moment the rt2x00 implementation is limited to the PCI devices
which indicate they have the input device. Extending it to register the rfkill
structure for all rt2x00 hardware is on my todo list.

> > Other then that no changes are required in rt2x00 with this patch.
> 
> Which I will take to mean that all rt2x00 drivers, be them USB or PCI, will
> do whatever is needed (including shutting down transmitters explicitly, when
> the hardware doesn't do it implicitly because of something else the driver
> is doing) on their own suspend() methods.
> 
> Is that correct?  Because that's all patch 5 of 5 is concerned with.

That is correct, all rt2x00 drivers (with or without rfkill) will do this correctly.

Ivo