From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bu3sch.de ([62.75.166.246]:45207 "EHLO vs166246.vserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbYIFS4P (ORCPT ); Sat, 6 Sep 2008 14:56:15 -0400 From: Michael Buesch To: Larry Finger Subject: Re: [PATCH] b43legacy: Fix failure in rate-adjustment mechanism Date: Sat, 6 Sep 2008 20:55:51 +0200 Cc: bcm43xx-dev@lists.berlios.de, John W Linville , Tim Gardner , linux-wireless@vger.kernel.org References: <48c2cd1a.pA60sTEK0WsW6wtt%Larry.Finger@lwfinger.net> <200809062041.06035.mb@bu3sch.de> <48C2D185.4000003@lwfinger.net> In-Reply-To: <48C2D185.4000003@lwfinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Message-Id: <200809062055.51797.mb@bu3sch.de> (sfid-20080906_205617_386457_7E0F455E) Sender: linux-wireless-owner@vger.kernel.org List-ID: On Saturday 06 September 2008 20:52:53 Larry Finger wrote: > Michael Buesch wrote: > > On Saturday 06 September 2008 20:34:02 Larry Finger wrote: > >> A coding error present since b43legacy was incorporated into the > >> kernel has prevented the driver from using the rate-setting mechanism > >> of mac80211. The driver has been forced to remain at a 1 Mb/s rate. > > > > Does version3 firmware have a different bitlayout for the status? > > It seems so. I found this because I was not getting any acks back to > net/mac80211/rc80211_pid_algo.c. I then reviewed the V3 specs, found > that bit 0, not bit 1, contained the ack. Test prints confirmed that > result. With this patch, both my BCM4306/2 and BCM4303 reach the > maximum rate. With the current code, 54 Mb/s is not as fast as 36 > Mb/s, but at least the algorithm is working. Yeah ok. I just asked, because it seems the _whole_ flags bitfield is rightshifted by one (so the other flags are wrong, too. See the intermediate flag) -- Greetings Michael.