Re: [PATCH V2] b43legacy: Fix failure in rate-adjustment mechanism

[Greg KH <greg@kroah.com>]

On Sun, Sep 07, 2008 at 12:40:04AM +0200, Michael Buesch wrote:
> On Saturday 06 September 2008 23:51:22 Larry Finger wrote:
> > A coding error present since b43legacy was incorporated into the
> > kernel has prevented the driver from using the rate-setting mechanism
> > of mac80211. The driver has been forced to remain at a 1 Mb/s rate.
> > 
> > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> > Cc: Stable <stable@kernel.org>		[2.6.26], [2.6.25]
> 
> Reviewed-by: Michael Buesch <mb@bu3sch.de>
> 
> > ---
> > 
> > John,
> > 
> > This is a bug, not a regression. I guess under the new rules that it
> > is 2.6.28 material.
> 
> I wonder what the -stable rules are.

Bug fixes, not new features, it's pretty simple :)

> It seems really screwed to me to avoid applying the fix to 2.6.27,
> but still apply it to 2.6.25/26-stable.

I have to wait until it is in upstream before adding it to the -stable
tree, so this will not happen.

> I'd like to see this patch in .25, .26 and .27, however I'm not sure
> what the rules are.
> 
> For reference:
> Three people agree on the correctness of the patch, it's a oneliner
> and it's tested to fix the bug. However it is not a regression. The
> bug is in there since day-0 of b43legacy. But this fix improves
> TX rates a lot.

If it goes into .27, please forward it on to stable@kernel.org so we can
include it in older releases.

thanks,

greg k-h