Re: [RFC] mac80211: re-enable aggregation on 2.6.27

["Luis R. Rodriguez" <lrodriguez@atheros.com>]

On Mon, Sep 15, 2008 at 04:06:18PM -0700, Tomas Winkler wrote:
> On Mon, Sep 15, 2008 at 9:26 PM, Luis R. Rodriguez
> <lrodriguez@atheros.com> wrote:
> > Re-enable aggregation by addressing skb->cb overwrites
> > after insertion into the qdisc. Aggregation was disabled
> > after the new TX multiqueue changes were introduced. Instead
> > of relying on the skb->cb we use two flags on the skb.
> >
> > Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> > ---
> >
> > Users have been reporting low rates on 2.6.27 with 11n drivers, the
> > problem isbeen 11n aggregation was disabled due to the new TX multique
> > changes. We should have addressed this sooner but we just got to it now.
> >
> > Without addressing this we won't get 11n aggregation on 2.6.27. I tried
> > to minimize the changes required. I'm about to test this, it compiles.
> >
> > If this doesn't get upstream for 27 perhaps distributions are willing to
> > carry it around then and if so oh well (grr...).
> >
> I'm cleaning this up.

Great.

> I will probably drop skb->is_part_ampdu so no
> changes in the drivers will be required.

How so? I mean, if the flag is modified it'll need modification.

  Luis