From: Michael Buesch <mb@bu3sch.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John W Linville <linville@tuxdriver.com>,
bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] b43: Issue warning when RFKILL_INPUT is not enabled
Date: Tue, 16 Sep 2008 15:11:10 +0200 [thread overview]
Message-ID: <200809161511.11503.mb@bu3sch.de> (raw)
In-Reply-To: <48cebaca.pA4AdA6Dj23Wwt4K%Larry.Finger@lwfinger.net>
On Monday 15 September 2008 21:43:06 Larry Finger wrote:
> If the system is misconfigured with CONFIG_RFKILL set but CONFIG_RFKILL_INPUT
> not set, the built-in radio LEDs will not work. In the current code, no warning
> is issued.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
This is wrong. Please do something like the following:
Index: wireless-testing/drivers/net/wireless/b43/rfkill.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/b43/rfkill.c
+++ wireless-testing/drivers/net/wireless/b43/rfkill.c
@@ -186,6 +186,9 @@ void b43_rfkill_init(struct b43_wldev *d
if (err)
b43warn(wl, "Failed to load the rfkill-input module. "
"The built-in radio LED will not work.\n");
#endif /* CONFIG_RFKILL_INPUT */
+
+#if !defined(CONFIG_RFKILL_INPUT) && !defined(CONFIG_RFKILL_INPUT_MODULE)
+ b43warn(wl, "The rfkill-input subsystem is not available. "
+ "The built-in radio LED will not work.\n");
+#endif
err = input_register_polled_device(rfk->poll_dev);
--
Greetings Michael.
prev parent reply other threads:[~2008-09-16 13:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-15 19:43 [PATCH] b43: Issue warning when RFKILL_INPUT is not enabled Larry Finger
2008-09-16 13:11 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809161511.11503.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).