* [PATCH] b43: Issue warning when RFKILL_INPUT is not enabled
@ 2008-09-15 19:43 Larry Finger
2008-09-16 13:11 ` Michael Buesch
0 siblings, 1 reply; 2+ messages in thread
From: Larry Finger @ 2008-09-15 19:43 UTC (permalink / raw)
To: John W Linville, Michael Buesch; +Cc: bcm43xx-dev, linux-wireless
If the system is misconfigured with CONFIG_RFKILL set but CONFIG_RFKILL_INPUT
not set, the built-in radio LEDs will not work. In the current code, no warning
is issued.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
John,
This is material for the next merge.
Larry
Index: wireless-testing/drivers/net/wireless/b43/rfkill.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/b43/rfkill.c
+++ wireless-testing/drivers/net/wireless/b43/rfkill.c
@@ -186,6 +186,9 @@ void b43_rfkill_init(struct b43_wldev *d
if (err)
b43warn(wl, "Failed to load the rfkill-input module. "
"The built-in radio LED will not work.\n");
+#else
+ b43warn(wl, "The rfkill-input subsystem is not available. "
+ "The built-in radio LED will not work.\n");
#endif /* CONFIG_RFKILL_INPUT */
err = input_register_polled_device(rfk->poll_dev);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] b43: Issue warning when RFKILL_INPUT is not enabled
2008-09-15 19:43 [PATCH] b43: Issue warning when RFKILL_INPUT is not enabled Larry Finger
@ 2008-09-16 13:11 ` Michael Buesch
0 siblings, 0 replies; 2+ messages in thread
From: Michael Buesch @ 2008-09-16 13:11 UTC (permalink / raw)
To: Larry Finger; +Cc: John W Linville, bcm43xx-dev, linux-wireless
On Monday 15 September 2008 21:43:06 Larry Finger wrote:
> If the system is misconfigured with CONFIG_RFKILL set but CONFIG_RFKILL_INPUT
> not set, the built-in radio LEDs will not work. In the current code, no warning
> is issued.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
This is wrong. Please do something like the following:
Index: wireless-testing/drivers/net/wireless/b43/rfkill.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/b43/rfkill.c
+++ wireless-testing/drivers/net/wireless/b43/rfkill.c
@@ -186,6 +186,9 @@ void b43_rfkill_init(struct b43_wldev *d
if (err)
b43warn(wl, "Failed to load the rfkill-input module. "
"The built-in radio LED will not work.\n");
#endif /* CONFIG_RFKILL_INPUT */
+
+#if !defined(CONFIG_RFKILL_INPUT) && !defined(CONFIG_RFKILL_INPUT_MODULE)
+ b43warn(wl, "The rfkill-input subsystem is not available. "
+ "The built-in radio LED will not work.\n");
+#endif
err = input_register_polled_device(rfk->poll_dev);
--
Greetings Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-16 13:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-15 19:43 [PATCH] b43: Issue warning when RFKILL_INPUT is not enabled Larry Finger
2008-09-16 13:11 ` Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).