From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Michael Buesch <mb@bu3sch.de>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Carlos Corbacho <carlos@strangeworlds.co.uk>,
Adel Gadllah <adel.gadllah@gmail.com>,
wireless <linux-wireless@vger.kernel.org>,
bcm43xx-dev@lists.berlios.de, LKML <linux-kernel@vger.kernel.org>
Subject: Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74ef03a3baf035412c95192b54dfc6f
Date: Wed, 17 Sep 2008 12:36:37 -0300 [thread overview]
Message-ID: <20080917153637.GD5186@khazad-dum.debian.net> (raw)
In-Reply-To: <48D1221B.1000601@lwfinger.net>
On Wed, 17 Sep 2008, Larry Finger wrote:
> Henrique de Moraes Holschuh wrote:
> > He means rfkill_force_state() should change the LED state in the process,
> > which it isn't doing.
> >
> > It is an one-line patch, I am testing it now.
>
> If your one-line patch fixes my regression, then I'll ACK it for 2.6.27.
Sorry, it can't fix that regression by itself, since b43 is not using
rfkill_force_state() in mainline.
It will fix the same issue you are experiencing on b43 in anything that uses
rfkill_force_state(), which means (for mainline): iwlwifi, rt2x00,
thinkpad-acpi and hp-wmi.
It is a regression only on b43 and thinkpad-acpi, as the other drivers above
didn't use rfkill_force_state() in 2.6.26.
To fix the regression in b43, you'd be faced with the need of both my simple
patch AND Matthew's more complex one.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2008-09-17 15:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-16 14:18 Regression in 2.6.27-rcX caused by commit bc19d6e0b74ef03a3baf035412c95192b54dfc6f Larry Finger
2008-09-16 15:42 ` Michael Buesch
2008-09-16 17:08 ` Larry Finger
2008-09-16 19:18 ` Carlos Corbacho
2008-09-16 19:25 ` Michael Buesch
2008-09-16 22:37 ` Henrique de Moraes Holschuh
2008-09-17 14:26 ` Michael Buesch
2008-09-17 14:29 ` John W. Linville
2008-09-17 14:33 ` Michael Buesch
2008-09-16 19:30 ` Larry Finger
2008-09-16 23:32 ` Matthew Garrett
2008-09-17 2:33 ` Henrique de Moraes Holschuh
2008-09-17 2:52 ` Larry Finger
2008-09-17 13:23 ` John W. Linville
2008-09-17 20:07 ` [PATCH] rfkill: update LEDs for all state changes Henrique de Moraes Holschuh
2008-09-17 20:55 ` Larry Finger
2008-09-18 12:43 ` Henrique de Moraes Holschuh
2008-09-18 13:09 ` Larry Finger
2008-09-18 13:18 ` Henrique de Moraes Holschuh
2008-09-18 12:49 ` Ivo van Doorn
2008-09-17 14:22 ` Regression in 2.6.27-rcX caused by commit bc19d6e0b74ef03a3baf035412c95192b54dfc6f Michael Buesch
2008-09-17 14:50 ` Henrique de Moraes Holschuh
2008-09-17 15:28 ` Larry Finger
2008-09-17 15:36 ` Henrique de Moraes Holschuh [this message]
2008-09-17 15:47 ` Larry Finger
2008-09-16 19:51 ` Matthew Garrett
2008-09-16 20:34 ` Larry Finger
2008-09-16 21:09 ` Matthew Garrett
2008-09-17 14:19 ` Michael Buesch
2008-09-17 15:18 ` Henrique de Moraes Holschuh
2008-09-17 15:59 ` Michael Buesch
2008-09-17 20:51 ` Tomas Winkler
2008-09-18 13:16 ` Henrique de Moraes Holschuh
2008-09-16 20:44 ` Carlos Corbacho
2008-09-16 21:07 ` Larry Finger
2008-09-16 22:40 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080917153637.GD5186@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=Larry.Finger@lwfinger.net \
--cc=adel.gadllah@gmail.com \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=carlos@strangeworlds.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).