From: Ivo van Doorn <ivdoorn@gmail.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
John W Linville <linville@tuxdriver.com>,
bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [RFC] b43: A patch for control of the radio LED using rfkill
Date: Thu, 18 Sep 2008 16:24:52 +0200 [thread overview]
Message-ID: <200809181624.53050.IvDoorn@gmail.com> (raw)
In-Reply-To: <20080918141006.GE1583@khazad-dum.debian.net>
On Thursday 18 September 2008, Henrique de Moraes Holschuh wrote:
> On Thu, 18 Sep 2008, Ivo van Doorn wrote:
> > If it is something coming from mac80211, then you do not want
> > to send a SOFT_BLOCKED event since that will cause all other radios
> > to be switched off simply because the b43 interface has not been
> > enabled.
>
> Drivers ARE supposed to be able to set their radio state to their heart's
> content, without messing with any other devices. There are no constraints
> to calls to rfkill_force_state(), other than the current issue that it must
> not be done from an atomic context.
My main point was that when the radio is not enabled because the user
did something like "iwconfig wlan0 txpower off" then this is not an rfkill
SOFT_BLOCKED event. Since that command has nothing to do with the
entire rfkill layer.
When you consider such commands as rfkill events you get wrong behavior
because it would trigger a SOFT_BLOCK in rfkill which will be send to all
registered drivers who can disable their radio off as well. And that is
definately not what you want...
Ivo
next prev parent reply other threads:[~2008-09-18 14:24 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 5:07 [RFC] b43: A patch for control of the radio LED using rfkill Larry Finger
2008-09-18 13:19 ` Ivo van Doorn
2008-09-18 13:47 ` Larry Finger
2008-09-18 13:53 ` Ivo van Doorn
2008-09-18 14:21 ` Henrique de Moraes Holschuh
2008-09-18 14:26 ` Ivo van Doorn
2008-09-18 14:52 ` Henrique de Moraes Holschuh
2008-09-18 15:19 ` [PATCH] rfkill: clarify usage of rfkill_force_state() and rfkill->get_state() Henrique de Moraes Holschuh
2008-09-18 15:24 ` Ivo van Doorn
2008-09-18 16:43 ` Henrique de Moraes Holschuh
2008-09-18 16:45 ` Johannes Berg
2008-09-18 17:32 ` Ivo van Doorn
2008-09-18 17:52 ` Johannes Berg
2008-09-18 18:12 ` Ivo van Doorn
2008-09-18 17:40 ` Ivo van Doorn
2008-09-18 17:41 ` [RFC] b43: A patch for control of the radio LED using rfkill Michael Buesch
2008-09-18 17:37 ` Michael Buesch
2008-09-18 17:48 ` Ivo van Doorn
2008-09-18 17:56 ` Michael Buesch
2008-09-18 18:10 ` Ivo van Doorn
2008-09-18 18:17 ` Michael Buesch
2008-09-18 18:23 ` Ivo van Doorn
2008-09-18 18:34 ` Michael Buesch
2008-09-18 18:36 ` Johannes Berg
2008-09-18 19:23 ` Henrique de Moraes Holschuh
2008-09-18 20:09 ` Ivo van Doorn
2008-09-18 19:08 ` Henrique de Moraes Holschuh
2008-09-18 20:17 ` Ivo van Doorn
2008-09-18 20:28 ` Henrique de Moraes Holschuh
2008-09-18 20:42 ` Ivo van Doorn
2008-09-18 17:34 ` Michael Buesch
2008-09-18 17:42 ` Ivo van Doorn
2008-09-18 17:49 ` Johannes Berg
2008-09-18 18:02 ` Ivo van Doorn
2008-09-18 19:50 ` Henrique de Moraes Holschuh
2008-09-18 17:53 ` Michael Buesch
2008-09-18 18:06 ` Ivo van Doorn
2008-09-18 14:10 ` Henrique de Moraes Holschuh
2008-09-18 14:24 ` Ivo van Doorn [this message]
2008-09-18 14:37 ` Henrique de Moraes Holschuh
2008-09-18 15:16 ` Ivo van Doorn
2008-09-18 16:08 ` Henrique de Moraes Holschuh
2008-09-18 16:51 ` Ivo van Doorn
2008-09-18 18:47 ` Henrique de Moraes Holschuh
2008-09-18 19:14 ` Johannes Berg
2008-09-18 20:35 ` Ivo van Doorn
2008-09-18 21:34 ` Henrique de Moraes Holschuh
2008-09-18 17:44 ` Michael Buesch
2008-09-18 17:52 ` Ivo van Doorn
2008-09-18 17:54 ` Johannes Berg
2008-09-18 18:06 ` Ivo van Doorn
2008-09-18 18:13 ` Johannes Berg
2008-09-18 20:10 ` Henrique de Moraes Holschuh
2008-09-18 20:41 ` Ivo van Doorn
2008-09-18 21:36 ` Henrique de Moraes Holschuh
2008-09-19 17:02 ` Ivo van Doorn
2008-09-20 13:10 ` Henrique de Moraes Holschuh
2008-09-20 13:20 ` Ivo van Doorn
2008-09-22 3:01 ` Henrique de Moraes Holschuh
2008-09-22 21:16 ` Michael Buesch
2008-09-18 17:31 ` Michael Buesch
2008-09-18 20:13 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809181624.53050.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=hmh@hmh.eng.br \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).