Re: [RFC V2] b43: A patch for control of the radio LED using rfkill

[Ivo van Doorn <ivdoorn@gmail.com>]

On Thursday 18 September 2008, Henrique de Moraes Holschuh wrote:
> On Thu, 18 Sep 2008, Larry Finger wrote:
> > The changes below, along with Henriques patch "[PATCH] rfkill: update
> > LEDs for all state changes", and the reversion of commit bc19d6e make
> > the wireless LED toggle correctly.
> > 
> > This version passes UNBLOCKED to rfkill when the hardware switch enables the radio.
> 
> As I said in an email I just sent (unfortunately, after you already sent
> this patch), whatever goes to rfkill_force_state must be the CURRENT state
> of the hardware.
> 
> So, depending on what happens to b43 hardware when the hardware switch
> enables it (i.e. does it enable for real, ignoring the software rfkill input
> lines?), this patch might or might not be correct.

As far as I can see the v2 patch is correct, it sends the BLOCK event when the
rfkill key was pressed to block the radio and the UNBLOCK event when the rfkill
key was pressed to unblock the radio.

The change compared to v1 was needed to prevent BLOCK events to be send
when user has manually disabled the radio for the interface through another
interface then rfkill (and thus wasn't a rfkill event).

Ivo