From: Michael Buesch <mb@bu3sch.de>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
ivdoorn@gmail.com, bcm43xx-dev@lists.berlios.de,
linux-wireless@vger.kernel.org
Subject: Re: [RFC V2] b43: A patch for control of the radio LED using rfkill
Date: Thu, 18 Sep 2008 19:14:58 +0200 [thread overview]
Message-ID: <200809181914.58417.mb@bu3sch.de> (raw)
In-Reply-To: <20080918142405.GG1583@khazad-dum.debian.net>
On Thursday 18 September 2008 16:24:05 Henrique de Moraes Holschuh wrote:
> On Thu, 18 Sep 2008, Larry Finger wrote:
> > The changes below, along with Henriques patch "[PATCH] rfkill: update
> > LEDs for all state changes", and the reversion of commit bc19d6e make
> > the wireless LED toggle correctly.
> >
> > This version passes UNBLOCKED to rfkill when the hardware switch enables the radio.
>
> As I said in an email I just sent (unfortunately, after you already sent
> this patch), whatever goes to rfkill_force_state must be the CURRENT state
> of the hardware.
>
> So, depending on what happens to b43 hardware when the hardware switch
> enables it (i.e. does it enable for real, ignoring the software rfkill input
> lines?), this patch might or might not be correct.
It does enable it, but software might still be blocking it.
sw and hw rfkill are two unrelated things in b43.
--
Greetings Michael.
prev parent reply other threads:[~2008-09-18 17:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 14:07 [RFC V2] b43: A patch for control of the radio LED using rfkill Larry Finger
2008-09-18 14:24 ` Henrique de Moraes Holschuh
2008-09-18 14:28 ` Ivo van Doorn
2008-09-18 14:48 ` Henrique de Moraes Holschuh
2008-09-18 15:17 ` Larry Finger
2008-09-18 16:24 ` Henrique de Moraes Holschuh
2008-09-18 16:49 ` Larry Finger
2008-09-18 17:20 ` Michael Buesch
2008-09-18 20:21 ` Henrique de Moraes Holschuh
2008-09-18 20:32 ` Henrique de Moraes Holschuh
2008-09-18 17:46 ` Michael Buesch
2008-09-18 20:24 ` Henrique de Moraes Holschuh
2008-09-18 17:14 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809181914.58417.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=hmh@hmh.eng.br \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).