From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bu3sch.de ([62.75.166.246]:51099 "EHLO vs166246.vserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754941AbYIRRoe (ORCPT ); Thu, 18 Sep 2008 13:44:34 -0400 From: Michael Buesch To: Ivo van Doorn Subject: Re: [RFC] b43: A patch for control of the radio LED using rfkill Date: Thu, 18 Sep 2008 19:44:09 +0200 Cc: Henrique de Moraes Holschuh , Larry Finger , John W Linville , bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org References: <48d1e227.AmBwRnEuhx6kxlHv%Larry.Finger@lwfinger.net> <20080918141006.GE1583@khazad-dum.debian.net> <200809181624.53050.IvDoorn@gmail.com> In-Reply-To: <200809181624.53050.IvDoorn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Message-Id: <200809181944.10018.mb@bu3sch.de> (sfid-20080918_194438_480365_B693EC7C) Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thursday 18 September 2008 16:24:52 Ivo van Doorn wrote: > On Thursday 18 September 2008, Henrique de Moraes Holschuh wrote: > > On Thu, 18 Sep 2008, Ivo van Doorn wrote: > > > If it is something coming from mac80211, then you do not want > > > to send a SOFT_BLOCKED event since that will cause all other radios > > > to be switched off simply because the b43 interface has not been > > > enabled. > > > > Drivers ARE supposed to be able to set their radio state to their heart's > > content, without messing with any other devices. There are no constraints > > to calls to rfkill_force_state(), other than the current issue that it must > > not be done from an atomic context. > > My main point was that when the radio is not enabled because the user > did something like "iwconfig wlan0 txpower off" then this is not an rfkill > SOFT_BLOCKED event. Since that command has nothing to do with the > entire rfkill layer. > > When you consider such commands as rfkill events you get wrong behavior > because it would trigger a SOFT_BLOCK in rfkill which will be send to all > registered drivers who can disable their radio off as well. And that is > definately not what you want... Well, if that's the definition of the API, we must not force rfkill state to anything other than HW_BLOCKED or UNBLOCKED. I dunno how the API is defined... -- Greetings Michael.