Re: [ath5k-devel] Oops with current kernel and ath5k

["Bob Copeland" <me@bobcopeland.com>]

On Fri, 03 Oct 2008 16:42:17 +0200, Elias Oltmanns wrote
> I still feel uneasy about this. Granted, I haven't thought this through
> too carefully, but I'd rather not rely on the fact that ath5k_stop_hw()
> will not get called between the check for ATH_STAT_STARTED and the call
> to ath5k_init if I can help it. Perhaps you can add an argument `reinit'
> to ath5k_init() and do something like this under the mutex:
> 
> 	if (reinit && !test_bit(ATH_STAT_STARTED, sc->status)) {
> 		mutex_unlock(...);
> 		return;
> 	}

Shouldn't the freezer take care of this?  If userspace is suspended until
after devices are resumed, then, in a hand-wavy argument, I don't believe
->stop() could be called.  

Adding a flag to ath5k_init to make sure we do everything in the mutex would
certainly ensure that there's no issues.  On the other hand, I don't want to
cruft up the code too much since we know at some point mac80211 is going to
take down the interfaces in its suspend/resume callbacks, at which time the
flags can probably get tossed.

-- 
Bob Copeland %% www.bobcopeland.com