From: Bob Copeland <me@bobcopeland.com>
To: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
linville@tuxdriver.com, jirislaby@gmail.com, mcgrof@gmail.com,
nbd@openwrt.org
Subject: Re: [PATCH 4/5] ath5k: Fix SREV reporting after SREV updates
Date: Sat, 4 Oct 2008 20:37:10 -0400 [thread overview]
Message-ID: <20081005003710.GA3222@hash.localnet> (raw)
In-Reply-To: <20080928222444.GD21335@makis>
On Mon, Sep 29, 2008 at 01:24:44AM +0300, Nick Kossifidis wrote:
> * Fix srev reporting during attach
>
> Changes-Licensed-under: ISC
> Signed-Off-by: Nick Kossifidis <mickflemm@gmail.com>
This now identifies my card as 5414, whereas ath5k used to call it 5424
(mac srev 0xa3, phy 0x61).
But, madwifi has:
#define AR5K_SREV_VER_AR5424 0xa3 /* PCI-E */
It still works so not a major problem, but who's right?
> @@ -396,7 +396,11 @@ ath5k_chip_name(enum ath5k_srev_type type, u_int16_t val)
> for (i = 0; i < ARRAY_SIZE(srev_names); i++) {
> if (srev_names[i].sr_type != type)
> continue;
> - if ((val & 0xff) < srev_names[i + 1].sr_val) {
> +
> + if ((val & 0xf0) == srev_names[i].sr_val)
> + name = srev_names[i].sr_name;
> +
> + if ((val & 0xff) == srev_names[i].sr_val) {
> name = srev_names[i].sr_name;
> break;
> }
>
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2008-10-05 0:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-28 22:24 [PATCH 4/5] ath5k: Fix SREV reporting after SREV updates Nick Kossifidis
2008-10-05 0:37 ` Bob Copeland [this message]
2008-10-05 1:02 ` Luis R. Rodriguez
2008-10-05 1:25 ` [ath5k-devel] " Nick Kossifidis
2008-10-05 1:34 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081005003710.GA3222@hash.localnet \
--to=me@bobcopeland.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).