[PATCH ] mac80211: fix wrong link typo in mac80211_hwsim documentation.

[PATCH ] mac80211: fix wrong link typo in mac80211_hwsim documentation.

[Rami Rosen]

[-- Attachment #1: Type: text/plain, Size: 135 bytes --]

This patch fixes a wrong link typo in
Documentation/networking/mac80211_hwsim/README.


Signed-off-by: Rami Rosen <ramirose@gmail.com>

[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 678 bytes --]

diff --git a/Documentation/networking/mac80211_hwsim/README b/Documentation/networking/mac80211_hwsim/README
index 2ff8ccb..e044b8d 100644
--- a/Documentation/networking/mac80211_hwsim/README
+++ b/Documentation/networking/mac80211_hwsim/README
@@ -52,8 +52,7 @@ processing access point side of association.
 
 Please note that the current Linux kernel does not enable AP mode, so a
 simple patch is needed to enable AP mode selection:
-http://johannes.sipsolutions.net/patches/kernel/all/LATEST/006-allow-ap-vlan-modes.patch
-
+http://johannes.sipsolutions.net/patches/kernel/all/LATEST/004-allow-ap-vlan-modes.patch
 
 # Build mac80211_hwsim as part of kernel configuration
 

Re: [PATCH ] mac80211: fix wrong link typo in mac80211_hwsim documentation.

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

On Wed, 2008-10-08 at 11:43 +0200, Rami Rosen wrote:
> 
>  Please note that the current Linux kernel does not enable AP mode, so
> a
>  simple patch is needed to enable AP mode selection:
> -http://johannes.sipsolutions.net/patches/kernel/all/LATEST/006-allow-ap-vlan-modes.patch
> -
> +http://johannes.sipsolutions.net/patches/kernel/all/LATEST/004-allow-ap-vlan-modes.patch

No good, the numbering changes all the time.

johannes
 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH ] mac80211: fix wrong link typo in mac80211_hwsim documentation.

[Jouni Malinen]

On Wed, Oct 08, 2008 at 11:46:41AM +0200, Johannes Berg wrote:
> On Wed, 2008-10-08 at 11:43 +0200, Rami Rosen wrote:
> >  Please note that the current Linux kernel does not enable AP mode, so
> > a
> >  simple patch is needed to enable AP mode selection:
> > -http://johannes.sipsolutions.net/patches/kernel/all/LATEST/006-allow-ap-vlan-modes.patch
> > -
> > +http://johannes.sipsolutions.net/patches/kernel/all/LATEST/004-allow-ap-vlan-modes.patch
> 
> No good, the numbering changes all the time.

Well.. I see two possible fixes here: we'll finally apply that patch or
point to http://w1.fi/wireless-testing/enable-ap-mode.patch which does
not change its URL all the time.. I'm starting to lean more towards the
prior option, though, since I'm getting tired of pointing people to this
patch whenever they complain that hostapd does not work with mac80211.

-- 
Jouni Malinen                                            PGP id EFC895FA

Re: [PATCH ] mac80211: fix wrong link typo in mac80211_hwsim documentation.

[John W. Linville]

On Wed, Oct 08, 2008 at 07:18:34PM +0300, Jouni Malinen wrote:
> On Wed, Oct 08, 2008 at 11:46:41AM +0200, Johannes Berg wrote:
> > On Wed, 2008-10-08 at 11:43 +0200, Rami Rosen wrote:
> > >  Please note that the current Linux kernel does not enable AP mode, so
> > > a
> > >  simple patch is needed to enable AP mode selection:
> > > -http://johannes.sipsolutions.net/patches/kernel/all/LATEST/006-allow-ap-vlan-modes.patch
> > > -
> > > +http://johannes.sipsolutions.net/patches/kernel/all/LATEST/004-allow-ap-vlan-modes.patch
> > 
> > No good, the numbering changes all the time.
> 
> Well.. I see two possible fixes here: we'll finally apply that patch or
> point to http://w1.fi/wireless-testing/enable-ap-mode.patch which does
> not change its URL all the time.. I'm starting to lean more towards the
> prior option, though, since I'm getting tired of pointing people to this
> patch whenever they complain that hostapd does not work with mac80211.

Well I might be OK with that -- but are you (and Johannes) ready
to deal with the various "ap mode doesn't work with my hostapd
configuration" problems?

John
-- 
John W. Linville		Linux should be at the core
linville@tuxdriver.com			of your literate lifestyle.

Re: [PATCH ] mac80211: fix wrong link typo in mac80211_hwsim documentation.

[Jouni Malinen]

On Wed, Oct 08, 2008 at 03:01:09PM -0400, John W. Linville wrote:

> Well I might be OK with that -- but are you (and Johannes) ready
> to deal with the various "ap mode doesn't work with my hostapd
> configuration" problems?

I think that that is a better and more productive problem to handle
assuming the issues are indeed because of something missing from
cfg80211 configuration. I'm supposed to make sure that everything needed
is there anyway and getting additional people testing various
combinations and reporting potential problems sounds useful.

-- 
Jouni Malinen                                            PGP id EFC895FA

Re: [PATCH ] mac80211: fix wrong link typo in mac80211_hwsim documentation.

[John W. Linville]

On Wed, Oct 08, 2008 at 10:37:54PM +0300, Jouni Malinen wrote:
> On Wed, Oct 08, 2008 at 03:01:09PM -0400, John W. Linville wrote:
> 
> > Well I might be OK with that -- but are you (and Johannes) ready
> > to deal with the various "ap mode doesn't work with my hostapd
> > configuration" problems?
> 
> I think that that is a better and more productive problem to handle
> assuming the issues are indeed because of something missing from
> cfg80211 configuration. I'm supposed to make sure that everything needed
> is there anyway and getting additional people testing various
> combinations and reporting potential problems sounds useful.

I'm inclined to agree.  I'd like it if Johannes agreed too. :-)

-- 
John W. Linville		Linux should be at the core
linville@tuxdriver.com			of your literate lifestyle.

Re: [PATCH ] mac80211: fix wrong link typo in mac80211_hwsim documentation.

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]

On Wed, 2008-10-08 at 16:03 -0400, John W. Linville wrote:
> On Wed, Oct 08, 2008 at 10:37:54PM +0300, Jouni Malinen wrote:
> > On Wed, Oct 08, 2008 at 03:01:09PM -0400, John W. Linville wrote:
> > 
> > > Well I might be OK with that -- but are you (and Johannes) ready
> > > to deal with the various "ap mode doesn't work with my hostapd
> > > configuration" problems?
> > 
> > I think that that is a better and more productive problem to handle
> > assuming the issues are indeed because of something missing from
> > cfg80211 configuration. I'm supposed to make sure that everything needed
> > is there anyway and getting additional people testing various
> > combinations and reporting potential problems sounds useful.
> 
> I'm inclined to agree.  I'd like it if Johannes agreed too. :-)

I'd hate shipping it when there are still things to work out; how about
we put it into -testing but not into -next? I just looked at the list
and we still have
  * basic rate set
  * tx queue params

left to do.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH ] mac80211: fix wrong link typo in mac80211_hwsim documentation.

[John W. Linville]

On Thu, Oct 09, 2008 at 11:39:59AM +0200, Johannes Berg wrote:
> On Wed, 2008-10-08 at 16:03 -0400, John W. Linville wrote:
> > On Wed, Oct 08, 2008 at 10:37:54PM +0300, Jouni Malinen wrote:
> > > On Wed, Oct 08, 2008 at 03:01:09PM -0400, John W. Linville wrote:
> > > 
> > > > Well I might be OK with that -- but are you (and Johannes) ready
> > > > to deal with the various "ap mode doesn't work with my hostapd
> > > > configuration" problems?
> > > 
> > > I think that that is a better and more productive problem to handle
> > > assuming the issues are indeed because of something missing from
> > > cfg80211 configuration. I'm supposed to make sure that everything needed
> > > is there anyway and getting additional people testing various
> > > combinations and reporting potential problems sounds useful.
> > 
> > I'm inclined to agree.  I'd like it if Johannes agreed too. :-)
> 
> I'd hate shipping it when there are still things to work out; how about
> we put it into -testing but not into -next? I just looked at the list
> and we still have
>   * basic rate set
>   * tx queue params
> 
> left to do.

I can probably live with that.

-- 
John W. Linville		Linux should be at the core
linville@tuxdriver.com			of your literate lifestyle.