From: Bob Copeland <me@bobcopeland.com>
To: Elias Oltmanns <eo@nebensachen.de>
Cc: jirislaby@gmail.com, toralf.foerster@gmx.de,
ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
mickflemm@gmail.com, johannes@sipsolutions.net
Subject: Re: [ath5k-devel] Oops with current kernel and ath5k
Date: Wed, 8 Oct 2008 22:15:16 -0400 [thread overview]
Message-ID: <20081009021516.GA14690@hash.localnet> (raw)
In-Reply-To: <87ljx0t9fd.fsf@denkblock.local>
[gmail keeps dropping CCs for some reason]
On Tue, Oct 07, 2008 at 10:52:22PM +0200, Elias Oltmanns wrote:
> Bitops on sc->status have to be protected by the sc->lock as soon as
> ieee80211_register_hw() has been called.
Agreed...
> + mutex_lock(&sc->lock);
> + ath5k_init_leds(sc);
I'd rather leave ath5k_init_leds in attach so it somewhat matches up
with detach, but yeah I suppose it could use locking due to a
probe/start race.
The LED flag is not really a status flag compared to the rest, it just
says whether the hardware supports it or not. Another approach would
be to separate it from the others.
> @@ -2881,12 +2883,14 @@ static void ath5k_configure_filter(struct ieee80211_hw *hw,
> AR5K_RX_FILTER_MCAST);
>
> if (changed_flags & (FIF_PROMISC_IN_BSS | FIF_OTHER_BSS)) {
> + mutex_lock(&sc->lock);
Unfortunately, I don't believe configure_filter can sleep :(
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2008-10-09 2:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200808101401.03339.toralf.foerster@gmx.de>
[not found] ` <b6c5339f0808101124x6f9359dct9ad828db1e6d1b2c@mail.gmail.com>
2008-10-01 18:55 ` Oops with current kernel and ath5k Toralf Förster
2008-10-01 21:10 ` Elias Oltmanns
2008-10-01 22:15 ` [ath5k-devel] " Bob Copeland
2008-10-01 22:34 ` Elias Oltmanns
2008-10-02 2:04 ` Bob Copeland
2008-10-02 7:53 ` Elias Oltmanns
2008-10-02 9:24 ` Johannes Berg
2008-10-02 12:52 ` Bob Copeland
2008-10-02 15:02 ` Bob Copeland
2008-10-02 16:31 ` Elias Oltmanns
2008-10-02 18:37 ` Bob Copeland
2008-10-03 14:13 ` Bob Copeland
2008-10-03 14:42 ` Elias Oltmanns
2008-10-03 19:43 ` Bob Copeland
2008-10-05 12:45 ` Elias Oltmanns
2008-10-06 14:12 ` Bob Copeland
2008-10-06 14:23 ` Johannes Berg
2008-10-06 14:36 ` Bob Copeland
2008-10-09 10:40 ` Johannes Berg
2008-10-07 1:35 ` Bob Copeland
2008-10-07 10:44 ` Elias Oltmanns
2008-10-07 12:19 ` Bob Copeland
2008-10-07 12:57 ` Bob Copeland
2008-10-07 20:48 ` Elias Oltmanns
2008-10-07 13:06 ` Bob Copeland
2008-10-07 20:52 ` Elias Oltmanns
2008-10-09 2:15 ` Bob Copeland [this message]
2008-10-11 20:30 ` Elias Oltmanns
2008-10-02 8:17 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081009021516.GA14690@hash.localnet \
--to=me@bobcopeland.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=eo@nebensachen.de \
--cc=jirislaby@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mickflemm@gmail.com \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).