Re: [PATCH] mac80211: provide sequence numbers

[Ivo van Doorn <ivdoorn@gmail.com>]

On Friday 10 October 2008, Johannes Berg wrote:
> I've come to think that not providing sequence numbers for
> the normal STA mode case was a mistake, at least two drivers
> now had to implement code they wouldn't otherwise need, and
> I believe at76_usb and adm8211 might be broken.
> 
> This patch makes mac80211 assign a sequence number to all
> those frames that need one except beacons. That means that
> if a driver only implements modes that do not do beaconing
> it need not worry about the sequence number.

Very good news. :)

>  	if (!ieee80211_is_data_qos(hdr->frame_control)) {
> +		/* driver should assign sequence number */
>  		info->flags |= IEEE80211_TX_CTL_ASSIGN_SEQ;
> +		/* for pure STA mode without beacons, we can do it */
> +		hdr->seq_ctrl = cpu_to_le16(tx->sdata->sequence_number);
> +		tx->sdata->sequence_number += 0x10;
> +		tx->sdata->sequence_number &= IEEE80211_SCTL_SEQ;
>  		return TX_CONTINUE;
>  	}

Shouldn't this be changed to only setting the IEEE80211_TX_CTL_ASSIGN_SEQ
flag when the sequence counter was _not_ set (with beacons)?

Ivo