[PATCH] ath9k: fix oops on trying to hold the wrong spinlock

[PATCH] ath9k: fix oops on trying to hold the wrong spinlock

[Ingo Molnar]

* Luis R. Rodriguez <lrodriguez@atheros.com> wrote:

> On Fri, Oct 3, 2008 at 3:45 PM, Luis R. Rodriguez
> <lrodriguez@atheros.com> wrote:
> > We were trying to hold the wrong spinlock due to a typo
> > on IEEE80211_BAR_CTL_TID_S's definition. We use this to
> > compute the tid number and then hold this this tid number's
> > spinlock.
> >
> > Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
> > Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>
> > Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> 
> Just a head up John -- Ingo has already sucked this into his tree with 
> a proper Reported-by. We still need it in wireless-testing though, not 
> sure how that will be handled.

Small sidenote: in terms of upstream merging tip/out-of-tree is a 
dead-end (as its name implies) - it's a special temporary throw-away 
branch for hot fixes that fall outside the normal scope of -tip. We 
periodically rebase tip/out-of-tree against -git and throw away patches 
that go upstream via other routes. It's never merged directly to Linus. 
Perhaps we should rename it tip/not-for-linus ?

So we are glad to test out patches, but John please apply the patch 
below to the wireless tree so that it's not lost. (probably for 
v2.6.27.1) We are just helping out with testing and we do not want to 
interfere in any way with the wireless git workflow.

	Ingo

------------------>
>From fff3ddac71cf05dda8501a3449c167340e46b755 Mon Sep 17 00:00:00 2001
From: Luis R. Rodriguez <lrodriguez@atheros.com>
Date: Fri, 3 Oct 2008 04:49:21 -0700
Subject: [PATCH] ath9k: fix oops on trying to hold the wrong spinlock

Steven Noonan reported a crash that occurs during ath9k module load.

We were trying to hold the wrong spinlock due to a typo
on IEEE80211_BAR_CTL_TID_S's definition. We use this to
compute the tid number and then hold this this tid number's
spinlock during ath_bar_rx().

Reported-by: Steven Noonan <steven@uplinklabs.net>
Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Tested-by: Steven Noonan <steven@uplinklabs.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/net/wireless/ath9k/core.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath9k/core.h b/drivers/net/wireless/ath9k/core.h
index 2f84093..88f4cc3 100644
--- a/drivers/net/wireless/ath9k/core.h
+++ b/drivers/net/wireless/ath9k/core.h
@@ -316,7 +316,7 @@ void ath_descdma_cleanup(struct ath_softc *sc,
 #define ATH_RX_TIMEOUT           40      /* 40 milliseconds */
 #define WME_NUM_TID              16
 #define IEEE80211_BAR_CTL_TID_M  0xF000  /* tid mask */
-#define IEEE80211_BAR_CTL_TID_S  2       /* tid shift */
+#define IEEE80211_BAR_CTL_TID_S  12      /* tid shift */
 
 enum ATH_RX_TYPE {
 	ATH_RX_NON_CONSUMED = 0,

[PATCH] ath9k: fix oops on trying to hold the wrong spinlock

[Luis R. Rodriguez]

This fixes on oops when you get try to send a BA to an 11n AP.
The oops occurred because we were trying to aquire an incorrect
spinlock.

We were trying to hold the wrong spinlock due to a typo
on IEEE80211_BAR_CTL_TID_S's definition. We use this to
compute the tid number and then hold this this tid number's
spinlock.

Tested-by: Steven Noonan <steven@uplinklabs.net>
Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---

I don't see this queue'd yet for 2.6.27.2

 drivers/net/wireless/ath9k/core.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath9k/core.h b/drivers/net/wireless/ath9k/core.h
index 80814c9..5b4f1c4 100644
--- a/drivers/net/wireless/ath9k/core.h
+++ b/drivers/net/wireless/ath9k/core.h
@@ -309,7 +309,7 @@ void ath_descdma_cleanup(struct ath_softc *sc,
 #define ATH_RX_TIMEOUT           40      /* 40 milliseconds */
 #define WME_NUM_TID              16
 #define IEEE80211_BAR_CTL_TID_M  0xF000  /* tid mask */
-#define IEEE80211_BAR_CTL_TID_S  2       /* tid shift */
+#define IEEE80211_BAR_CTL_TID_S  12      /* tid shift */
 
 enum ATH_RX_TYPE {
 	ATH_RX_NON_CONSUMED = 0,
-- 
1.5.6.rc2.15.g457bb.dirty

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [stable] [PATCH] ath9k: fix oops on trying to hold the wrong spinlock

[Greg KH]

On Thu, Oct 16, 2008 at 04:12:55AM -0700, Luis R. Rodriguez wrote:
> This fixes on oops when you get try to send a BA to an 11n AP.
> The oops occurred because we were trying to aquire an incorrect
> spinlock.
> 
> We were trying to hold the wrong spinlock due to a typo
> on IEEE80211_BAR_CTL_TID_S's definition. We use this to
> compute the tid number and then hold this this tid number's
> spinlock.
> 
> Tested-by: Steven Noonan <steven@uplinklabs.net>
> Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
> Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> 
> I don't see this queue'd yet for 2.6.27.2

Is it in Linus's tree?  If so, do you have a git commit id?

thanks,

greg k-h

Re: [stable] [PATCH] ath9k: fix oops on trying to hold the wrong spinlock

[Luis R. Rodriguez]

On Thu, Oct 16, 2008 at 2:54 PM, Greg KH <greg@kroah.com> wrote:
> On Thu, Oct 16, 2008 at 04:12:55AM -0700, Luis R. Rodriguez wrote:
>> This fixes on oops when you get try to send a BA to an 11n AP.
>> The oops occurred because we were trying to aquire an incorrect
>> spinlock.
>>
>> We were trying to hold the wrong spinlock due to a typo
>> on IEEE80211_BAR_CTL_TID_S's definition. We use this to
>> compute the tid number and then hold this this tid number's
>> spinlock.
>>
>> Tested-by: Steven Noonan <steven@uplinklabs.net>
>> Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
>> Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>
>> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
>> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>> ---
>>
>> I don't see this queue'd yet for 2.6.27.2
>
> Is it in Linus's tree?  If so, do you have a git commit id?

Got it.

a477e4e6d48d3ac7c7a75bad40585cb391e5c237

If you can add the Reported-by tag it'd be great, I missed it on Linus' tree.

Thanks,

  Luis

Re: [stable] [PATCH] ath9k: fix oops on trying to hold the wrong spinlock

[Greg KH]

On Thu, Oct 16, 2008 at 04:12:02PM -0700, Luis R. Rodriguez wrote:
> On Thu, Oct 16, 2008 at 2:54 PM, Greg KH <greg@kroah.com> wrote:
> > On Thu, Oct 16, 2008 at 04:12:55AM -0700, Luis R. Rodriguez wrote:
> >> This fixes on oops when you get try to send a BA to an 11n AP.
> >> The oops occurred because we were trying to aquire an incorrect
> >> spinlock.
> >>
> >> We were trying to hold the wrong spinlock due to a typo
> >> on IEEE80211_BAR_CTL_TID_S's definition. We use this to
> >> compute the tid number and then hold this this tid number's
> >> spinlock.
> >>
> >> Tested-by: Steven Noonan <steven@uplinklabs.net>
> >> Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
> >> Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>
> >> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> >> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> >> ---
> >>
> >> I don't see this queue'd yet for 2.6.27.2
> >
> > Is it in Linus's tree?  If so, do you have a git commit id?
> 
> Got it.
> 
> a477e4e6d48d3ac7c7a75bad40585cb391e5c237
> 
> If you can add the Reported-by tag it'd be great, I missed it on Linus' tree.

You mean the "tested-by" flag?  I've added that, I don't see a
reported-by flag above.

thanks,

greg k-h

Re: [stable] [PATCH] ath9k: fix oops on trying to hold the wrong spinlock

[Luis R. Rodriguez]

On Thu, Oct 16, 2008 at 4:28 PM, Greg KH <greg@kroah.com> wrote:
> On Thu, Oct 16, 2008 at 04:12:02PM -0700, Luis R. Rodriguez wrote:
>> On Thu, Oct 16, 2008 at 2:54 PM, Greg KH <greg@kroah.com> wrote:
>> > On Thu, Oct 16, 2008 at 04:12:55AM -0700, Luis R. Rodriguez wrote:
>> >> This fixes on oops when you get try to send a BA to an 11n AP.
>> >> The oops occurred because we were trying to aquire an incorrect
>> >> spinlock.
>> >>
>> >> We were trying to hold the wrong spinlock due to a typo
>> >> on IEEE80211_BAR_CTL_TID_S's definition. We use this to
>> >> compute the tid number and then hold this this tid number's
>> >> spinlock.
>> >>
>> >> Tested-by: Steven Noonan <steven@uplinklabs.net>
>> >> Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
>> >> Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>
>> >> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
>> >> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>> >> ---
>> >>
>> >> I don't see this queue'd yet for 2.6.27.2
>> >
>> > Is it in Linus's tree?  If so, do you have a git commit id?
>>
>> Got it.
>>
>> a477e4e6d48d3ac7c7a75bad40585cb391e5c237
>>
>> If you can add the Reported-by tag it'd be great, I missed it on Linus' tree.
>
> You mean the "tested-by" flag?  I've added that, I don't see a
> reported-by flag above.

Yeap, tested.

  Luis