linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
	John Linville <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] wireless: remove struct regdom hinting
Date: Wed, 22 Oct 2008 05:41:39 -0700	[thread overview]
Message-ID: <20081022124139.GK6190@tesla> (raw)
In-Reply-To: <1224703869.30459.63.camel@johannes.berg>

On Wed, Oct 22, 2008 at 12:31:09PM -0700, Johannes Berg wrote:
> On Wed, 2008-10-22 at 05:29 -0700, Luis R. Rodriguez wrote:
> > On Wed, Oct 22, 2008 at 11:51:36AM -0700, Johannes Berg wrote:
> > > -/* wiphy is set if this request's initiator is REGDOM_SET_BY_DRIVER */
> > > +/* wiphy is set if this request's initiator is REGDOM_SET_BY_COUNTRY_IE */
> > 
> > Why don't we want to keep track of the wiphy if the driver set it?
> 
> Why would we? I removed it from the hinting functions so that we don't
> need to have a valid wiphy to call a hint, which seems quite possible?

Well, the alpha2 hint from country IE we'd built it from the IE
and then try call an rd hint routine, I take it now it would be the new
struct one. OK -- in that one we have the wiphy. In that case that
routine needs to be updated to check to see if the initiator is
country IE and if so mark XXX do to intersection.

Then the reason I kept the wiphy around for the regular alpha2 case is
you will want to keep track if a different wiphy sent this new alpha2
request. If so I think we do interesection then, or let the user disable
one or something.

But yea its useful to keep track of I think. I thought you didn't remove
it from ignore_request(), hm.. that's where we use it to do all these
checks.

  Luis

  reply	other threads:[~2008-10-22 19:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-21 10:30 [PATCH] wireless: remove struct regdom hinting Johannes Berg
2008-10-22 11:39 ` Luis R. Rodriguez
2008-10-22 18:51   ` [PATCH v2] " Johannes Berg
2008-10-22 12:29     ` Luis R. Rodriguez
2008-10-22 19:31       ` Johannes Berg
2008-10-22 12:41         ` Luis R. Rodriguez [this message]
2008-10-22 19:43           ` Johannes Berg
2008-10-22 14:36             ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081022124139.GK6190@tesla \
    --to=lrodriguez@atheros.com \
    --cc=Luis.Rodriguez@Atheros.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).