From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
John Linville <linville@tuxdriver.com>,
"Luis R. Rodriguez" <mcgrof@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wireless: update regulatory sample code
Date: Wed, 22 Oct 2008 07:40:56 -0700 [thread overview]
Message-ID: <20081022144056.GM6190@tesla> (raw)
In-Reply-To: <1224704488.30459.69.camel@johannes.berg>
On Wed, Oct 22, 2008 at 12:41:28PM -0700, Johannes Berg wrote:
> On Wed, 2008-10-22 at 05:35 -0700, Luis R. Rodriguez wrote:
> > On Wed, Oct 22, 2008 at 11:55:52AM -0700, Johannes Berg wrote:
> > > Update the same code for the recent changes. I did this as a
> > > separate patch to avoid removing a lot of sample code only
> > > to add it back again in the next patch.
> > >
> > > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> > > ---
> > > Documentation/networking/regulatory.txt | 19 ++++++++-----------
> > > 1 file changed, 8 insertions(+), 11 deletions(-)
> > >
> > > --- everything.orig/Documentation/networking/regulatory.txt 2008-10-22 20:51:50.000000000 +0200
> > > +++ everything/Documentation/networking/regulatory.txt 2008-10-22 20:54:12.000000000 +0200
> > > @@ -131,7 +131,7 @@ are expected to do this during initializ
> > >
> > > r = zd_reg2alpha2(mac->regdomain, alpha2);
> > > if (!r)
> > > - regulatory_hint(hw->wiphy, alpha2, NULL);
> > > + regulatory_hint(alpha2);
> > >
> > > Example code - drivers providing a built in regulatory domain:
> >
> > Should we mention how currently this should be avoided unless
> > your regulatory definition is also intersected with hw capabilities
> > and that the same channels are the ones that are registered to cfg80211?
Well rd hint for when we provide a structure, that code right now
disregards when initiator == USER, and this works well only for
when the driver sending the rd struct hint also only registered
to cfg80211 the channels its legally capable of. If a driver
which does not use reg_notifier() and registers *all* of its channels
uses this then the USER set regdom will be used and *all* channels
will be left intact.
Luis
next prev parent reply other threads:[~2008-10-22 21:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 18:55 [PATCH] wireless: update regulatory sample code Johannes Berg
2008-10-22 12:35 ` Luis R. Rodriguez
2008-10-22 19:41 ` Johannes Berg
2008-10-22 14:40 ` Luis R. Rodriguez [this message]
2008-10-23 6:24 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022144056.GM6190@tesla \
--to=lrodriguez@atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox