* New iwlwifi 3945 uCode available @ 2008-10-21 18:27 reinette chatre 2008-10-21 21:25 ` Johannes Berg 0 siblings, 1 reply; 36+ messages in thread From: reinette chatre @ 2008-10-21 18:27 UTC (permalink / raw) To: ipw3945-devel, linux-wireless Two new versions of 3945 uCode is now available for download from http://intellinuxwireless.org/?n=Downloads. Two versions are available as we have updated the API version of the uCode and included pending fixes in both API versions. Version 15.28.1.8 supports API v1 and can be used with most current 3945 drivers. Version 15.28.2.8 (API v2) is required when you start using the latest 3945 driver from wireless-testing at the time it includes the patch "iwl3945 : Fix a-band association for passive channels". Changes: Version 15.28.1.8 - Allow full active dwell time after scan auto-switches from passive to active scan - Allow direct probes on passive-scan channels (after auto-switch) - Expand coverage in Event Log Version 15.28.2.8 - Allow full active dwell time after scan auto-switches from passive to active scan - Allow direct probes on passive-scan channels (after auto-switch) - Expand coverage in Event Log Reinette ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-21 18:27 New iwlwifi 3945 uCode available reinette chatre @ 2008-10-21 21:25 ` Johannes Berg 2008-10-21 21:33 ` Tomas Winkler 0 siblings, 1 reply; 36+ messages in thread From: Johannes Berg @ 2008-10-21 21:25 UTC (permalink / raw) To: reinette chatre; +Cc: linux-wireless [-- Attachment #1: Type: text/plain, Size: 737 bytes --] On Tue, 2008-10-21 at 11:27 -0700, reinette chatre wrote: > Two new versions of 3945 uCode is now available for download from > http://intellinuxwireless.org/?n=Downloads. Two versions are available > as we have updated the API version of the uCode and included pending > fixes in both API versions. > > Version 15.28.1.8 supports API v1 and can be used with most current 3945 > drivers. Version 15.28.2.8 (API v2) is required when you start using the > latest 3945 driver from wireless-testing at the time it includes the > patch "iwl3945 : Fix a-band association for passive channels". Can you make the driver work with the old ucode? We even do that for drivers where we don't control the ucode like b43... johannes [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-21 21:25 ` Johannes Berg @ 2008-10-21 21:33 ` Tomas Winkler 2008-10-21 21:34 ` Johannes Berg 0 siblings, 1 reply; 36+ messages in thread From: Tomas Winkler @ 2008-10-21 21:33 UTC (permalink / raw) To: Johannes Berg; +Cc: reinette chatre, linux-wireless On Tue, Oct 21, 2008 at 11:25 PM, Johannes Berg <johannes@sipsolutions.net> wrote: > On Tue, 2008-10-21 at 11:27 -0700, reinette chatre wrote: >> Two new versions of 3945 uCode is now available for download from >> http://intellinuxwireless.org/?n=Downloads. Two versions are available >> as we have updated the API version of the uCode and included pending >> fixes in both API versions. >> >> Version 15.28.1.8 supports API v1 and can be used with most current 3945 >> drivers. Version 15.28.2.8 (API v2) is required when you start using the >> latest 3945 driver from wireless-testing at the time it includes the >> patch "iwl3945 : Fix a-band association for passive channels". > > Can you make the driver work with the old ucode? We even do that for > drivers where we don't control the ucode like b43... What for? Tomas ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-21 21:33 ` Tomas Winkler @ 2008-10-21 21:34 ` Johannes Berg 2008-10-21 21:38 ` John W. Linville 2008-10-21 21:59 ` reinette chatre 0 siblings, 2 replies; 36+ messages in thread From: Johannes Berg @ 2008-10-21 21:34 UTC (permalink / raw) To: Tomas Winkler; +Cc: reinette chatre, linux-wireless [-- Attachment #1: Type: text/plain, Size: 1165 bytes --] On Tue, 2008-10-21 at 23:33 +0200, Tomas Winkler wrote: > On Tue, Oct 21, 2008 at 11:25 PM, Johannes Berg > <johannes@sipsolutions.net> wrote: > > On Tue, 2008-10-21 at 11:27 -0700, reinette chatre wrote: > >> Two new versions of 3945 uCode is now available for download from > >> http://intellinuxwireless.org/?n=Downloads. Two versions are available > >> as we have updated the API version of the uCode and included pending > >> fixes in both API versions. > >> > >> Version 15.28.1.8 supports API v1 and can be used with most current 3945 > >> drivers. Version 15.28.2.8 (API v2) is required when you start using the > >> latest 3945 driver from wireless-testing at the time it includes the > >> patch "iwl3945 : Fix a-band association for passive channels". > > > > Can you make the driver work with the old ucode? We even do that for > > drivers where we don't control the ucode like b43... > > What for? Well, so that installing a new kernel doesn't suddenly break your network connection and ability to download the firmware, for instance. If you want more arguments you can go read all the "b43 sucks" threads about it. johannes [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-21 21:34 ` Johannes Berg @ 2008-10-21 21:38 ` John W. Linville 2008-10-21 21:53 ` Tomas Winkler 2008-10-21 21:59 ` reinette chatre 1 sibling, 1 reply; 36+ messages in thread From: John W. Linville @ 2008-10-21 21:38 UTC (permalink / raw) To: Johannes Berg; +Cc: Tomas Winkler, reinette chatre, linux-wireless On Tue, Oct 21, 2008 at 11:34:59PM +0200, Johannes Berg wrote: > On Tue, 2008-10-21 at 23:33 +0200, Tomas Winkler wrote: > > On Tue, Oct 21, 2008 at 11:25 PM, Johannes Berg > > <johannes@sipsolutions.net> wrote: > > > On Tue, 2008-10-21 at 11:27 -0700, reinette chatre wrote: > > >> Two new versions of 3945 uCode is now available for download from > > >> http://intellinuxwireless.org/?n=Downloads. Two versions are available > > >> as we have updated the API version of the uCode and included pending > > >> fixes in both API versions. > > >> > > >> Version 15.28.1.8 supports API v1 and can be used with most current 3945 > > >> drivers. Version 15.28.2.8 (API v2) is required when you start using the > > >> latest 3945 driver from wireless-testing at the time it includes the > > >> patch "iwl3945 : Fix a-band association for passive channels". > > > > > > Can you make the driver work with the old ucode? We even do that for > > > drivers where we don't control the ucode like b43... > > > > What for? > > Well, so that installing a new kernel doesn't suddenly break your > network connection and ability to download the firmware, for instance. > If you want more arguments you can go read all the "b43 sucks" threads > about it. Johnannes has a point, that is a lot nicer to users... -- John W. Linville Linux should be at the core linville@tuxdriver.com of your literate lifestyle. ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-21 21:38 ` John W. Linville @ 2008-10-21 21:53 ` Tomas Winkler 2008-10-21 22:13 ` Marcel Holtmann 0 siblings, 1 reply; 36+ messages in thread From: Tomas Winkler @ 2008-10-21 21:53 UTC (permalink / raw) To: John W. Linville; +Cc: Johannes Berg, reinette chatre, linux-wireless On Tue, Oct 21, 2008 at 11:38 PM, John W. Linville <linville@tuxdriver.com> wrote: > On Tue, Oct 21, 2008 at 11:34:59PM +0200, Johannes Berg wrote: >> On Tue, 2008-10-21 at 23:33 +0200, Tomas Winkler wrote: >> > On Tue, Oct 21, 2008 at 11:25 PM, Johannes Berg >> > <johannes@sipsolutions.net> wrote: >> > > On Tue, 2008-10-21 at 11:27 -0700, reinette chatre wrote: >> > >> Two new versions of 3945 uCode is now available for download from >> > >> http://intellinuxwireless.org/?n=Downloads. Two versions are available >> > >> as we have updated the API version of the uCode and included pending >> > >> fixes in both API versions. >> > >> >> > >> Version 15.28.1.8 supports API v1 and can be used with most current 3945 >> > >> drivers. Version 15.28.2.8 (API v2) is required when you start using the >> > >> latest 3945 driver from wireless-testing at the time it includes the >> > >> patch "iwl3945 : Fix a-band association for passive channels". >> > > >> > > Can you make the driver work with the old ucode? We even do that for >> > > drivers where we don't control the ucode like b43... >> > >> > What for? >> >> Well, so that installing a new kernel doesn't suddenly break your >> network connection and ability to download the firmware, for instance. >> If you want more arguments you can go read all the "b43 sucks" threads >> about it. > > Johnannes has a point, that is a lot nicer to users... Maybe, but it will complicate the code beyond good taste to just satisfy the single moment when kernel is upgraded. I don't mean in general I mean in this particular case when API changes. Anyhow a good distro shell deal with this in packaging dependencies and normal person will keep old kernel around when compiling new one. Both ucodes can be present on the file system at the same time so I hope the risk is low. Tomas > > -- > John W. Linville Linux should be at the core > linville@tuxdriver.com of your literate lifestyle. > ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-21 21:53 ` Tomas Winkler @ 2008-10-21 22:13 ` Marcel Holtmann 2008-10-21 22:23 ` Tomas Winkler 2008-10-21 22:28 ` reinette chatre 0 siblings, 2 replies; 36+ messages in thread From: Marcel Holtmann @ 2008-10-21 22:13 UTC (permalink / raw) To: Tomas Winkler Cc: John W. Linville, Johannes Berg, reinette chatre, linux-wireless Hi Tomas, > >> > > On Tue, 2008-10-21 at 11:27 -0700, reinette chatre wrote: > >> > >> Two new versions of 3945 uCode is now available for download from > >> > >> http://intellinuxwireless.org/?n=Downloads. Two versions are available > >> > >> as we have updated the API version of the uCode and included pending > >> > >> fixes in both API versions. > >> > >> > >> > >> Version 15.28.1.8 supports API v1 and can be used with most current 3945 > >> > >> drivers. Version 15.28.2.8 (API v2) is required when you start using the > >> > >> latest 3945 driver from wireless-testing at the time it includes the > >> > >> patch "iwl3945 : Fix a-band association for passive channels". > >> > > > >> > > Can you make the driver work with the old ucode? We even do that for > >> > > drivers where we don't control the ucode like b43... > >> > > >> > What for? > >> > >> Well, so that installing a new kernel doesn't suddenly break your > >> network connection and ability to download the firmware, for instance. > >> If you want more arguments you can go read all the "b43 sucks" threads > >> about it. > > > > Johnannes has a point, that is a lot nicer to users... > > Maybe, but it will complicate the code beyond good taste to just > satisfy the single moment when kernel is upgraded. I don't mean in > general I mean in this particular case when API changes. > Anyhow a good distro shell deal with this in packaging dependencies > and normal person will keep old kernel around when compiling new one. > Both ucodes can be present on the file system at the same time so I > hope the risk is low. it is the same argument as for everything else. We should be able to run a new kernel with old userspace. Regards Marcel ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-21 22:13 ` Marcel Holtmann @ 2008-10-21 22:23 ` Tomas Winkler 2008-10-21 23:01 ` Marcel Holtmann 2008-10-21 22:28 ` reinette chatre 1 sibling, 1 reply; 36+ messages in thread From: Tomas Winkler @ 2008-10-21 22:23 UTC (permalink / raw) To: Marcel Holtmann Cc: John W. Linville, Johannes Berg, reinette chatre, linux-wireless On Wed, Oct 22, 2008 at 12:13 AM, Marcel Holtmann <holtmann@linux.intel.com> wrote: > Hi Tomas, > >> >> > > On Tue, 2008-10-21 at 11:27 -0700, reinette chatre wrote: >> >> > >> Two new versions of 3945 uCode is now available for download from >> >> > >> http://intellinuxwireless.org/?n=Downloads. Two versions are available >> >> > >> as we have updated the API version of the uCode and included pending >> >> > >> fixes in both API versions. >> >> > >> >> >> > >> Version 15.28.1.8 supports API v1 and can be used with most current 3945 >> >> > >> drivers. Version 15.28.2.8 (API v2) is required when you start using the >> >> > >> latest 3945 driver from wireless-testing at the time it includes the >> >> > >> patch "iwl3945 : Fix a-band association for passive channels". >> >> > > >> >> > > Can you make the driver work with the old ucode? We even do that for >> >> > > drivers where we don't control the ucode like b43... >> >> > >> >> > What for? >> >> >> >> Well, so that installing a new kernel doesn't suddenly break your >> >> network connection and ability to download the firmware, for instance. >> >> If you want more arguments you can go read all the "b43 sucks" threads >> >> about it. >> > >> > Johnannes has a point, that is a lot nicer to users... >> >> Maybe, but it will complicate the code beyond good taste to just >> satisfy the single moment when kernel is upgraded. I don't mean in >> general I mean in this particular case when API changes. >> Anyhow a good distro shell deal with this in packaging dependencies >> and normal person will keep old kernel around when compiling new one. >> Both ucodes can be present on the file system at the same time so I >> hope the risk is low. > > it is the same argument as for everything else. We should be able to run > a new kernel with old userspace. Yet this is not user space, if there won't be a little :) license issue this will integral part of the driver. Tomas ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-21 22:23 ` Tomas Winkler @ 2008-10-21 23:01 ` Marcel Holtmann 2008-10-21 23:09 ` Luis R. Rodriguez 0 siblings, 1 reply; 36+ messages in thread From: Marcel Holtmann @ 2008-10-21 23:01 UTC (permalink / raw) To: Tomas Winkler Cc: John W. Linville, Johannes Berg, reinette chatre, linux-wireless Hi Tomas, > >> >> > > On Tue, 2008-10-21 at 11:27 -0700, reinette chatre wrote: > >> >> > >> Two new versions of 3945 uCode is now available for download from > >> >> > >> http://intellinuxwireless.org/?n=Downloads. Two versions are available > >> >> > >> as we have updated the API version of the uCode and included pending > >> >> > >> fixes in both API versions. > >> >> > >> > >> >> > >> Version 15.28.1.8 supports API v1 and can be used with most current 3945 > >> >> > >> drivers. Version 15.28.2.8 (API v2) is required when you start using the > >> >> > >> latest 3945 driver from wireless-testing at the time it includes the > >> >> > >> patch "iwl3945 : Fix a-band association for passive channels". > >> >> > > > >> >> > > Can you make the driver work with the old ucode? We even do that for > >> >> > > drivers where we don't control the ucode like b43... > >> >> > > >> >> > What for? > >> >> > >> >> Well, so that installing a new kernel doesn't suddenly break your > >> >> network connection and ability to download the firmware, for instance. > >> >> If you want more arguments you can go read all the "b43 sucks" threads > >> >> about it. > >> > > >> > Johnannes has a point, that is a lot nicer to users... > >> > >> Maybe, but it will complicate the code beyond good taste to just > >> satisfy the single moment when kernel is upgraded. I don't mean in > >> general I mean in this particular case when API changes. > >> Anyhow a good distro shell deal with this in packaging dependencies > >> and normal person will keep old kernel around when compiling new one. > >> Both ucodes can be present on the file system at the same time so I > >> hope the risk is low. > > > > it is the same argument as for everything else. We should be able to run > > a new kernel with old userspace. > > Yet this is not user space, if there won't be a little :) license > issue this will integral part of the driver. as long as the firmware is a file on the filesystem, it is the old userspace. It is simpler to update a firmware file (in this case installing a new one) then installing additional software, but that doesn't change anything. Our current problem is that our firmware is still not part of the firmware tree David Woodhouse is maintaining. Then we could link it together with the kernel tree. And yes, that is license issue, but it is one that can be solved. Regards Marcel ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-21 23:01 ` Marcel Holtmann @ 2008-10-21 23:09 ` Luis R. Rodriguez 2008-10-21 23:11 ` Marcel Holtmann 0 siblings, 1 reply; 36+ messages in thread From: Luis R. Rodriguez @ 2008-10-21 23:09 UTC (permalink / raw) To: Marcel Holtmann Cc: Tomas Winkler, John W. Linville, Johannes Berg, reinette chatre, linux-wireless On Tue, Oct 21, 2008 at 4:01 PM, Marcel Holtmann <holtmann@linux.intel.com> wrote: > as long as the firmware is a file on the filesystem, it is the old > userspace. It is simpler to update a firmware file (in this case > installing a new one) then installing additional software, but that > doesn't change anything. > > Our current problem is that our firmware is still not part of the > firmware tree David Woodhouse is maintaining. Then we could link it > together with the kernel tree. And yes, that is license issue, but it is > one that can be solved. What license issue BTW? ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-21 23:09 ` Luis R. Rodriguez @ 2008-10-21 23:11 ` Marcel Holtmann 2008-10-21 23:27 ` Luis R. Rodriguez 0 siblings, 1 reply; 36+ messages in thread From: Marcel Holtmann @ 2008-10-21 23:11 UTC (permalink / raw) To: Luis R. Rodriguez Cc: Tomas Winkler, John W. Linville, Johannes Berg, reinette chatre, linux-wireless Hi Luis, > > as long as the firmware is a file on the filesystem, it is the old > > userspace. It is simpler to update a firmware file (in this case > > installing a new one) then installing additional software, but that > > doesn't change anything. > > > > Our current problem is that our firmware is still not part of the > > firmware tree David Woodhouse is maintaining. Then we could link it > > together with the kernel tree. And yes, that is license issue, but it is > > one that can be solved. > > What license issue BTW? about putting our ucode into the linux-firmware.git tree? Regards Marcel ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-21 23:11 ` Marcel Holtmann @ 2008-10-21 23:27 ` Luis R. Rodriguez 2008-10-21 23:31 ` Marcel Holtmann 0 siblings, 1 reply; 36+ messages in thread From: Luis R. Rodriguez @ 2008-10-21 23:27 UTC (permalink / raw) To: Marcel Holtmann Cc: Tomas Winkler, John W. Linville, Johannes Berg, reinette chatre, linux-wireless On Tue, Oct 21, 2008 at 4:11 PM, Marcel Holtmann <holtmann@linux.intel.com> wrote: > Hi Luis, > >> > as long as the firmware is a file on the filesystem, it is the old >> > userspace. It is simpler to update a firmware file (in this case >> > installing a new one) then installing additional software, but that >> > doesn't change anything. >> > >> > Our current problem is that our firmware is still not part of the >> > firmware tree David Woodhouse is maintaining. Then we could link it >> > together with the kernel tree. And yes, that is license issue, but it is >> > one that can be solved. >> >> What license issue BTW? > > about putting our ucode into the linux-firmware.git tree? Yeah, what's wrong with the license used right now? Luis ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-21 23:27 ` Luis R. Rodriguez @ 2008-10-21 23:31 ` Marcel Holtmann 2008-10-21 23:34 ` Luis R. Rodriguez 0 siblings, 1 reply; 36+ messages in thread From: Marcel Holtmann @ 2008-10-21 23:31 UTC (permalink / raw) To: Luis R. Rodriguez Cc: Tomas Winkler, John W. Linville, Johannes Berg, reinette chatre, linux-wireless Hi Luis, > >> > as long as the firmware is a file on the filesystem, it is the old > >> > userspace. It is simpler to update a firmware file (in this case > >> > installing a new one) then installing additional software, but that > >> > doesn't change anything. > >> > > >> > Our current problem is that our firmware is still not part of the > >> > firmware tree David Woodhouse is maintaining. Then we could link it > >> > together with the kernel tree. And yes, that is license issue, but it is > >> > one that can be solved. > >> > >> What license issue BTW? > > > > about putting our ucode into the linux-firmware.git tree? > > Yeah, what's wrong with the license used right now? this is not my authority, but as far as I understand it, it is fine, but someone inside Intel actually has to give green lights for it. And that is neither David or me. Regards Marcel ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-21 23:31 ` Marcel Holtmann @ 2008-10-21 23:34 ` Luis R. Rodriguez 0 siblings, 0 replies; 36+ messages in thread From: Luis R. Rodriguez @ 2008-10-21 23:34 UTC (permalink / raw) To: Marcel Holtmann Cc: Tomas Winkler, John W. Linville, Johannes Berg, reinette chatre, linux-wireless On Tue, Oct 21, 2008 at 4:31 PM, Marcel Holtmann <holtmann@linux.intel.com> wrote: > Hi Luis, > >> >> > as long as the firmware is a file on the filesystem, it is the old >> >> > userspace. It is simpler to update a firmware file (in this case >> >> > installing a new one) then installing additional software, but that >> >> > doesn't change anything. >> >> > >> >> > Our current problem is that our firmware is still not part of the >> >> > firmware tree David Woodhouse is maintaining. Then we could link it >> >> > together with the kernel tree. And yes, that is license issue, but it is >> >> > one that can be solved. >> >> >> >> What license issue BTW? >> > >> > about putting our ucode into the linux-firmware.git tree? >> >> Yeah, what's wrong with the license used right now? > > this is not my authority, but as far as I understand it, it is fine, but > someone inside Intel actually has to give green lights for it. And that > is neither David or me. Ah ok :) thanks for the clarification, red tape then. Luis ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-21 22:13 ` Marcel Holtmann 2008-10-21 22:23 ` Tomas Winkler @ 2008-10-21 22:28 ` reinette chatre 2008-10-21 23:06 ` Marcel Holtmann ` (2 more replies) 1 sibling, 3 replies; 36+ messages in thread From: reinette chatre @ 2008-10-21 22:28 UTC (permalink / raw) To: Marcel Holtmann Cc: Tomas Winkler, John W. Linville, Johannes Berg, linux-wireless@vger.kernel.org On Tue, 2008-10-21 at 15:13 -0700, Marcel Holtmann wrote: > Hi Tomas, > > > >> > > On Tue, 2008-10-21 at 11:27 -0700, reinette chatre wrote: > > >> > >> Two new versions of 3945 uCode is now available for download from > > >> > >> http://intellinuxwireless.org/?n=Downloads. Two versions are available > > >> > >> as we have updated the API version of the uCode and included pending > > >> > >> fixes in both API versions. > > >> > >> > > >> > >> Version 15.28.1.8 supports API v1 and can be used with most current 3945 > > >> > >> drivers. Version 15.28.2.8 (API v2) is required when you start using the > > >> > >> latest 3945 driver from wireless-testing at the time it includes the > > >> > >> patch "iwl3945 : Fix a-band association for passive channels". > > >> > > > > >> > > Can you make the driver work with the old ucode? We even do that for > > >> > > drivers where we don't control the ucode like b43... > > >> > > > >> > What for? > > >> > > >> Well, so that installing a new kernel doesn't suddenly break your > > >> network connection and ability to download the firmware, for instance. > > >> If you want more arguments you can go read all the "b43 sucks" threads > > >> about it. > > > > > > Johnannes has a point, that is a lot nicer to users... > > > > Maybe, but it will complicate the code beyond good taste to just > > satisfy the single moment when kernel is upgraded. I don't mean in > > general I mean in this particular case when API changes. > > Anyhow a good distro shell deal with this in packaging dependencies > > and normal person will keep old kernel around when compiling new one. > > Both ucodes can be present on the file system at the same time so I > > hope the risk is low. > > it is the same argument as for everything else. We should be able to run > a new kernel with old userspace. I do not believe our request is unreasonable. If a user runs a new kernel the log will print a message that the firmware is incorrect ... all the user needs to do is go to http://intellinuxwireless.org/?n=Downloads and download the latest firmware. This does not require any subtle changes that may affect other aspects of the system ... just the firmware file that is only used by the driver. We are focused on upstream development. If there is a need to support older ucode then we face a similar challenge as was solved through the compat-wireless project for the driver self. Reinette ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-21 22:28 ` reinette chatre @ 2008-10-21 23:06 ` Marcel Holtmann 2008-10-21 23:34 ` Tomas Winkler 2008-10-22 7:27 ` Johannes Berg 2008-10-22 10:07 ` Christoph Hellwig 2 siblings, 1 reply; 36+ messages in thread From: Marcel Holtmann @ 2008-10-21 23:06 UTC (permalink / raw) To: reinette chatre Cc: Tomas Winkler, John W. Linville, Johannes Berg, linux-wireless@vger.kernel.org Hi Reinette, > > > >> > >> Two new versions of 3945 uCode is now available for download from > > > >> > >> http://intellinuxwireless.org/?n=Downloads. Two versions are available > > > >> > >> as we have updated the API version of the uCode and included pending > > > >> > >> fixes in both API versions. > > > >> > >> > > > >> > >> Version 15.28.1.8 supports API v1 and can be used with most current 3945 > > > >> > >> drivers. Version 15.28.2.8 (API v2) is required when you start using the > > > >> > >> latest 3945 driver from wireless-testing at the time it includes the > > > >> > >> patch "iwl3945 : Fix a-band association for passive channels". > > > >> > > > > > >> > > Can you make the driver work with the old ucode? We even do that for > > > >> > > drivers where we don't control the ucode like b43... > > > >> > > > > >> > What for? > > > >> > > > >> Well, so that installing a new kernel doesn't suddenly break your > > > >> network connection and ability to download the firmware, for instance. > > > >> If you want more arguments you can go read all the "b43 sucks" threads > > > >> about it. > > > > > > > > Johnannes has a point, that is a lot nicer to users... > > > > > > Maybe, but it will complicate the code beyond good taste to just > > > satisfy the single moment when kernel is upgraded. I don't mean in > > > general I mean in this particular case when API changes. > > > Anyhow a good distro shell deal with this in packaging dependencies > > > and normal person will keep old kernel around when compiling new one. > > > Both ucodes can be present on the file system at the same time so I > > > hope the risk is low. > > > > it is the same argument as for everything else. We should be able to run > > a new kernel with old userspace. > > I do not believe our request is unreasonable. If a user runs a new > kernel the log will print a message that the firmware is incorrect ... > all the user needs to do is go to > http://intellinuxwireless.org/?n=Downloads and download the latest > firmware. This does not require any subtle changes that may affect other > aspects of the system ... just the firmware file that is only used by > the driver. > > We are focused on upstream development. If there is a need to support > older ucode then we face a similar challenge as was solved through the > compat-wireless project for the driver self. I haven't checked this particular case, but in some cases it is simple to keep backward compatible code around that would let us support the old firmware for a few releases. In other cases the driver and firmware interface might have evolved too much to do so. In these cases we might wanna keep the old drivers around so users can have a choice. We do have something like drivers/staging/ now. It might make sense to have introduce drivers/deprecated/ for old drivers that we just keep around for a few releases to ease a transition. Just thinking out loud. And I have been bitten by ucode API changes in the past. It is just not clear when actually compiling the new kernel. We could also have compile time checks that check the new firmware file is actually present at the compile time of the new kernel. The driver should have a MODULE_FIRMWARE tag and we could process it and match it to /lib/firmware. Regards Marcel ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-21 23:06 ` Marcel Holtmann @ 2008-10-21 23:34 ` Tomas Winkler 2008-10-22 1:03 ` Marcel Holtmann 0 siblings, 1 reply; 36+ messages in thread From: Tomas Winkler @ 2008-10-21 23:34 UTC (permalink / raw) To: Marcel Holtmann Cc: reinette chatre, John W. Linville, Johannes Berg, linux-wireless@vger.kernel.org On Wed, Oct 22, 2008 at 1:06 AM, Marcel Holtmann <holtmann@linux.intel.com> wrote: > Hi Reinette, > >> > > >> > >> Two new versions of 3945 uCode is now available for download from >> > > >> > >> http://intellinuxwireless.org/?n=Downloads. Two versions are available >> > > >> > >> as we have updated the API version of the uCode and included pending >> > > >> > >> fixes in both API versions. >> > > >> > >> >> > > >> > >> Version 15.28.1.8 supports API v1 and can be used with most current 3945 >> > > >> > >> drivers. Version 15.28.2.8 (API v2) is required when you start using the >> > > >> > >> latest 3945 driver from wireless-testing at the time it includes the >> > > >> > >> patch "iwl3945 : Fix a-band association for passive channels". >> > > >> > > >> > > >> > > Can you make the driver work with the old ucode? We even do that for >> > > >> > > drivers where we don't control the ucode like b43... >> > > >> > >> > > >> > What for? >> > > >> >> > > >> Well, so that installing a new kernel doesn't suddenly break your >> > > >> network connection and ability to download the firmware, for instance. >> > > >> If you want more arguments you can go read all the "b43 sucks" threads >> > > >> about it. >> > > > >> > > > Johnannes has a point, that is a lot nicer to users... >> > > >> > > Maybe, but it will complicate the code beyond good taste to just >> > > satisfy the single moment when kernel is upgraded. I don't mean in >> > > general I mean in this particular case when API changes. >> > > Anyhow a good distro shell deal with this in packaging dependencies >> > > and normal person will keep old kernel around when compiling new one. >> > > Both ucodes can be present on the file system at the same time so I >> > > hope the risk is low. >> > >> > it is the same argument as for everything else. We should be able to run >> > a new kernel with old userspace. >> >> I do not believe our request is unreasonable. If a user runs a new >> kernel the log will print a message that the firmware is incorrect ... >> all the user needs to do is go to >> http://intellinuxwireless.org/?n=Downloads and download the latest >> firmware. This does not require any subtle changes that may affect other >> aspects of the system ... just the firmware file that is only used by >> the driver. >> >> We are focused on upstream development. If there is a need to support >> older ucode then we face a similar challenge as was solved through the >> compat-wireless project for the driver self. > > I haven't checked this particular case, but in some cases it is simple > to keep backward compatible code around that would let us support the > old firmware for a few releases. In other cases the driver and firmware > interface might have evolved too much to do so. In these cases we might > wanna keep the old drivers around so users can have a choice. If it wasn't so awkward in this case I wouldn't mind to support old firmware. Second when we touch firmware especially for old HW it means that it solves a bug so why ones would use old driver for something else then to download the new firmware. > We do have something like drivers/staging/ now. It might make sense to > have introduce drivers/deprecated/ for old drivers that we just keep > around for a few releases to ease a transition. Just thinking out loud. Sounds like good idea... need some configuration tricks tough unlike staging here we have 2 drivers for the same hw > And I have been bitten by ucode API changes in the past. It is just not > clear when actually compiling the new kernel. We could also have compile > time checks that check the new firmware file is actually present at the > compile time of the new kernel. The driver should have a MODULE_FIRMWARE > tag and we could process it and match it to /lib/firmware. It has MODULE_FIRMWARE already Tomas ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-21 23:34 ` Tomas Winkler @ 2008-10-22 1:03 ` Marcel Holtmann 0 siblings, 0 replies; 36+ messages in thread From: Marcel Holtmann @ 2008-10-22 1:03 UTC (permalink / raw) To: Tomas Winkler Cc: reinette chatre, John W. Linville, Johannes Berg, linux-wireless@vger.kernel.org Hi Tomas, > >> > > >> > >> Two new versions of 3945 uCode is now available for download from > >> > > >> > >> http://intellinuxwireless.org/?n=Downloads. Two versions are available > >> > > >> > >> as we have updated the API version of the uCode and included pending > >> > > >> > >> fixes in both API versions. > >> > > >> > >> > >> > > >> > >> Version 15.28.1.8 supports API v1 and can be used with most current 3945 > >> > > >> > >> drivers. Version 15.28.2.8 (API v2) is required when you start using the > >> > > >> > >> latest 3945 driver from wireless-testing at the time it includes the > >> > > >> > >> patch "iwl3945 : Fix a-band association for passive channels". > >> > > >> > > > >> > > >> > > Can you make the driver work with the old ucode? We even do that for > >> > > >> > > drivers where we don't control the ucode like b43... > >> > > >> > > >> > > >> > What for? > >> > > >> > >> > > >> Well, so that installing a new kernel doesn't suddenly break your > >> > > >> network connection and ability to download the firmware, for instance. > >> > > >> If you want more arguments you can go read all the "b43 sucks" threads > >> > > >> about it. > >> > > > > >> > > > Johnannes has a point, that is a lot nicer to users... > >> > > > >> > > Maybe, but it will complicate the code beyond good taste to just > >> > > satisfy the single moment when kernel is upgraded. I don't mean in > >> > > general I mean in this particular case when API changes. > >> > > Anyhow a good distro shell deal with this in packaging dependencies > >> > > and normal person will keep old kernel around when compiling new one. > >> > > Both ucodes can be present on the file system at the same time so I > >> > > hope the risk is low. > >> > > >> > it is the same argument as for everything else. We should be able to run > >> > a new kernel with old userspace. > >> > >> I do not believe our request is unreasonable. If a user runs a new > >> kernel the log will print a message that the firmware is incorrect ... > >> all the user needs to do is go to > >> http://intellinuxwireless.org/?n=Downloads and download the latest > >> firmware. This does not require any subtle changes that may affect other > >> aspects of the system ... just the firmware file that is only used by > >> the driver. > >> > >> We are focused on upstream development. If there is a need to support > >> older ucode then we face a similar challenge as was solved through the > >> compat-wireless project for the driver self. > > > > I haven't checked this particular case, but in some cases it is simple > > to keep backward compatible code around that would let us support the > > old firmware for a few releases. In other cases the driver and firmware > > interface might have evolved too much to do so. In these cases we might > > wanna keep the old drivers around so users can have a choice. > > If it wasn't so awkward in this case I wouldn't mind to support old firmware. > Second when we touch firmware especially for old HW it means that it > solves a bug so why ones would use old driver for something else then > to download the new firmware. if possible, we should try to support old ucode APIs with the latest drivers. In some situations that might be not possible, but we should at least try. > > We do have something like drivers/staging/ now. It might make sense to > > have introduce drivers/deprecated/ for old drivers that we just keep > > around for a few releases to ease a transition. Just thinking out loud. > > Sounds like good idea... need some configuration tricks tough unlike > staging here we have 2 drivers for the same hw That is just some Kconfig magic :) > > And I have been bitten by ucode API changes in the past. It is just not > > clear when actually compiling the new kernel. We could also have compile > > time checks that check the new firmware file is actually present at the > > compile time of the new kernel. The driver should have a MODULE_FIRMWARE > > tag and we could process it and match it to /lib/firmware. > > It has MODULE_FIRMWARE already I know, but we need to actually make better use of this information in a generic post compile step to check that the firmware is actually in place and warn if it is not. Then you can go ahead and download it before actually booting a kernel with a now broken wireless card. This is not even Intel or wireless specific. We should do this for all kinds of drivers. Regards Marcel ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-21 22:28 ` reinette chatre 2008-10-21 23:06 ` Marcel Holtmann @ 2008-10-22 7:27 ` Johannes Berg 2008-10-22 7:56 ` Marcel Holtmann 2008-10-22 9:10 ` Tomas Winkler 2008-10-22 10:07 ` Christoph Hellwig 2 siblings, 2 replies; 36+ messages in thread From: Johannes Berg @ 2008-10-22 7:27 UTC (permalink / raw) To: reinette chatre Cc: Marcel Holtmann, Tomas Winkler, John W. Linville, linux-wireless@vger.kernel.org [-- Attachment #1: Type: text/plain, Size: 828 bytes --] On Tue, 2008-10-21 at 15:28 -0700, reinette chatre wrote: > I do not believe our request is unreasonable. If a user runs a new > kernel the log will print a message that the firmware is incorrect ... > all the user needs to do is go to > http://intellinuxwireless.org/?n=Downloads and download the latest > firmware. And that exactly _is_ a problem, the user may be relying on wireless connectivity. And they won't know up-front they need new firmware. Since firmware is loaded from userspace, you're breaking userspace/kernel ABI, it's pretty simple really. I really don't know why we let you get away with this and bitch endlessly when b43 does such a change, to the point where we finally cave in and support both versions. Why should a community-supported driver be held to higher standards? johannes [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-22 7:27 ` Johannes Berg @ 2008-10-22 7:56 ` Marcel Holtmann 2008-10-22 7:57 ` Johannes Berg 2008-10-22 20:30 ` reinette chatre 2008-10-22 9:10 ` Tomas Winkler 1 sibling, 2 replies; 36+ messages in thread From: Marcel Holtmann @ 2008-10-22 7:56 UTC (permalink / raw) To: Johannes Berg Cc: reinette chatre, Tomas Winkler, John W. Linville, linux-wireless@vger.kernel.org Hi Johannes, > > I do not believe our request is unreasonable. If a user runs a new > > kernel the log will print a message that the firmware is incorrect ... > > all the user needs to do is go to > > http://intellinuxwireless.org/?n=Downloads and download the latest > > firmware. > > And that exactly _is_ a problem, the user may be relying on wireless > connectivity. And they won't know up-front they need new firmware. Since > firmware is loaded from userspace, you're breaking userspace/kernel ABI, > it's pretty simple really. I talked to David Woodhouse and we plan to add a big warning to modules_install when MODULE_FIRMWARE is not present on the filesystem. > I really don't know why we let you get away with this and bitch > endlessly when b43 does such a change, to the point where we finally > cave in and support both versions. Why should a community-supported > driver be held to higher standards? If in any way possible, we should support both versions of the firmware. Regards Marcel ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-22 7:56 ` Marcel Holtmann @ 2008-10-22 7:57 ` Johannes Berg 2008-10-22 20:30 ` reinette chatre 1 sibling, 0 replies; 36+ messages in thread From: Johannes Berg @ 2008-10-22 7:57 UTC (permalink / raw) To: Marcel Holtmann Cc: reinette chatre, Tomas Winkler, John W. Linville, linux-wireless@vger.kernel.org [-- Attachment #1: Type: text/plain, Size: 605 bytes --] On Wed, 2008-10-22 at 09:56 +0200, Marcel Holtmann wrote: > > I really don't know why we let you get away with this and bitch > > endlessly when b43 does such a change, to the point where we finally > > cave in and support both versions. Why should a community-supported > > driver be held to higher standards? > > If in any way possible, we should support both versions of the firmware. It doesn't look to me that the wireless folks will succumb to any pressure unless John reverts the patches. But they haven't even managed to identify the patches that caused the breakage... johannes [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-22 7:56 ` Marcel Holtmann 2008-10-22 7:57 ` Johannes Berg @ 2008-10-22 20:30 ` reinette chatre 2008-10-22 22:59 ` Marcel Holtmann 1 sibling, 1 reply; 36+ messages in thread From: reinette chatre @ 2008-10-22 20:30 UTC (permalink / raw) To: Marcel Holtmann Cc: Johannes Berg, Tomas Winkler, John W. Linville, linux-wireless@vger.kernel.org On Wed, 2008-10-22 at 00:56 -0700, Marcel Holtmann wrote: > Hi Johannes, > > > > I do not believe our request is unreasonable. If a user runs a new > > > kernel the log will print a message that the firmware is incorrect ... > > > all the user needs to do is go to > > > http://intellinuxwireless.org/?n=Downloads and download the latest > > > firmware. > > > > And that exactly _is_ a problem, the user may be relying on wireless > > connectivity. And they won't know up-front they need new firmware. Since > > firmware is loaded from userspace, you're breaking userspace/kernel ABI, > > it's pretty simple really. > > I talked to David Woodhouse and we plan to add a big warning to > modules_install when MODULE_FIRMWARE is not present on the filesystem. Thank you very much. This appears to address the problem. That is, a user trying to run a new kernel with old userspace will now get a warning while internet access is still available. Thus enabling them to update firmware. Is this solution acceptable to everybody? > > > I really don't know why we let you get away with this and bitch > > endlessly when b43 does such a change, to the point where we finally > > cave in and support both versions. Why should a community-supported > > driver be held to higher standards? > > If in any way possible, we should support both versions of the firmware. I would like to hear some suggestions on how we can do this as I am not familiar with the other drivers. The driver is closely tied to the firmware ... and I am actually tempted to draw an analogy between the interface between the driver and mac80211 here. From what I understand, for the driver to support many versions of the firmware it dynamically needs to detect which features are supported at runtime and act accordingly. This is a hard problem. What am I missing? Reinette ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-22 20:30 ` reinette chatre @ 2008-10-22 22:59 ` Marcel Holtmann 2008-10-22 23:14 ` reinette chatre 0 siblings, 1 reply; 36+ messages in thread From: Marcel Holtmann @ 2008-10-22 22:59 UTC (permalink / raw) To: reinette chatre Cc: Johannes Berg, Tomas Winkler, John W. Linville, linux-wireless@vger.kernel.org Hi Reinette, > > > I really don't know why we let you get away with this and bitch > > > endlessly when b43 does such a change, to the point where we finally > > > cave in and support both versions. Why should a community-supported > > > driver be held to higher standards? > > > > If in any way possible, we should support both versions of the firmware. > > I would like to hear some suggestions on how we can do this as I am not > familiar with the other drivers. The driver is closely tied to the > firmware ... and I am actually tempted to draw an analogy between the > interface between the driver and mac80211 here. From what I understand, > for the driver to support many versions of the firmware it dynamically > needs to detect which features are supported at runtime and act > accordingly. This is a hard problem. What am I missing? in some cases it might be possible with a set of quirks or special functions that can be switched at runtime. Check the whole bunch of USB drivers that have special handling depending on what hardware it finds. We could do the same. In some cases this effort might be too much, but if possible we should at least try. It all depends on how much the ucode API changes and sometimes we really wanna cleanup the driver and remove the old code, but in that case we have to tell the users via modules_install that this kernel will break or we have to keep the old driver around. Breaking it from one kernel version to the next one without the user noticing only after reboot is just not good enough. Regards Marcel ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-22 22:59 ` Marcel Holtmann @ 2008-10-22 23:14 ` reinette chatre 2008-10-22 23:39 ` John W. Linville ` (2 more replies) 0 siblings, 3 replies; 36+ messages in thread From: reinette chatre @ 2008-10-22 23:14 UTC (permalink / raw) To: Marcel Holtmann Cc: Johannes Berg, Tomas Winkler, John W. Linville, linux-wireless@vger.kernel.org On Wed, 2008-10-22 at 15:59 -0700, Marcel Holtmann wrote: > in some cases it might be possible with a set of quirks or special > functions that can be switched at runtime. Check the whole bunch of USB > drivers that have special handling depending on what hardware it finds. > We could do the same. In some cases this effort might be too much, but > if possible we should at least try. I don't think we can easily apply the hardware quirk solution here. This is because hardware can be identified by id that does not change and the hardware self does not really change (unless it has firmware that changes ...). In this firmware case we do not have "an id" (we have one file that is loaded by firmware loader so we cannot know what we get just by "looking at it" unless we enforce a version number in the filename as we currently do in our driver) and the firmware can change, potentially frequently, with the consequence of many "quirks" that need to be maintained. > It all depends on how much the ucode API changes and sometimes we really > wanna cleanup the driver and remove the old code, but in that case we > have to tell the users via modules_install that this kernel will break > or we have to keep the old driver around. Breaking it from one kernel > version to the next one without the user noticing only after reboot is > just not good enough. I agree with you and Johannes in this regard and look forward to the modules_install solution. I do hope this will be acceptable to everybody. Reinette ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-22 23:14 ` reinette chatre @ 2008-10-22 23:39 ` John W. Linville 2008-10-23 1:12 ` Marcel Holtmann 2008-10-23 7:22 ` Johannes Berg 2 siblings, 0 replies; 36+ messages in thread From: John W. Linville @ 2008-10-22 23:39 UTC (permalink / raw) To: reinette chatre Cc: Marcel Holtmann, Johannes Berg, Tomas Winkler, linux-wireless@vger.kernel.org On Wed, Oct 22, 2008 at 04:14:21PM -0700, reinette chatre wrote: > On Wed, 2008-10-22 at 15:59 -0700, Marcel Holtmann wrote: > > > in some cases it might be possible with a set of quirks or special > > functions that can be switched at runtime. Check the whole bunch of USB > > drivers that have special handling depending on what hardware it finds. > > We could do the same. In some cases this effort might be too much, but > > if possible we should at least try. > > I don't think we can easily apply the hardware quirk solution here. This > is because hardware can be identified by id that does not change and the > hardware self does not really change (unless it has firmware that > changes ...). In this firmware case we do not have "an id" (we have one > file that is loaded by firmware loader so we cannot know what we get > just by "looking at it" unless we enforce a version number in the > filename as we currently do in our driver) and the firmware can change, > potentially frequently, with the consequence of many "quirks" that need > to be maintained. You can try to load the new firmware, and if that fails you can try the older firmware. Whichever one succeeds first can govern the API you use. In fact, I had a patch like this for Fedora back when you first added an API version to your firmware. Of course, at that point there was no need to rememebr what got loaded since there really was only one API... John -- John W. Linville Linux should be at the core linville@tuxdriver.com of your literate lifestyle. ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-22 23:14 ` reinette chatre 2008-10-22 23:39 ` John W. Linville @ 2008-10-23 1:12 ` Marcel Holtmann 2008-10-23 7:22 ` Johannes Berg 2 siblings, 0 replies; 36+ messages in thread From: Marcel Holtmann @ 2008-10-23 1:12 UTC (permalink / raw) To: reinette chatre Cc: Johannes Berg, Tomas Winkler, John W. Linville, linux-wireless@vger.kernel.org Hi Reinette, > > in some cases it might be possible with a set of quirks or special > > functions that can be switched at runtime. Check the whole bunch of USB > > drivers that have special handling depending on what hardware it finds. > > We could do the same. In some cases this effort might be too much, but > > if possible we should at least try. > > I don't think we can easily apply the hardware quirk solution here. This > is because hardware can be identified by id that does not change and the > hardware self does not really change (unless it has firmware that > changes ...). In this firmware case we do not have "an id" (we have one > file that is loaded by firmware loader so we cannot know what we get > just by "looking at it" unless we enforce a version number in the > filename as we currently do in our driver) and the firmware can change, > potentially frequently, with the consequence of many "quirks" that need > to be maintained. we have the API version of the firmware file. If the new one can't be found, then load the old one via request_firmware() and we know that we have to use the old API. We can program our hardware only with one firmware at a time anyway and we know which one we loaded. We already apply the rules that if the firmware changes the API in an incompatible way, we have to change the firmware filename. Regards Marcel ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-22 23:14 ` reinette chatre 2008-10-22 23:39 ` John W. Linville 2008-10-23 1:12 ` Marcel Holtmann @ 2008-10-23 7:22 ` Johannes Berg 2 siblings, 0 replies; 36+ messages in thread From: Johannes Berg @ 2008-10-23 7:22 UTC (permalink / raw) To: reinette chatre Cc: Marcel Holtmann, Tomas Winkler, John W. Linville, linux-wireless@vger.kernel.org [-- Attachment #1: Type: text/plain, Size: 2417 bytes --] On Wed, 2008-10-22 at 16:14 -0700, reinette chatre wrote: > In this firmware case we do not have "an id" (we have one > file that is loaded by firmware loader so we cannot know what we get > just by "looking at it" unless we enforce a version number in the > filename as we currently do in our driver) and the firmware can change, > potentially frequently, with the consequence of many "quirks" that need > to be maintained. But so you do know which firmware it is. Also, the driver looks into the firmware after loading it to see which version it has, no? At least there seemed to be a printout like that. b43 for example has a few dynamic function pointers that are assigned depending on the firmware. It even supports two completely different hardware-transmit-header layouts. > > It all depends on how much the ucode API changes and sometimes we really > > wanna cleanup the driver and remove the old code, but in that case we > > have to tell the users via modules_install that this kernel will break > > or we have to keep the old driver around. Breaking it from one kernel > > version to the next one without the user noticing only after reboot is > > just not good enough. > > I agree with you and Johannes in this regard and look forward to the > modules_install solution. I do hope this will be acceptable to > everybody. I think even in that case there should be one kernel version that warns and accepts both, and then the next one that requires the newer version. b43, for example, will print out a warning every time it loads old microcode and the kernel tells you which URL to go to to download new firmware that will no longer warn. The code has been in there for more than a kernel version because we aren't changing that, but thanks to this we can now rip out the old code should we implement new features that absolutely require the new firmware. The transition should be more gradual. Module install time in particular is quite late, at that point I might already have installed the kernel. And if you're anything like me, you install new kernels while sitting on a train for hours and hours after downloading the git tree at home ;) The patch Tomas identified doesn't look so extensive. Mind you, I don't even see how it causes a microcode error, must be your policy of aborting the microcode when it detects a regulatory violation? johannes [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-22 7:27 ` Johannes Berg 2008-10-22 7:56 ` Marcel Holtmann @ 2008-10-22 9:10 ` Tomas Winkler 2008-10-22 9:14 ` Johannes Berg 1 sibling, 1 reply; 36+ messages in thread From: Tomas Winkler @ 2008-10-22 9:10 UTC (permalink / raw) To: Johannes Berg Cc: reinette chatre, Marcel Holtmann, John W. Linville, linux-wireless@vger.kernel.org On Wed, Oct 22, 2008 at 9:27 AM, Johannes Berg <johannes@sipsolutions.net> wrote: > On Tue, 2008-10-21 at 15:28 -0700, reinette chatre wrote: > >> I do not believe our request is unreasonable. If a user runs a new >> kernel the log will print a message that the firmware is incorrect ... >> all the user needs to do is go to >> http://intellinuxwireless.org/?n=Downloads and download the latest >> firmware. > > And that exactly _is_ a problem, the user may be relying on wireless > connectivity. And they won't know up-front they need new firmware. Since > firmware is loaded from userspace, you're breaking userspace/kernel ABI, > it's pretty simple really. > > I really don't know why we let you get away with this and bitch > endlessly when b43 does such a change, to the point where we finally > cave in and support both versions. Why should a community-supported > driver be held to higher standards? Patches that we'll support both firmwares from the cummutiy will be welcome, as always. Tomas ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-22 9:10 ` Tomas Winkler @ 2008-10-22 9:14 ` Johannes Berg 2008-10-22 9:23 ` Tomas Winkler 0 siblings, 1 reply; 36+ messages in thread From: Johannes Berg @ 2008-10-22 9:14 UTC (permalink / raw) To: Tomas Winkler Cc: reinette chatre, Marcel Holtmann, John W. Linville, linux-wireless@vger.kernel.org [-- Attachment #1: Type: text/plain, Size: 923 bytes --] On Wed, 2008-10-22 at 11:10 +0200, Tomas Winkler wrote: > > I really don't know why we let you get away with this and bitch > > endlessly when b43 does such a change, to the point where we finally > > cave in and support both versions. Why should a community-supported > > driver be held to higher standards? > > Patches that we'll support both firmwares from the cummutiy will be > welcome, as always. So you're saying we should let you get away with it and just fix it ourselves... How about you identify which patch broke it so we stand a chance? But if then we decide the breakage is worse than the new feature, and revert the patch, you'll scream bloody murder anyway so why do I even bother? Clearly, so far there's no attempt to hold you to the same standards we hold community drivers to, and you are in no way motivated to improve our opinion of you by doing something voluntarily. johannes [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-22 9:14 ` Johannes Berg @ 2008-10-22 9:23 ` Tomas Winkler 0 siblings, 0 replies; 36+ messages in thread From: Tomas Winkler @ 2008-10-22 9:23 UTC (permalink / raw) To: Johannes Berg Cc: reinette chatre, Marcel Holtmann, John W. Linville, linux-wireless@vger.kernel.org On Wed, Oct 22, 2008 at 11:14 AM, Johannes Berg <johannes@sipsolutions.net> wrote: > On Wed, 2008-10-22 at 11:10 +0200, Tomas Winkler wrote: > >> > I really don't know why we let you get away with this and bitch >> > endlessly when b43 does such a change, to the point where we finally >> > cave in and support both versions. Why should a community-supported >> > driver be held to higher standards? >> >> Patches that we'll support both firmwares from the cummutiy will be >> welcome, as always. > > So you're saying we should let you get away with it and just fix it > ourselves... How about you identify which patch broke it so we stand a > chance? 01f9a21af3644224ecc899adeea31dc00418ddae f93b673fcfe2670ccb22434d2ec7660b9f1c3fb8 But if then we decide the breakage is worse than the new > feature, and revert the patch, you'll scream bloody murder anyway Revert anything you want. so why > do I even bother? Don't now Clearly, so far there's no attempt to hold you to the > same standards we hold community drivers to, and you are in no way > motivated to improve our opinion of you by doing something voluntarily. Your militant language is under my standards Tomas ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-21 22:28 ` reinette chatre 2008-10-21 23:06 ` Marcel Holtmann 2008-10-22 7:27 ` Johannes Berg @ 2008-10-22 10:07 ` Christoph Hellwig 2008-10-22 12:28 ` Tomas Winkler 2 siblings, 1 reply; 36+ messages in thread From: Christoph Hellwig @ 2008-10-22 10:07 UTC (permalink / raw) To: reinette chatre Cc: Marcel Holtmann, Tomas Winkler, John W. Linville, Johannes Berg, linux-wireless@vger.kernel.org On Tue, Oct 21, 2008 at 03:28:08PM -0700, reinette chatre wrote: > I do not believe our request is unreasonable. If a user runs a new > kernel the log will print a message that the firmware is incorrect ... > all the user needs to do is go to > http://intellinuxwireless.org/?n=Downloads and download the latest > firmware. This does not require any subtle changes that may affect other > aspects of the system ... just the firmware file that is only used by > the driver. with the wireless that doesn't work. Nice. Sorry guys, but requiring a new firmware version for a new driver release is completely unreasonable. You can drop support for older firmware ABIs after a few years, but not immediately. ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-22 10:07 ` Christoph Hellwig @ 2008-10-22 12:28 ` Tomas Winkler 2008-10-22 18:25 ` Marcel Holtmann 2008-10-24 12:45 ` Florian Mickler 0 siblings, 2 replies; 36+ messages in thread From: Tomas Winkler @ 2008-10-22 12:28 UTC (permalink / raw) To: Christoph Hellwig Cc: reinette chatre, Marcel Holtmann, John W. Linville, Johannes Berg, linux-wireless@vger.kernel.org On Wed, Oct 22, 2008 at 12:07 PM, Christoph Hellwig <hch@infradead.org> wrote: > On Tue, Oct 21, 2008 at 03:28:08PM -0700, reinette chatre wrote: >> I do not believe our request is unreasonable. If a user runs a new >> kernel the log will print a message that the firmware is incorrect ... >> all the user needs to do is go to >> http://intellinuxwireless.org/?n=Downloads and download the latest >> firmware. This does not require any subtle changes that may affect other >> aspects of the system ... just the firmware file that is only used by >> the driver. > > with the wireless that doesn't work. Nice. Sorry guys, but requiring > a new firmware version for a new driver release is completely > unreasonable. You can drop support for older firmware ABIs after a few > years,but not immediately. Years.. this HW will be obsolete in year or two, hopefully recycled. I personally don't want people using this buggy firmware for years. This is development branch after all, it's not even scheduled for 2.6.28. Ucode API for 4965 was changed to -2 without much pain, So there is a precedence this work quite well. This time there were some hiccups in handling this since the API version wasn't updated it as should be. really our fault. But I don't think this situation is so dramatic as you describe it. The objective of the objections is not that we want to immensely hurt users but rather the trade off between maintain even uglier code and users running buggy firmware versus logging into older kernel and downloading new firmware in 5 minutes looks to me not proportional. Distro users that pull updates won't even notice. I might be wrong though. Tomas ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-22 12:28 ` Tomas Winkler @ 2008-10-22 18:25 ` Marcel Holtmann 2008-10-24 12:45 ` Florian Mickler 1 sibling, 0 replies; 36+ messages in thread From: Marcel Holtmann @ 2008-10-22 18:25 UTC (permalink / raw) To: Tomas Winkler Cc: Christoph Hellwig, reinette chatre, John W. Linville, Johannes Berg, linux-wireless@vger.kernel.org Hi Tomas, > >> I do not believe our request is unreasonable. If a user runs a new > >> kernel the log will print a message that the firmware is incorrect ... > >> all the user needs to do is go to > >> http://intellinuxwireless.org/?n=Downloads and download the latest > >> firmware. This does not require any subtle changes that may affect other > >> aspects of the system ... just the firmware file that is only used by > >> the driver. > > > > with the wireless that doesn't work. Nice. Sorry guys, but requiring > > a new firmware version for a new driver release is completely > > unreasonable. You can drop support for older firmware ABIs after a few > > years,but not immediately. > > Years.. this HW will be obsolete in year or two, hopefully recycled. > I personally don't want people using this buggy firmware for years. seems I have to put clearly my community hat on now. This is not true at all. I am still using a ipw2100 in one of my machine. So the 3945 and 4965 will be in use for a long time. The community measurement of obsolete and companies measurement are totally different. Also don't forget these countries where laptops and electronics are still expensive. The old Intel wireless cards will still be used for a long time there. > This is development branch after all, it's not even scheduled for 2.6.28. > > Ucode API for 4965 was changed to -2 without much pain, So there is a > precedence this work quite well. This time there were some hiccups in > handling this since the API version wasn't updated it as should be. > really our fault. But I don't think this situation is so dramatic as > you describe it. Actually that is your impression. I was falling over the 4965 ucode API change twice and it took me longer than 5 minutes to even debug and understand what went wrong here. Since there is no real warning anywhere and the wireless device does show up. And I do know how to handle these things. > The objective of the objections is not that we want to immensely hurt > users but rather the trade off between maintain even uglier code and > users running buggy firmware versus logging into older kernel and > downloading new firmware in 5 minutes looks to me not proportional. > Distro users that pull updates won't even notice. I might be wrong > though. There will be cases where it is too much of a burden and too complicated to keep support for both APIs, but in all other cases we should try to have the driver work with it. I am fully behind Johannes and Christoph here since that is what the community expects. So if we ran into a case where we need to abandon the support for the old API, then we first should make sure that the modules_install will warn loudly about the missing firmware. And with MODULE_FIRMWARE and the firmware work from David, we do have everything in place to actually do this. So lets do it. An additional option would be to create drivers/deprecated/ and put a copy of the old driver there and have some Kconfig magic to allow selecting only one of the drivers. Regards Marcel ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-22 12:28 ` Tomas Winkler 2008-10-22 18:25 ` Marcel Holtmann @ 2008-10-24 12:45 ` Florian Mickler 1 sibling, 0 replies; 36+ messages in thread From: Florian Mickler @ 2008-10-24 12:45 UTC (permalink / raw) To: Thomas Winkler; +Cc: linux-wireless [-- Attachment #1: Type: text/plain, Size: 1559 bytes --] Hi! I'm a 3945 user and am quite happy with everything. Thx for your good work! But: On Wed, 22 Oct 2008 14:28:14 +0200 "Tomas Winkler" <tomasw-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > > The objective of the objections is not that we want to immensely hurt > users but rather the trade off between maintain even uglier code and > users running buggy firmware versus logging into older kernel and > downloading new firmware in 5 minutes looks to me not proportional. > Distro users that pull updates won't even notice. I might be wrong > though. more so like 10 minutes, if you are quick to grasp what happened. if 1000 encounter this problem, that's 10000 minutes wasted, thats 7*24 hours. That's some annoying big waste of time! keep in mind that that breakage _will_ waste the time of other people and that those people are your fellow cutting-edge-kernel testers and developers! but then again, if the new firmware is really superior in many cases, that might be worth it? i mean, if people forget that they are annoyed because the device now performs super ueber cool... or smth like that.. it might pay off (from a user perspective)... so my hope: you avoid breakage and keep people happy! That is also good for your karma (whatever that is) Sincerely, Florian p.s.: if i think more about it: all my non-linux colleagues refer to such breakages as "the linux-expirience"... my linux friends would refer to such stuff as "the gentoo-expirience" ... but in my book stuff like this just sucks... [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 197 bytes --] ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: New iwlwifi 3945 uCode available 2008-10-21 21:34 ` Johannes Berg 2008-10-21 21:38 ` John W. Linville @ 2008-10-21 21:59 ` reinette chatre 1 sibling, 0 replies; 36+ messages in thread From: reinette chatre @ 2008-10-21 21:59 UTC (permalink / raw) To: Johannes Berg; +Cc: Tomas Winkler, linux-wireless@vger.kernel.org On Tue, 2008-10-21 at 14:34 -0700, Johannes Berg wrote: > On Tue, 2008-10-21 at 23:33 +0200, Tomas Winkler wrote: > > On Tue, Oct 21, 2008 at 11:25 PM, Johannes Berg > > <johannes@sipsolutions.net> wrote: > > > On Tue, 2008-10-21 at 11:27 -0700, reinette chatre wrote: > > >> Two new versions of 3945 uCode is now available for download from > > >> http://intellinuxwireless.org/?n=Downloads. Two versions are available > > >> as we have updated the API version of the uCode and included pending > > >> fixes in both API versions. > > >> > > >> Version 15.28.1.8 supports API v1 and can be used with most current 3945 > > >> drivers. Version 15.28.2.8 (API v2) is required when you start using the > > >> latest 3945 driver from wireless-testing at the time it includes the > > >> patch "iwl3945 : Fix a-band association for passive channels". > > > > > > Can you make the driver work with the old ucode? We even do that for > > > drivers where we don't control the ucode like b43... > > > > What for? > > Well, so that installing a new kernel doesn't suddenly break your > network connection and ability to download the firmware, for instance. > If you want more arguments you can go read all the "b43 sucks" threads > about it. Using the new driver (with patch http://marc.info/?l=linux-wireless&m=122401294318415&w=2 ) on current (v1 API) uCode will cause a firmware error. The log message should be clear that a newer ucode is required. Reinette ^ permalink raw reply [flat|nested] 36+ messages in thread
* new iwlwifi 3945 uCode available @ 2009-04-28 20:52 reinette chatre 0 siblings, 0 replies; 36+ messages in thread From: reinette chatre @ 2009-04-28 20:52 UTC (permalink / raw) To: linux-wireless, ipw3945-devel Hi, Version 15.32.2.9 of the 3945 uCode is now available for download from http://intellinuxwireless.org/?n=downloads Changes: -- More protection against NMIs Reinette ^ permalink raw reply [flat|nested] 36+ messages in thread
end of thread, other threads:[~2009-04-28 20:46 UTC | newest] Thread overview: 36+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2008-10-21 18:27 New iwlwifi 3945 uCode available reinette chatre 2008-10-21 21:25 ` Johannes Berg 2008-10-21 21:33 ` Tomas Winkler 2008-10-21 21:34 ` Johannes Berg 2008-10-21 21:38 ` John W. Linville 2008-10-21 21:53 ` Tomas Winkler 2008-10-21 22:13 ` Marcel Holtmann 2008-10-21 22:23 ` Tomas Winkler 2008-10-21 23:01 ` Marcel Holtmann 2008-10-21 23:09 ` Luis R. Rodriguez 2008-10-21 23:11 ` Marcel Holtmann 2008-10-21 23:27 ` Luis R. Rodriguez 2008-10-21 23:31 ` Marcel Holtmann 2008-10-21 23:34 ` Luis R. Rodriguez 2008-10-21 22:28 ` reinette chatre 2008-10-21 23:06 ` Marcel Holtmann 2008-10-21 23:34 ` Tomas Winkler 2008-10-22 1:03 ` Marcel Holtmann 2008-10-22 7:27 ` Johannes Berg 2008-10-22 7:56 ` Marcel Holtmann 2008-10-22 7:57 ` Johannes Berg 2008-10-22 20:30 ` reinette chatre 2008-10-22 22:59 ` Marcel Holtmann 2008-10-22 23:14 ` reinette chatre 2008-10-22 23:39 ` John W. Linville 2008-10-23 1:12 ` Marcel Holtmann 2008-10-23 7:22 ` Johannes Berg 2008-10-22 9:10 ` Tomas Winkler 2008-10-22 9:14 ` Johannes Berg 2008-10-22 9:23 ` Tomas Winkler 2008-10-22 10:07 ` Christoph Hellwig 2008-10-22 12:28 ` Tomas Winkler 2008-10-22 18:25 ` Marcel Holtmann 2008-10-24 12:45 ` Florian Mickler 2008-10-21 21:59 ` reinette chatre -- strict thread matches above, loose matches on Subject: below -- 2009-04-28 20:52 new " reinette chatre
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).