From: Bob Copeland <me@bobcopeland.com>
To: lrodriguez@atheros.com, jmalinen@atheros.com
Cc: ath9k-devel@lists.ath9k.org, linux-wireless@vger.kernel.org
Subject: [PATCH] ath9k: remove useless conditional
Date: Sun, 26 Oct 2008 11:24:48 -0400 [thread overview]
Message-ID: <20081026152448.GA15496@hash.localnet> (raw)
Hi,
I saw this while reading through the ath9k code. Not sure if it was
just dead code or if it should be returning false.
From: Bob Copeland <me@bobcopeland.com>
Subject: [PATCH] ath9k: remove useless conditional
ath9k_hw_keyreset returns true in either branch.
Signed-off-by: Bob Copeland <me@bobcopeland.com>
---
drivers/net/wireless/ath9k/hw.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath9k/hw.c b/drivers/net/wireless/ath9k/hw.c
index 98bc25c..c920822 100644
--- a/drivers/net/wireless/ath9k/hw.c
+++ b/drivers/net/wireless/ath9k/hw.c
@@ -7194,9 +7194,6 @@ bool ath9k_hw_keyreset(struct ath_hal *ah, u16 entry)
}
- if (ah->ah_curchan == NULL)
- return true;
-
return true;
}
--
1.5.4.2.182.gb3092
--
Bob Copeland %% www.bobcopeland.com
reply other threads:[~2008-10-26 15:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081026152448.GA15496@hash.localnet \
--to=me@bobcopeland.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=jmalinen@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox