From: "John W. Linville" <linville@tuxdriver.com>
To: Tomas Winkler <tomasw@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless <linux-wireless@vger.kernel.org>,
Chr <chunkeey@web.de>, mcgrof <mcgrof@gmail.com>
Subject: Re: build warnings
Date: Mon, 27 Oct 2008 09:28:59 -0400 [thread overview]
Message-ID: <20081027132858.GA20389@tuxdriver.com> (raw)
In-Reply-To: <1ba2fa240810270341l9332ec3qeee761ba764d5617@mail.gmail.com>
On Mon, Oct 27, 2008 at 12:41:22PM +0200, Tomas Winkler wrote:
> On Mon, Oct 27, 2008 at 12:34 PM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > Tomas Winkler wrote:
> >> On Sat, Oct 25, 2008 at 10:24 AM, Johannes Berg
> >> <johannes@sipsolutions.net> wrote:
> >>> just FYI in case you haven't seen them. the p54 one looks like a genuine
> >>> problem.
> >>>
> >>> drivers/net/wireless/iwlwifi/iwl-scan.c:69: warning: 'scan_tx_ant'
> >>> defined but not used
> >>
> >> Strange. This variable was removed in 'iwlwifi: unify tx antenna toggling'
> >> patch
> >
> > odd. maybe I don't have the right tree here. Just mentioning the warnings
> > because in my experienced different gcc versions differ.
> >
> Really odd, the lines are just not there. Try to diff to
> wireless-testing master branch.
I advise you do the same -- I see the warning too.
The fault would seem to lie somewhere between me and git -- that bit
seems to have been added back with "wireless: consolidate on a single
escape_essid implementation". Presumably this happened when I rebased
those patches, although I don't recall having done any manual fixups
that I could have flubbed.
Anyway, don't worry -- I'll take care of this one.
John
--
John W. Linville Linux should be at the core
linville@tuxdriver.com of your literate lifestyle.
prev parent reply other threads:[~2008-10-27 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-25 8:24 build warnings Johannes Berg
2008-10-25 14:14 ` [PATCH] p54: fix " Christian Lamparter
2008-10-27 10:30 ` Tomas Winkler
2008-10-27 10:34 ` Johannes Berg
2008-10-27 10:41 ` Tomas Winkler
2008-10-27 13:28 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081027132858.GA20389@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=chunkeey@web.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).