build warnings

build warnings

[Johannes Berg]

just FYI in case you haven't seen them. the p54 one looks like a genuin=
e
problem.

drivers/net/wireless/iwlwifi/iwl-scan.c:69: warning: =E2=80=98scan_tx_a=
nt=E2=80=99 defined but not used
drivers/net/wireless/ath9k/hw.c: In function =E2=80=98ath9k_hw_eeprom_s=
et_board_values=E2=80=99:
drivers/net/wireless/ath9k/hw.c:544: warning: =E2=80=98ant_config=E2=80=
=99 may be used uninitialized in this function
drivers/net/wireless/p54/p54common.c: In function =E2=80=98p54_parse_ee=
prom=E2=80=99:
drivers/net/wireless/p54/p54common.c:325: warning: =E2=80=98synth=E2=80=
=99 may be used uninitialized in this function


--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] p54: fix build warnings

[Christian Lamparter]

On Saturday 25 October 2008 10:24:10 Johannes Berg wrote:
> just FYI in case you haven't seen them. the p54 one looks like a genu=
ine
> problem.
>
> drivers/net/wireless/p54/p54common.c: In function =E2=80=98p54_parse_=
eeprom=E2=80=99:
> drivers/net/wireless/p54/p54common.c:325: warning: =E2=80=98synth=E2=80=
=99 may be used uninitialized in this function

There you go. Yes, it is a genuine problem, if the device's eeprom is s=
crewed really up.

Signed-off-by: Christian Lamparter <chunkeey@web.de>
---
diff --git a/drivers/net/wireless/p54/p54common.c b/drivers/net/wireles=
s/p54/p54common.c
index 360f35b..02a306d 100644
--- a/drivers/net/wireless/p54/p54common.c
+++ b/drivers/net/wireless/p54/p54common.c
@@ -322,7 +322,7 @@ static int p54_parse_eeprom(struct ieee80211_hw *de=
v, void *eeprom, int len)
 	void *tmp;
 	int err;
 	u8 *end =3D (u8 *)eeprom + len;
-	u16 synth;
+	u16 synth =3D 0;
 	DECLARE_MAC_BUF(mac);
=20
 	wrap =3D (struct eeprom_pda_wrap *) eeprom;
@@ -425,7 +425,8 @@ static int p54_parse_eeprom(struct ieee80211_hw *de=
v, void *eeprom, int len)
 		entry =3D (void *)entry + (entry_len + 1)*2;
 	}
=20
-	if (!priv->iq_autocal || !priv->output_limit || !priv->curve_data) {
+	if (!synth || !priv->iq_autocal || !priv->output_limit ||
+	    !priv->curve_data) {
 		printk(KERN_ERR "p54: not all required entries found in eeprom!\n");
 		err =3D -EINVAL;
 		goto err;
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: build warnings

[Tomas Winkler]

On Sat, Oct 25, 2008 at 10:24 AM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> just FYI in case you haven't seen them. the p54 one looks like a genuine
> problem.
>
> drivers/net/wireless/iwlwifi/iwl-scan.c:69: warning: 'scan_tx_ant' defined but not used

Strange. This variable was removed in 'iwlwifi: unify tx antenna toggling' patch
Tomas

Re: build warnings

[Johannes Berg]

Tomas Winkler wrote:
> On Sat, Oct 25, 2008 at 10:24 AM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
>> just FYI in case you haven't seen them. the p54 one looks like a genuine
>> problem.
>>
>> drivers/net/wireless/iwlwifi/iwl-scan.c:69: warning: 'scan_tx_ant'
>> defined but not used
>
> Strange. This variable was removed in 'iwlwifi: unify tx antenna toggling'
> patch

odd. maybe I don't have the right tree here. Just mentioning the warnings
because in my experienced different gcc versions differ.

johannes

Re: build warnings

[Tomas Winkler]

On Mon, Oct 27, 2008 at 12:34 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> Tomas Winkler wrote:
>> On Sat, Oct 25, 2008 at 10:24 AM, Johannes Berg
>> <johannes@sipsolutions.net> wrote:
>>> just FYI in case you haven't seen them. the p54 one looks like a genuine
>>> problem.
>>>
>>> drivers/net/wireless/iwlwifi/iwl-scan.c:69: warning: 'scan_tx_ant'
>>> defined but not used
>>
>> Strange. This variable was removed in 'iwlwifi: unify tx antenna toggling'
>> patch
>
> odd. maybe I don't have the right tree here. Just mentioning the warnings
> because in my experienced different gcc versions differ.
>
Really odd, the lines are just not there. Try to diff to
wireless-testing master branch.
Tomas

>

Re: build warnings

[John W. Linville]

On Mon, Oct 27, 2008 at 12:41:22PM +0200, Tomas Winkler wrote:
> On Mon, Oct 27, 2008 at 12:34 PM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > Tomas Winkler wrote:
> >> On Sat, Oct 25, 2008 at 10:24 AM, Johannes Berg
> >> <johannes@sipsolutions.net> wrote:
> >>> just FYI in case you haven't seen them. the p54 one looks like a genuine
> >>> problem.
> >>>
> >>> drivers/net/wireless/iwlwifi/iwl-scan.c:69: warning: 'scan_tx_ant'
> >>> defined but not used
> >>
> >> Strange. This variable was removed in 'iwlwifi: unify tx antenna toggling'
> >> patch
> >
> > odd. maybe I don't have the right tree here. Just mentioning the warnings
> > because in my experienced different gcc versions differ.
> >
> Really odd, the lines are just not there. Try to diff to
> wireless-testing master branch.

I advise you do the same -- I see the warning too.

The fault would seem to lie somewhere between me and git -- that bit
seems to have been added back with "wireless: consolidate on a single
escape_essid implementation".  Presumably this happened when I rebased
those patches, although I don't recall having done any manual fixups
that I could have flubbed.

Anyway, don't worry -- I'll take care of this one.

John
-- 
John W. Linville		Linux should be at the core
linville@tuxdriver.com			of your literate lifestyle.