linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Greg KH <greg@kroah.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH] at76_usb: update drivers/staging/at76_usb w/ mac80211 port
Date: Mon, 27 Oct 2008 17:15:53 -0400	[thread overview]
Message-ID: <20081027211553.GH20389@tuxdriver.com> (raw)
In-Reply-To: <20081027185634.GA21649@kroah.com>

On Mon, Oct 27, 2008 at 11:56:34AM -0700, Greg KH wrote:
> On Fri, Oct 24, 2008 at 03:48:59PM -0400, John W. Linville wrote:
> > This updates drivers/staging/at76_usb to correspond with the latest
> > version previously available in wireless-testing.
> >=20
> > Signed-off-by: John W. Linville <linville@tuxdriver.com>
>=20
> I've applied this, but it does add the following warnings, which I do=
n't
> think you want to have:
> 	drivers/staging/at76_usb/at76_usb.c:885: warning: =E2=80=98at76_set_=
associd=E2=80=99 defined but not used
> 	drivers/staging/at76_usb/at76_usb.c:903: warning: =E2=80=98at76_set_=
listen_interval=E2=80=99 defined but not used
> 	drivers/staging/at76_usb/at76_usb.c:989: warning: =E2=80=98at76_add_=
mac_address=E2=80=99 defined but not used
>=20
>=20
> I'll remove these unused functions now from the in-kernel version.

Those were still there because Kalle had said he intended to use them.
I see no need to carry them since you have them in git anyway.

> Is there any way to do development on this in the staging version now=
,
> instead of the wireless-testing tree?

=46ine with me, although I do have at least one patch for it that
relates to a pending API change -- I just figured I'd wait for the
round-trip of the patch above and then carry just that patch in my
tree along with the mac80211 API changes that prompted it.  Any other
development makes sense to go to your tree.

Alternatively, I could just drop the patch I have completely or send
it to you to keep until 2.6.29...?

John
--=20
John W. Linville		Linux should be at the core
linville@tuxdriver.com			of your literate lifestyle.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2008-10-27 21:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-24 19:48 [PATCH] at76_usb: update drivers/staging/at76_usb w/ mac80211 port John W. Linville
2008-10-27 18:56 ` Greg KH
2008-10-27 21:15   ` John W. Linville [this message]
2008-10-28  0:27     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081027211553.GH20389@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).