From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: David Miller <davem@davemloft.net>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wireless: clean up sysfs code using %pM
Date: Wed, 29 Oct 2008 08:52:51 -0400 [thread overview]
Message-ID: <20081029125251.GC24103@tuxdriver.com> (raw)
In-Reply-To: <1225281291.5439.4.camel@johannes.berg>
On Wed, Oct 29, 2008 at 12:54:51PM +0100, Johannes Berg wrote:
> On Tue, 2008-10-28 at 22:07 -0700, David Miller wrote:
> > From: Johannes Berg <johannes@sipsolutions.net>
> > Date: Tue, 28 Oct 2008 14:00:54 +0100
> >
> > > Remove converting the MAC address to a string by a direct byte
> > > conversion and use %pM instead, since the code is now boilerplate
> > > use a macro to define the show functions, and also use the shorter
> > > __ATTR_RO macro to define the attributes.
> > >
> > > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> > > ---
> > > John, just FYI, it needs to go through net-next-2.6 since it depends on
> > > %pM. Won't cause conflicts either :)
> >
> > I'll let John get this one.
>
> Hmm. That means it won't get into 2.6.29 because John doesn't branch
> from your next tree but rather from Linus's tree, and thus we can't use
> %pM yet. I can resend then, doesn't matter much.
Not quite true -- wireless-testing doesn't branch from net-next-2.6,
but wireless-next-2.6 does. Often that is a benefit for "just
wireless" development, but sometimes not...
I can push this through wireless-next-2.6 only (i.e. not in
wireless-testing), Dave could take it directly, or it could just wait.
Any preferences?
John
--
John W. Linville Linux should be at the core
linville@tuxdriver.com of your literate lifestyle.
next prev parent reply other threads:[~2008-10-29 12:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 13:00 [PATCH] wireless: clean up sysfs code using %pM Johannes Berg
2008-10-29 5:07 ` David Miller
2008-10-29 11:54 ` Johannes Berg
2008-10-29 12:52 ` John W. Linville [this message]
2008-10-29 12:57 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081029125251.GC24103@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox