Re: linux-next: Tree for October 28

Re: linux-next: Tree for October 28

[Andrew Morton]

On Tue, 28 Oct 2008 18:30:55 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> I have created today's linux-next tree at
> git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git
> (patches at
> http://www.kernel.org/pub/linux/kernel/people/sfr/linux-next/).

ia64 allmodconfig:

arch/ia64/kernel/iosapic.c: In function `get_target_cpu':
arch/ia64/kernel/iosapic.c:723: error: `nr_cpus_ids' undeclared (first use in this function)
arch/ia64/kernel/iosapic.c:723: error: (Each undeclared identifier is reported only once
arch/ia64/kernel/iosapic.c:723: error: for each function it appears in.)

Fixed by:

From: Andrew Morton <akpm@linux-foundation.org>

- someone can't type (or test)

- nr_cpu_ids is declared in cpumask.h.  Include it.

--- a/arch/ia64/kernel/iosapic.c~ia64-fix-arch-ia64-kernel-iosapicc-build
+++ a/arch/ia64/kernel/iosapic.c
@@ -85,6 +85,7 @@
 #include <linux/irq.h>
 #include <linux/kernel.h>
 #include <linux/list.h>
+#include <linux/cpumask.h>
 #include <linux/pci.h>
 #include <linux/smp.h>
 #include <linux/string.h>
@@ -720,7 +721,7 @@ get_target_cpu (unsigned int gsi, int ir
 		for (numa_cpu = first_cpu(cpu_mask) ; i < cpu_index ; i++)
 			numa_cpu = next_cpu(numa_cpu, cpu_mask);
 
-		if (numa_cpu < nr_cpus_ids)
+		if (numa_cpu < nr_cpu_ids)
 			return cpu_physical_id(numa_cpu);
 	}
 skip_numa_setup:
_



also rather a lot of these:


In file included from drivers/misc/sgi-gru/gruhandles.h:25,
                 from drivers/misc/sgi-gru/grutables.h:151,
                 from drivers/misc/sgi-gru/grufile.c:41:
drivers/misc/sgi-gru/gru_instructions.h: In function `gru_flush_cache':
drivers/misc/sgi-gru/gru_instructions.h:292: warning: passing arg 1 of pointer to function makes integer from pointer without a cast
In file included from drivers/misc/sgi-gru/gruhandles.h:25,
                 from drivers/misc/sgi-gru/grutables.h:151,
                 from drivers/misc/sgi-gru/grumain.c:22:
drivers/misc/sgi-gru/gru_instructions.h: In function `gru_flush_cache':
drivers/misc/sgi-gru/gru_instructions.h:292: warning: passing arg 1 of pointer to function makes integer from pointer without a cast



and this:


kernel/trace/trace.c: In function `tracing_generic_entry_update':
kernel/trace/trace.c:681: error: implicit declaration of function `irqs_disabled_flags'
kernel/trace/trace.c: In function `kretprobed':
kernel/trace/trace.c:1112: error: `kretprobe_trampoline' undeclared (first use in this function)
kernel/trace/trace.c:1112: error: (Each undeclared identifier is reported only once
kernel/trace/trace.c:1112: error: for each function it appears in.)


and wireless needs some Kconfig help.  Please don't just break other
architecture's build like this.

drivers/staging/wlan-ng/wlan_compat.h:136:3: #error "No CPU identified!"
drivers/staging/wlan-ng/wlan_compat.h:695:6: warning: "WLAN_CPU_FAMILY" is not defined
drivers/staging/wlan-ng/wlan_compat.h:699:6: warning: "WLAN_CPU_FAMILY" is not defined



plus of course enough compile warnings to start a small war.   ocfs2 is prominent.

fs/ocfs2/xattr.c: In function `ocfs2_xattr_index_block_find':
fs/ocfs2/xattr.c:2338: warning: long long unsigned int format, u64 arg (arg 7)
fs/ocfs2/xattr.c:2338: warning: long long unsigned int format, u64 arg (arg 7)
fs/ocfs2/xattr.c:2338: warning: long long unsigned int format, u64 arg (arg 7)
fs/ocfs2/xattr.c: In function `ocfs2_iterate_xattr_buckets':
fs/ocfs2/xattr.c:2362: warning: long long unsigned int format, u64 arg (arg 7)
fs/ocfs2/xattr.c:2362: warning: long long unsigned int format, u64 arg (arg 7)
fs/ocfs2/xattr.c:2362: warning: long long unsigned int format, u64 arg (arg 7)
fs/ocfs2/xattr.c:2381: warning: long long unsigned int format, u64 arg (arg 6)
fs/ocfs2/xattr.c:2381: warning: long long unsigned int format, u64 arg (arg 6)
fs/ocfs2/xattr.c:2381: warning: long long unsigned int format, u64 arg (arg 6)
fs/ocfs2/xattr.c: In function `ocfs2_xattr_create_index_block':
fs/ocfs2/xattr.c:2717: warning: long long unsigned int format, u64 arg (arg 6)
fs/ocfs2/xattr.c:2717: warning: long long unsigned int format, u64 arg (arg 6)

Re: linux-next: Tree for October 28

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

On Tue, 2008-10-28 at 22:07 -0700, Andrew Morton wrote:

> and wireless needs some Kconfig help.  Please don't just break other
> architecture's build like this.
> 
> drivers/staging/wlan-ng/wlan_compat.h:136:3: #error "No CPU identified!"
> drivers/staging/wlan-ng/wlan_compat.h:695:6: warning: "WLAN_CPU_FAMILY" is not defined
> drivers/staging/wlan-ng/wlan_compat.h:699:6: warning: "WLAN_CPU_FAMILY" is not defined

This isn't wireless, it's staging. Talk to Greg, not to linux-wireless.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: Tree for October 28

[John W. Linville]

On Tue, Oct 28, 2008 at 10:07:41PM -0700, Andrew Morton wrote:
> On Tue, 28 Oct 2008 18:30:55 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > I have created today's linux-next tree at
> > git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git
> > (patches at
> > http://www.kernel.org/pub/linux/kernel/people/sfr/linux-next/).

> and wireless needs some Kconfig help.  Please don't just break other
> architecture's build like this.
> 
> drivers/staging/wlan-ng/wlan_compat.h:136:3: #error "No CPU identified!"
> drivers/staging/wlan-ng/wlan_compat.h:695:6: warning: "WLAN_CPU_FAMILY" is not defined
> drivers/staging/wlan-ng/wlan_compat.h:699:6: warning: "WLAN_CPU_FAMILY" is not defined

For the record, I blame Greg K-H for this... :-)

John
-- 
John W. Linville		Linux should be at the core
linville@tuxdriver.com			of your literate lifestyle.

Re: linux-next: Tree for October 28

[Greg KH]

On Wed, Oct 29, 2008 at 08:54:49AM -0400, John W. Linville wrote:
> On Tue, Oct 28, 2008 at 10:07:41PM -0700, Andrew Morton wrote:
> > On Tue, 28 Oct 2008 18:30:55 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > 
> > > I have created today's linux-next tree at
> > > git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git
> > > (patches at
> > > http://www.kernel.org/pub/linux/kernel/people/sfr/linux-next/).
> 
> > and wireless needs some Kconfig help.  Please don't just break other
> > architecture's build like this.
> > 
> > drivers/staging/wlan-ng/wlan_compat.h:136:3: #error "No CPU identified!"
> > drivers/staging/wlan-ng/wlan_compat.h:695:6: warning: "WLAN_CPU_FAMILY" is not defined
> > drivers/staging/wlan-ng/wlan_compat.h:699:6: warning: "WLAN_CPU_FAMILY" is not defined
> 
> For the record, I blame Greg K-H for this... :-)

Ick, yes, _ANYTHING_ in drivers/staging/ is my fault, please let me know
about this.

I'll fix this up, thanks for the report.

greg k-h

Re: linux-next: Tree for October 28

[Mark Fasheh]

On Tue, Oct 28, 2008 at 10:07:41PM -0700, Andrew Morton wrote:
> plus of course enough compile warnings to start a small war.   ocfs2 is
> prominent.
> 
> fs/ocfs2/xattr.c: In function `ocfs2_xattr_index_block_find':
> fs/ocfs2/xattr.c:2338: warning: long long unsigned int format, u64 arg (arg 7)
> fs/ocfs2/xattr.c:2338: warning: long long unsigned int format, u64 arg (arg 7)
> fs/ocfs2/xattr.c:2338: warning: long long unsigned int format, u64 arg (arg 7)

Thanks for pointing these out Andrew. They slipped by me. I'll get them
fixed up before the conflict escalates  ;)
	--Mark

--
Mark Fasheh