From: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: htl10@users.sourceforge.net, Pavel Roskin <proski@gnu.org>,
wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC/RFT] rtl8187: Reduce delays to reduce startup time
Date: Wed, 29 Oct 2008 16:42:16 -0200 [thread overview]
Message-ID: <200810291642.16697.herton@mandriva.com.br> (raw)
In-Reply-To: <49088F7D.8020102@lwfinger.net>
On Wednesday 29 October 2008 14:29:49 Larry Finger wrote:
> The current driver for the RTL8187 and RTL8187B USB devices contain a large
> number of sleep statements, which causes the driver to take a very long time
> to initialize and connect. An audit was undertaken to test which, if any, of
> these delays could be eliminated.
>
> The first thing I noted was that calls to rtl8225_write_ofdm(),
> rtl8225_write_cck(), and rtl8225_write() all go through either
> rtl8225_write_bang() or rtl8225_write_8051() and that both those routines
> finish with an msleep() call; therefore sequences such as
> rtl8225_write(); msleep(1) should not be needed. After removing the msleep()
> calls of this type, the initialization routine was much faster without affecting
> any functionality.
>
> Next, I experimented with removing those calls with sleeps greater than 1
> second - again there was no negative effect.
>
> These changes are most important for the execution of routine
> rtl8225z2_b_rf_init() where the time went from 14.84 sec to 7.90 sec.
>
> Please test these changes to verify that these changes do not affect correct
> operations of other versions of either the RTL8187 or RTL8187B chips.
I tested here with one 8187B and another 8187L and don't found problems. Just
don't know about the 8187L part that you changed, may be the original authors
of 8187L should comment about it. Otherwise you can add:
Tested-by: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
--
[]'s
Herton
next prev parent reply other threads:[~2008-10-29 18:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <838057.50079.qm@web23102.mail.ird.yahoo.com>
2008-10-29 16:29 ` [RFC/RFT] rtl8187: Reduce delays to reduce startup time Larry Finger
2008-10-29 18:42 ` Herton Ronaldo Krzesinski [this message]
2008-10-29 19:38 ` Hin-Tak Leung
2008-10-30 0:48 ` Larry Finger
2008-10-30 0:49 ` [RFC/RFT PATCH 0/6] " Larry Finger
2008-10-30 0:52 ` [RFC/RFT PATCH 2/6] rtl8187: Remove OFDM delays Larry Finger
2008-10-30 0:53 ` [RFC/RFT PATCH 3/6] rtl8187: Remove CCK delays Larry Finger
2008-10-30 0:54 ` [RFC/RFT PATCH 6/6] rtl8187: Reduce channel switch delay Larry Finger
2008-10-30 0:54 ` [RFC/RFT PATCH 1/6] rtl8187: Remove large delays Larry Finger
2008-10-30 0:54 ` [RFC/RFT PATCH 4/6] rtl8187: Remove msleep calls after calls to rtl8225_write Larry Finger
2008-10-30 0:55 ` [RFC/RFT PATCH 5/6] rtl8187: Remove primitive write delays Larry Finger
2008-10-30 16:51 ` [RFC/RFT] rtl8187: Change TX power settings Larry Finger
2008-10-30 18:52 ` Hin-Tak Leung
2008-10-30 23:42 ` Larry Finger
2008-10-31 3:29 ` Piter PUNK
2008-10-31 16:51 ` [PATCH 0/6] rtl8187: Reduce delays to reduce startup time Larry Finger
2008-10-31 18:03 ` Herton Ronaldo Krzesinski
2008-10-31 16:52 ` [PATCH 1/6] rtl8187: Remove large delays Larry Finger
2008-10-31 16:52 ` [PATCH 2/6] rtl8187: Remove OFDM delays Larry Finger
2008-10-31 16:52 ` [PATCH 3/6] rtl8187: Remove CCK delays Larry Finger
2008-10-31 16:54 ` [PATCH 4/6] rtl8187: Remove msleep calls after calls to rtl8225_write Larry Finger
2008-10-31 16:54 ` [PATCH 5/6] rtl8187: Remove primitive write delays Larry Finger
2008-10-31 16:54 ` [PATCH 6/6] rtl8187: Reduce channel switch delay Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810291642.16697.herton@mandriva.com.br \
--to=herton@mandriva.com.br \
--cc=Larry.Finger@lwfinger.net \
--cc=htl10@users.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).