From: Jouni Malinen <j@w1.fi>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: [PATCHv2 5/5] mac80211_hwsim: Make sure beacon_timer gets deleted
Date: Thu, 30 Oct 2008 16:59:25 +0200 [thread overview]
Message-ID: <20081030150254.961883544@localhost> (raw)
In-Reply-To: 20081030145920.233178987@localhost
It was possible to trigger a kernel panic because beacon_timer may not
have been deleted in all cases when the kernel module was removed while
hostapd was still running.
Signed-off-by: Jouni Malinen <jouni.malinen@atheros.com>
Index: wireless-testing/drivers/net/wireless/mac80211_hwsim.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/mac80211_hwsim.c 2008-10-30 16:11:33.000000000 +0200
+++ wireless-testing/drivers/net/wireless/mac80211_hwsim.c 2008-10-30 16:26:49.000000000 +0200
@@ -290,6 +290,7 @@
{
struct mac80211_hwsim_data *data = hw->priv;
data->started = 0;
+ del_timer(&data->beacon_timer);
printk(KERN_DEBUG "%s:%s\n", wiphy_name(hw->wiphy), __func__);
}
--
--
Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2008-10-30 15:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 14:59 [PATCHv2 0/5] mac80211/cfg80211/hwsim: Basic rate and TXQ params Jouni Malinen
2008-10-30 14:59 ` [PATCHv2 1/5] mac80211_hwsim: Debug info for BSS config changes Jouni Malinen
2008-10-30 14:59 ` [PATCHv2 2/5] nl80211: Add basic rate configuration for AP mode Jouni Malinen
2008-10-30 14:59 ` [PATCHv2 3/5] mac80211_hwsim: Debug info for TX queue parameters Jouni Malinen
2008-10-30 14:59 ` [PATCHv2 4/5] nl80211: Add TX queue parameter configuration Jouni Malinen
2008-10-30 14:59 ` Jouni Malinen [this message]
2008-10-30 15:08 ` [PATCHv2 5/5] mac80211_hwsim: Make sure beacon_timer gets deleted Johannes Berg
2008-10-30 15:41 ` Jouni Malinen
2008-10-30 15:09 ` [PATCHv2 0/5] mac80211/cfg80211/hwsim: Basic rate and TXQ params Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081030150254.961883544@localhost \
--to=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).