PROBLEM: Led for wifi blinking all the time

PROBLEM: Led for wifi blinking all the time

[Ondřej Kučera]

Hello,

this is my first kernel bug report ever so I'm not 100% sure about the=20
protocol but I'll try my best...

After upgrading to 2.6.27 the wifi led starts blinking right after=20
connecting to the network and then continues blinking even when there's=
=20
no network traffic at all. This wasn't happening before, the led used t=
o=20
be just "on" when I was connected but not generating any traffic.

Up to kernel 2.6.26.5 (the last 2.6.26.* kernel in my distribution -=20
ArchLinux) the behavior was correct, the problem first occurred with=20
2.6.27 and is present up to 2.6.27.4 (the last of 2.6.27.* I've tried).=
=20
The driver used is iwl3945, the corresponding line from lspci:
03:00.0 Network controller: Intel Corporation PRO/Wireless 3945ABG=20
Network Connection (rev 02)

If any other information is relevant, please tell me and I'll try to=20
provide it, too.

Ond=F8ej


--=20
Cheers,
Ond=F8ej Ku=E8era
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: PROBLEM: Led for wifi blinking all the time

[John W. Linville]

On Fri, Oct 31, 2008 at 02:19:53AM +0100, Ond=C5=99ej Ku=C4=8Dera wrote=
:
> Hello,
>
> this is my first kernel bug report ever so I'm not 100% sure about th=
e =20
> protocol but I'll try my best...
>
> After upgrading to 2.6.27 the wifi led starts blinking right after =20
> connecting to the network and then continues blinking even when there=
's =20
> no network traffic at all. This wasn't happening before, the led used=
 to =20
> be just "on" when I was connected but not generating any traffic.
>
> Up to kernel 2.6.26.5 (the last 2.6.26.* kernel in my distribution - =
=20
> ArchLinux) the behavior was correct, the problem first occurred with =
=20
> 2.6.27 and is present up to 2.6.27.4 (the last of 2.6.27.* I've tried=
). =20
> The driver used is iwl3945, the corresponding line from lspci:
> 03:00.0 Network controller: Intel Corporation PRO/Wireless 3945ABG =20
> Network Connection (rev 02)
>
> If any other information is relevant, please tell me and I'll try to =
=20
> provide it, too.

I'm pretty sure this is how the iwlwifi team wants the LEDs to work...

John
--=20
John W. Linville		Linux should be at the core
linville@tuxdriver.com			of your literate lifestyle.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [ipw3945-devel] PROBLEM: Led for wifi blinking all the time

[Marcos Barbosa]

VHJhZmZpYyBleGlzdHMgYWxsIHRoZSB0aW1lLCBiZWNhdXNlIHRoZSBjb21tYW5kcyB0byBjb250
cm9sCmNvbm5lY3Rpb24uIFRvIGNhbmNlbCBhbGwgdHJhZmZpYywgZG93biB0aGUgd2lyZWxlc3Mg
aW50ZXJmYWNlLgoKMjAwOC8xMC8zMSBKb2huIFcuIExpbnZpbGxlIDxsaW52aWxsZUB0dXhkcml2
ZXIuY29tPjoKPiBPbiBGcmksIE9jdCAzMSwgMjAwOCBhdCAwMjoxOTo1M0FNICswMTAwLCBPbmT4
ZWogS3XoZXJhIHdyb3RlOgo+PiBIZWxsbywKPj4KPj4gdGhpcyBpcyBteSBmaXJzdCBrZXJuZWwg
YnVnIHJlcG9ydCBldmVyIHNvIEknbSBub3QgMTAwJSBzdXJlIGFib3V0IHRoZQo+PiBwcm90b2Nv
bCBidXQgSSdsbCB0cnkgbXkgYmVzdC4uLgo+Pgo+PiBBZnRlciB1cGdyYWRpbmcgdG8gMi42LjI3
IHRoZSB3aWZpIGxlZCBzdGFydHMgYmxpbmtpbmcgcmlnaHQgYWZ0ZXIKPj4gY29ubmVjdGluZyB0
byB0aGUgbmV0d29yayBhbmQgdGhlbiBjb250aW51ZXMgYmxpbmtpbmcgZXZlbiB3aGVuIHRoZXJl
J3MKPj4gbm8gbmV0d29yayB0cmFmZmljIGF0IGFsbC4gVGhpcyB3YXNuJ3QgaGFwcGVuaW5nIGJl
Zm9yZSwgdGhlIGxlZCB1c2VkIHRvCj4+IGJlIGp1c3QgIm9uIiB3aGVuIEkgd2FzIGNvbm5lY3Rl
ZCBidXQgbm90IGdlbmVyYXRpbmcgYW55IHRyYWZmaWMuCj4+Cj4+IFVwIHRvIGtlcm5lbCAyLjYu
MjYuNSAodGhlIGxhc3QgMi42LjI2Lioga2VybmVsIGluIG15IGRpc3RyaWJ1dGlvbiAtCj4+IEFy
Y2hMaW51eCkgdGhlIGJlaGF2aW9yIHdhcyBjb3JyZWN0LCB0aGUgcHJvYmxlbSBmaXJzdCBvY2N1
cnJlZCB3aXRoCj4+IDIuNi4yNyBhbmQgaXMgcHJlc2VudCB1cCB0byAyLjYuMjcuNCAodGhlIGxh
c3Qgb2YgMi42LjI3LiogSSd2ZSB0cmllZCkuCj4+IFRoZSBkcml2ZXIgdXNlZCBpcyBpd2wzOTQ1
LCB0aGUgY29ycmVzcG9uZGluZyBsaW5lIGZyb20gbHNwY2k6Cj4+IDAzOjAwLjAgTmV0d29yayBj
b250cm9sbGVyOiBJbnRlbCBDb3Jwb3JhdGlvbiBQUk8vV2lyZWxlc3MgMzk0NUFCRwo+PiBOZXR3
b3JrIENvbm5lY3Rpb24gKHJldiAwMikKPj4KPj4gSWYgYW55IG90aGVyIGluZm9ybWF0aW9uIGlz
IHJlbGV2YW50LCBwbGVhc2UgdGVsbCBtZSBhbmQgSSdsbCB0cnkgdG8KPj4gcHJvdmlkZSBpdCwg
dG9vLgo+Cj4gSSdtIHByZXR0eSBzdXJlIHRoaXMgaXMgaG93IHRoZSBpd2x3aWZpIHRlYW0gd2Fu
dHMgdGhlIExFRHMgdG8gd29yay4uLgo+Cj4gSm9obgo+IC0tCj4gSm9obiBXLiBMaW52aWxsZSAg
ICAgICAgICAgICAgICBMaW51eCBzaG91bGQgYmUgYXQgdGhlIGNvcmUKPiBsaW52aWxsZUB0dXhk
cml2ZXIuY29tICAgICAgICAgICAgICAgICAgb2YgeW91ciBsaXRlcmF0ZSBsaWZlc3R5bGUuCj4K
PiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tCj4gVGhpcyBTRi5OZXQgZW1haWwgaXMgc3BvbnNvcmVkIGJ5IHRo
ZSBNb2JsaW4gWW91ciBNb3ZlIERldmVsb3BlcidzIGNoYWxsZW5nZQo+IEJ1aWxkIHRoZSBjb29s
ZXN0IExpbnV4IGJhc2VkIGFwcGxpY2F0aW9ucyB3aXRoIE1vYmxpbiBTREsgJiB3aW4gZ3JlYXQg
cHJpemVzCj4gR3JhbmQgcHJpemUgaXMgYSB0cmlwIGZvciB0d28gdG8gYW4gT3BlbiBTb3VyY2Ug
ZXZlbnQgYW55d2hlcmUgaW4gdGhlIHdvcmxkCj4gaHR0cDovL21vYmxpbi1jb250ZXN0Lm9yZy9y
ZWRpcmVjdC5waHA/YmFubmVyX2lkPTEwMCZ1cmw9Lwo+IF9fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fCj4gSXB3Mzk0NS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBJ
cHczOTQ1LWRldmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldAo+IGh0dHBzOi8vbGlzdHMuc291cmNl
Zm9yZ2UubmV0L2xpc3RzL2xpc3RpbmZvL2lwdzM5NDUtZGV2ZWwKPgoKCgotLSAKTWFyY29zIEhl
bnJpcXVlIEVzdGV2ZXMgQmFyYm9zYQptYXJjb3Nlc3RldmVzYmFyYm9zYUBnbWFpbC5jb20K

Re: [ipw3945-devel] PROBLEM: Led for wifi blinking all the time

[Tino Keitel]

[-- Attachment #1: Type: text/plain, Size: 1294 bytes --]

On Fri, Oct 31, 2008 at 10:54:35 -0400, John W. Linville wrote:
> On Fri, Oct 31, 2008 at 02:19:53AM +0100, Ondřej Kučera wrote:
> > Hello,
> >
> > this is my first kernel bug report ever so I'm not 100% sure about the  
> > protocol but I'll try my best...
> >
> > After upgrading to 2.6.27 the wifi led starts blinking right after  
> > connecting to the network and then continues blinking even when there's  
> > no network traffic at all. This wasn't happening before, the led used to  
> > be just "on" when I was connected but not generating any traffic.
> >
> > Up to kernel 2.6.26.5 (the last 2.6.26.* kernel in my distribution -  
> > ArchLinux) the behavior was correct, the problem first occurred with  
> > 2.6.27 and is present up to 2.6.27.4 (the last of 2.6.27.* I've tried).  
> > The driver used is iwl3945, the corresponding line from lspci:
> > 03:00.0 Network controller: Intel Corporation PRO/Wireless 3945ABG  
> > Network Connection (rev 02)
> >
> > If any other information is relevant, please tell me and I'll try to  
> > provide it, too.
> 
> I'm pretty sure this is how the iwlwifi team wants the LEDs to work...

To change from the annoying blinking to some more decent traffic
indicator, I wrote a small patch. I attached the version for 2.6.27.

Regards,
Tino

[-- Attachment #2: iwl-shorter-blink_2.6.27.patch --]
[-- Type: text/x-diff, Size: 952 bytes --]

diff --git a/drivers/net/wireless/iwlwifi/iwl-led.c b/drivers/net/wireless/iwlwifi/iwl-led.c
index 4eee1b1..50eff75 100644
--- a/drivers/net/wireless/iwlwifi/iwl-led.c
+++ b/drivers/net/wireless/iwlwifi/iwl-led.c
@@ -69,7 +69,7 @@ static const struct {
 	{15, 95, 95 },
 	{10, 110, 110},
 	{5, 130, 130},
-	{0, 167, 167},
+	{0, 25, 25},
 /* SOLID_ON */
 	{-1, IWL_LED_SOLID, 0}
 };
@@ -289,7 +289,7 @@ static int iwl_get_blink_rate(struct iwl_priv *priv)
 	if (!priv->allow_blinking)
 		i = IWL_MAX_BLINK_TBL;
 	else
-		for (i = 0; i < IWL_MAX_BLINK_TBL; i++)
+		for (i = IWL_MAX_BLINK_TBL - 1 ; i < IWL_MAX_BLINK_TBL; i++)
 			if (tpt  > (blink_tbl[i].tpt * IWL_1MB_RATE))
 				break;
 
@@ -326,7 +326,7 @@ void iwl_leds_background(struct iwl_priv *priv)
 	}
 	if (!priv->last_blink_time ||
 	    !time_after(jiffies, priv->last_blink_time +
-			msecs_to_jiffies(1000)))
+			msecs_to_jiffies(40)))
 		return;
 
 	blink_idx = iwl_get_blink_rate(priv);

Re: [ipw3945-devel] PROBLEM: Led for wifi blinking all the time

[Ondřej Kučera]

Hi,

Marcos Barbosa wrote:
> Traffic exists all the time, because the commands to control
> connection. To cancel all traffic, down the wireless interface.

OK, let me rephrase. It may by true that from a low-level point of view=
=20
there exists some traffic all the time. But let's see it from user's=20
point of view. With 2.6.26 I connected to network during which the led=20
was blinking. After the connection was established, it stopped blinking=
=20
and was just on. Then when I started downloading something (wget=20
http://server.com/foo.bar), it started blinking and shortly after the=20
download was completed, it stopped to be just "on" again. I consider=20
this a very reasonable behavior. With 2.6.27 it is blinking really all=20
the time, whether the user is consciously downloading/uploading some=20
data or not. The main problem is that such periodic non-stop blinking i=
s=20
very eye catching and it draws your attention away from the things you=20
are actually doing. So I really believe this is a regression. One more=20
reason, even though I'm not sure if I should even bring it up - on MS=20
Windows it behaves more or less in a similar manner as with 2.6.26=20
kernel. Now I'm far from saying that things should work the way they=20
work on Windows but in this case I think they actually have it right.

Ond=F8ej


--=20
Cheers,
Ond=F8ej Ku=E8era
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [ipw3945-devel] PROBLEM: Led for wifi blinking all the time

[reinette chatre]

On Mon, 2008-11-03 at 17:58 -0800, Ond=C5=99ej Ku=C4=8Dera wrote:
> Hi,
>=20
> Marcos Barbosa wrote:
> > Traffic exists all the time, because the commands to control
> > connection. To cancel all traffic, down the wireless interface.
>=20
> OK, let me rephrase. It may by true that from a low-level point of vi=
ew=20
> there exists some traffic all the time. But let's see it from user's=20
> point of view. With 2.6.26 I connected to network during which the le=
d=20
> was blinking. After the connection was established, it stopped blinki=
ng=20
> and was just on. Then when I started downloading something (wget=20
> http://server.com/foo.bar), it started blinking and shortly after the=
=20
> download was completed, it stopped to be just "on" again. I consider=20
> this a very reasonable behavior. With 2.6.27 it is blinking really al=
l=20
> the time, whether the user is consciously downloading/uploading some=20
> data or not. The main problem is that such periodic non-stop blinking=
 is=20
> very eye catching and it draws your attention away from the things yo=
u=20
> are actually doing. So I really believe this is a regression. One mor=
e=20
> reason, even though I'm not sure if I should even bring it up - on MS=
=20
> Windows it behaves more or less in a similar manner as with 2.6.26=20
> kernel. Now I'm far from saying that things should work the way they=20
> work on Windows but in this case I think they actually have it right.

Could you please add your feedback to
http://www.intellinuxwireless.org/bugzilla/show_bug.cgi?id=3D1771 ?

Thanks

Reinette

--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [ipw3945-devel] PROBLEM: Led for wifi blinking all the time

[Tino Keitel]

On Mon, Nov 03, 2008 at 21:14:12 +0100, Tino Keitel wrote:
> On Fri, Oct 31, 2008 at 10:54:35 -0400, John W. Linville wrote:
> > On Fri, Oct 31, 2008 at 02:19:53AM +0100, Ond=C5=99ej Ku=C4=8Dera w=
rote:

[...]

> > > 03:00.0 Network controller: Intel Corporation PRO/Wireless 3945AB=
G =20
> > > Network Connection (rev 02)
> > >
> > > If any other information is relevant, please tell me and I'll try=
 to =20
> > > provide it, too.
> >=20
> > I'm pretty sure this is how the iwlwifi team wants the LEDs to work=
=2E..
>=20
> To change from the annoying blinking to some more decent traffic
> indicator, I wrote a small patch. I attached the version for 2.6.27.

Hi,

sorry, the patch is for 4965. But maybe you can port it to the 3945
driver.

Regards,
Tino
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [ipw3945-devel] PROBLEM: Led for wifi blinking all the time

[Tomas Winkler]

T24gVHVlLCBOb3YgNCwgMjAwOCBhdCA5OjAzIFBNLCBUaW5vIEtlaXRlbCA8dGluby5rZWl0ZWwr
aXdsQHRpa2VpLmRlPiB3cm90ZToKPiBPbiBNb24sIE5vdiAwMywgMjAwOCBhdCAyMToxNDoxMiAr
MDEwMCwgVGlubyBLZWl0ZWwgd3JvdGU6Cj4+IE9uIEZyaSwgT2N0IDMxLCAyMDA4IGF0IDEwOjU0
OjM1IC0wNDAwLCBKb2huIFcuIExpbnZpbGxlIHdyb3RlOgo+PiA+IE9uIEZyaSwgT2N0IDMxLCAy
MDA4IGF0IDAyOjE5OjUzQU0gKzAxMDAsIE9uZMWZZWogS3XEjWVyYSB3cm90ZToKPgo+IFsuLi5d
Cj4KPj4gPiA+IDAzOjAwLjAgTmV0d29yayBjb250cm9sbGVyOiBJbnRlbCBDb3Jwb3JhdGlvbiBQ
Uk8vV2lyZWxlc3MgMzk0NUFCRwo+PiA+ID4gTmV0d29yayBDb25uZWN0aW9uIChyZXYgMDIpCj4+
ID4gPgo+PiA+ID4gSWYgYW55IG90aGVyIGluZm9ybWF0aW9uIGlzIHJlbGV2YW50LCBwbGVhc2Ug
dGVsbCBtZSBhbmQgSSdsbCB0cnkgdG8KPj4gPiA+IHByb3ZpZGUgaXQsIHRvby4KPj4gPgo+PiA+
IEknbSBwcmV0dHkgc3VyZSB0aGlzIGlzIGhvdyB0aGUgaXdsd2lmaSB0ZWFtIHdhbnRzIHRoZSBM
RURzIHRvIHdvcmsuLi4KPj4KPj4gVG8gY2hhbmdlIGZyb20gdGhlIGFubm95aW5nIGJsaW5raW5n
IHRvIHNvbWUgbW9yZSBkZWNlbnQgdHJhZmZpYwo+PiBpbmRpY2F0b3IsIEkgd3JvdGUgYSBzbWFs
bCBwYXRjaC4gSSBhdHRhY2hlZCB0aGUgdmVyc2lvbiBmb3IgMi42LjI3Lgo+Cj4gSGksCj4KPiBz
b3JyeSwgdGhlIHBhdGNoIGlzIGZvciA0OTY1LiBCdXQgbWF5YmUgeW91IGNhbiBwb3J0IGl0IHRv
IHRoZSAzOTQ1Cj4gZHJpdmVyLgoKVGhpcyBwYXRjaCBpcyBub3QgZ29vZC4gSW4gYWduIHRoZSBM
RURzIGJlaGF2ZXMgY29ycmVjdGx5LiBJdCdzIGp1c3QKbmVlZCB0byBiZSBwb3J0ZWQgdG8gMzk0
NSBhcyB3ZWxsClRvbWFzCg==

Re: [ipw3945-devel] PROBLEM: Led for wifi blinking all the time

[Tomas Winkler]

T24gVHVlLCBOb3YgNCwgMjAwOCBhdCA5OjAzIFBNLCBUaW5vIEtlaXRlbCA8dGluby5rZWl0ZWwr
aXdsQHRpa2VpLmRlPiB3cm90ZToKPiBPbiBNb24sIE5vdiAwMywgMjAwOCBhdCAyMToxNDoxMiAr
MDEwMCwgVGlubyBLZWl0ZWwgd3JvdGU6Cj4+IE9uIEZyaSwgT2N0IDMxLCAyMDA4IGF0IDEwOjU0
OjM1IC0wNDAwLCBKb2huIFcuIExpbnZpbGxlIHdyb3RlOgo+PiA+IE9uIEZyaSwgT2N0IDMxLCAy
MDA4IGF0IDAyOjE5OjUzQU0gKzAxMDAsIE9uZMWZZWogS3XEjWVyYSB3cm90ZToKPgo+IFsuLi5d
Cj4KPj4gPiA+IDAzOjAwLjAgTmV0d29yayBjb250cm9sbGVyOiBJbnRlbCBDb3Jwb3JhdGlvbiBQ
Uk8vV2lyZWxlc3MgMzk0NUFCRwo+PiA+ID4gTmV0d29yayBDb25uZWN0aW9uIChyZXYgMDIpCj4+
ID4gPgo+PiA+ID4gSWYgYW55IG90aGVyIGluZm9ybWF0aW9uIGlzIHJlbGV2YW50LCBwbGVhc2Ug
dGVsbCBtZSBhbmQgSSdsbCB0cnkgdG8KPj4gPiA+IHByb3ZpZGUgaXQsIHRvby4KPj4gPgo+PiA+
IEknbSBwcmV0dHkgc3VyZSB0aGlzIGlzIGhvdyB0aGUgaXdsd2lmaSB0ZWFtIHdhbnRzIHRoZSBM
RURzIHRvIHdvcmsuLi4KPj4KPj4gVG8gY2hhbmdlIGZyb20gdGhlIGFubm95aW5nIGJsaW5raW5n
IHRvIHNvbWUgbW9yZSBkZWNlbnQgdHJhZmZpYwo+PiBpbmRpY2F0b3IsIEkgd3JvdGUgYSBzbWFs
bCBwYXRjaC4gSSBhdHRhY2hlZCB0aGUgdmVyc2lvbiBmb3IgMi42LjI3Lgo+Cj4gSGksCj4KPiBz
b3JyeSwgdGhlIHBhdGNoIGlzIGZvciA0OTY1LiBCdXQgbWF5YmUgeW91IGNhbiBwb3J0IGl0IHRv
IHRoZSAzOTQ1Cj4gZHJpdmVyLgoKVGhpcyBwYXRjaCBpcyBub3QgZ29vZC4gSW4gYWduIHRoZSBM
RURzIGJlaGF2ZXMgY29ycmVjdGx5LiBJdCdzIGp1c3QKbmVlZCB0byBiZSBwb3J0ZWQgdG8gMzk0
NSBhcyB3ZWxsClRvbWFzCg==