linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: crash with rt61pci when resuming with card ejected
Date: Fri, 31 Oct 2008 23:01:39 +0100	[thread overview]
Message-ID: <200810312301.39373.IvDoorn@gmail.com> (raw)
In-Reply-To: <1225489644.3550.0.camel@johannes.berg>

On Friday 31 October 2008, Johannes Berg wrote:
> On Fri, 2008-10-31 at 20:31 +0100, Ivo van Doorn wrote:
> 
> > Hmm, it looks like CSR base is NULL, after which the H2M_MAILBOX_CSR
> > offset is added to it (0x2100)
> > 
> > The strange part is thet CSR is freed and set to NULL _after_ the
> > rt2x00lib_remove_dev() call...
> > Oh wait never mind, I get the picture, I missed the "ejected _while_ suspended"
> > part. I think what is happening is that first the suspend handler is called,
> > and during resume not the resume handler but the remove handler is running,
> > and rt2x00 doesn't protect against that.
> > 
> > Could you check if below patch does the trick? If I am not mistaken only the
> > LED handler actually accesses the hardware to make sure they are off.
> 
> Now it crashes in config_pairwise_key or something like that, I can send
> you the image if you want.

No need. :)
I assume mac80211 calls set_key() to disable all hardware keys when
ieee80211_unregister_hw() is being called. I'll cook up a patch to catch
that as well.

Ivo


  reply	other threads:[~2008-10-31 22:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30 10:12 crash with rt61pci when resuming with card ejected Johannes Berg
2008-10-30 21:47 ` Ivo van Doorn
2008-10-30 22:07   ` Johannes Berg
2008-10-30 23:07   ` Johannes Berg
2008-10-31 19:31     ` Ivo van Doorn
2008-10-31 21:47       ` Johannes Berg
2008-10-31 22:01         ` Ivo van Doorn [this message]
2008-10-31 22:11           ` Johannes Berg
2008-11-01  8:58             ` Ivo van Doorn
2008-11-01  9:15               ` Johannes Berg
2008-11-01 10:29                 ` Ivo van Doorn
2008-11-01 12:05                   ` Johannes Berg
2008-11-01 15:25                     ` Ivo van Doorn
2008-11-01 15:34                       ` Johannes Berg
2008-11-01 23:10                         ` Ivo van Doorn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810312301.39373.IvDoorn@gmail.com \
    --to=ivdoorn@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).