* [PATCH 1/2] rt2x00: Cleanup indirect register access
@ 2008-11-10 18:41 Ivo van Doorn
2008-11-10 18:42 ` [PATCH 2/2] rt2x00: Move rt73usb register access wrappers into rt2x00usb Ivo van Doorn
0 siblings, 1 reply; 2+ messages in thread
From: Ivo van Doorn @ 2008-11-10 18:41 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless, rt2400-devel
All code which accessed indirect registers was similar
in respect to the for-loop, the given timeout, etc.
Move it into a seperate function, which for PCI drivers
can be moved into rt2x00pci.
This allows us to cleanup the cleanup the code further
by removing the goto statementsand making the codepath
look a bit nicer.
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
---
http://kernel.org/pub/linux/kernel/people/ivd/patches/0001-rt2x00-Cleanup-indirect-register-access.patch
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 2/2] rt2x00: Move rt73usb register access wrappers into rt2x00usb
2008-11-10 18:41 [PATCH 1/2] rt2x00: Cleanup indirect register access Ivo van Doorn
@ 2008-11-10 18:42 ` Ivo van Doorn
0 siblings, 0 replies; 2+ messages in thread
From: Ivo van Doorn @ 2008-11-10 18:42 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless, rt2400-devel
rt2500usb and rt73usb have different register word sizes,
for that reason the register access wrappers were never
moved into rt2x00usb.
With rt2800usb on its way, we should favor the 32bit
register access and move those wrappers into rt2x00usb.
That saves duplicate code, since only rt2500usb will
need the special 16bit wrappers.
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
---
http://kernel.org/pub/linux/kernel/people/ivd/patches/0002-rt2x00-Move-rt73usb-register-access-wrappers-into-r.patch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-10 18:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-10 18:41 [PATCH 1/2] rt2x00: Cleanup indirect register access Ivo van Doorn
2008-11-10 18:42 ` [PATCH 2/2] rt2x00: Move rt73usb register access wrappers into rt2x00usb Ivo van Doorn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).