Re: libertas_tf should replace libertas_usb on compat-wireless?

["Luis R. Rodriguez" <lrodriguez@atheros.com>]

On Wed, Nov 12, 2008 at 03:23:05PM -0800, Stefanik G=E1bor wrote:
> On Wed, Nov 12, 2008 at 11:32 PM, Luis R. Rodriguez
> <lrodriguez@atheros.com> wrote:
> > On Wed, Nov 12, 2008 at 2:29 PM, Stefanik G=E1bor <netrolller.3d@gm=
ail.com> wrote:
> >> On Wed, Nov 12, 2008 at 11:27 PM, Luis R. Rodriguez
> >> <lrodriguez@atheros.com> wrote:
> >>> On Wed, Nov 12, 2008 at 01:16:36PM -0800, Stefanik G=E1bor wrote:
> >>>> On Wed, Nov 12, 2008 at 10:07 PM, Andrey Yurovsky <andrey@cozybi=
t.com> wrote:
> >>>> > libertas_tf is a softmac driver developed mainly so that XO's =
can run
> >>>> > hostapd and the like.  libertas is the general (fullmac) drive=
r and,
> >>>> > in my opinion, should be the one users get unless they specifi=
cally
> >>>> > wanted libertas_tf because they're experimenting with AP mode =
or other
> >>>> > mac80211 features.  So I guess I'd vote for libertas over libe=
rtas_tf
> >>>> > at this time, for what it's worth.
> >>>> >
> >>>> >  -Andrey
> >>>>
> >>>> I think libertas_usb should be a default (as it's HW accelerated=
), but
> >>>> libertas_tf should be included as an option (disabled by default=
 in
> >>>> config.mk, or auto-added to /etc/modprobe.d/blacklist upon make
> >>>> install).
> >>>
> >>> OK so I've done this on config.mk:
> >>>
> >>> ifneq ($(CONFIG_USB),)
> >>> ifneq ($(CONFIG_LIBERTAS_THINFIRM_USB),m)
> >>> CONFIG_LIBERTAS_USB=3Dm
> >>> NEED_LIBERTAS=3Dy
> >>> endif
> >>> endif
> >>>
> >>> This means you'll get CONFIG_LIBERTAS_USB unless your kernel
> >>> already was built with CONFIG_LIBERTAS_THINFIRM_USB for all those
> >>> building with it. If your kernel was built with both then its you=
r
> >>> problem.
> >>>
> >>>  Luis
> >>>
> >>
> >> If the kernel has both, compat-wireless should also build both.
> >
> > The kernel has both, compat-wireless has both but we respect your
> > kernel .config unless we know better (we picked b43 over bcm43xx
> > before). In this case we don't want to prefer one over the other so=
 we
> > simply stick to the decision of whoever built your kernel.
> >
> >  Luis
> >
>=20
> I mean if both are enabled, and both were built.

OK yeah agreed, but if the user has nothing then we should pick one
for them too, in this case it'll be LIBERTAS_USB.

 Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html