Re: Problem with Kernel Oops in ipw2200

["John W. Linville" <linville@tuxdriver.com>]

On Thu, Nov 13, 2008 at 10:16:18AM +0100, Frank Seidel wrote:
> Hi,
> 
> John W. Linville schrieb:
> > On Thu, Nov 06, 2008 at 04:46:59PM +0100, Frank Seidel wrote:
> >> Frank Seidel schrieb:
> >>> Ever suggestion is very appreciated.
> >> My first search through the ipw2200 logs pointed
> >> me to Davids last commit (521c4d96e0840ecce25b956e00f416ed499ef2ba)
> >> and really after reverting it the problem disappeared here.
> >> The patch from my last post was the smallest subset of
> >> the revertion that still works for me here.
> >> Any comments?
> > 
> > I think it would be better to make sure that ipw2200 (and/or
> > ieee80211) is properly using netif_carrier_{on,off}() instead?
> 
> Thanks for your answer. But i am not sure i understand you correctly.
> Do you propose to let the patch in place like it is?
> The problem is that before this patch ipw2200 didn't have that problem
> and now with it is constantly on various machines is running in
> a kernel oops at ipw_tx_skb called by ipw_net_hard_start_xmit.
> So imho that patch introduced the bug somehow and even partly reverting
> it fixes the problem here on my testmachine.

Well, what I am suggesting is that it would be better to fix the
intended purpose of the original patch rather than to partially
revert it, thereby partially reintroducing the problem it was trying
to fix. :-)

John
-- 
John W. Linville		Linux should be at the core
linville@tuxdriver.com			of your literate lifestyle.