From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bu3sch.de ([62.75.166.246]:57102 "EHLO vs166246.vserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751476AbYKOXZ4 (ORCPT ); Sat, 15 Nov 2008 18:25:56 -0500 From: Michael Buesch To: Ivo van Doorn Subject: Re: [PATCH] rt2x00: Don't switch off LED on initialization Date: Sun, 16 Nov 2008 00:25:25 +0100 Cc: John Linville , linux-wireless@vger.kernel.org, rt2400-devel@lists.sourceforge.net References: <200811160008.51235.IvDoorn@gmail.com> In-Reply-To: <200811160008.51235.IvDoorn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Message-Id: <200811160025.25678.mb@bu3sch.de> (sfid-20081116_002600_435022_C4867AF7) Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sunday 16 November 2008 00:08:50 Ivo van Doorn wrote: > When we switch off the LEDS during initialization > we kill rt73usb from proper functioning. The immediate > result after the first LED command are MCU failures > and a complete breakdown of TX/RX. > > Signed-off-by: Ivo van Doorn > --- > drivers/net/wireless/rt2x00/rt2x00leds.c | 6 ------ > 1 files changed, 0 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/wireless/rt2x00/rt2x00leds.c b/drivers/net/wireless/rt2x00/rt2x00leds.c > index 66c61b1..68f4e0f 100644 > --- a/drivers/net/wireless/rt2x00/rt2x00leds.c > +++ b/drivers/net/wireless/rt2x00/rt2x00leds.c > @@ -111,12 +111,6 @@ static int rt2x00leds_register_led(struct rt2x00_dev *rt2x00dev, > led->led_dev.name = name; > led->led_dev.brightness = LED_OFF; > > - /* > - * Ensure the LED is off, it might have been enabled > - * by the hardware when the device was powered on. > - */ > - led->led_dev.brightness_set(&led->led_dev, LED_OFF); > - > retval = led_classdev_register(device, &led->led_dev); > if (retval) { > ERROR(rt2x00dev, "Failed to register led handler.\n"); But you know that a brightness_set event can trigger right after the dev was registered? So a random LED event at the right time can kill the rt device? -- Greetings Michael.