Re: iwlagn driver segfault in 2.6.28-rc3

["Carlos R. Mafra" <crmafra2@gmail.com>]

On Mon 17.Nov'08 at  1:54:16 +0200, Tomas Winkler wrote:
[...]
> Can you please try this one (might be white space broken, just pasted in)

Sure, I've already applied it by hand and will start testing it right away.

But it will take many days until I can report back about it, because
this oops happened only two times in one month or so.

Thanks for taking a look at it, the last time you did my regression
got fixed :-)

> diff --git a/drivers/net/wireless/iwlwifi/iwl-sta.c
> b/drivers/net/wireless/iwlwifi/iwl-sta.c
> index 61797f3..d848c63 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-sta.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-sta.c
> @@ -734,6 +734,12 @@ int iwl_remove_dynamic_key(struct iwl_priv *priv,
>                 return 0;
>         }
> 
> +       if (WARN(priv->stations[sta_id].sta.key.key_offset ==
> WEP_INVALID_OFFSET,
> +               "Removing wrong key %d 0x%x\n", keyconf->keyidx, key_flags)) {
> +               spin_unlock_irqrestore(&priv->sta_lock, flags);
> +               return 0;
> +       }
> +
>         if (!test_and_clear_bit(priv->stations[sta_id].sta.key.key_offset,
>                 &priv->ucode_key_table))
>                 IWL_ERROR("index %d not used in uCode key table.\n",
> 
> Thanks
> Tomas
>