linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Frank Seidel <fseidel@suse.de>
Cc: Zhu Yi <yi.zhu@intel.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Chatre, Reinette" <reinette.chatre@intel.com>,
	"ipw2100-devel@lists.sourceforge.net"
	<ipw2100-devel@lists.sourceforge.net>,
	"hschaa@suse.de" <hschaa@suse.de>
Subject: Re: [PATCH] Re: Problem with Kernel Oops in ipw2200
Date: Tue, 18 Nov 2008 14:23:21 -0500	[thread overview]
Message-ID: <20081118192321.GC21772@tuxdriver.com> (raw)
In-Reply-To: <49214BF3.8050306@suse.de>

On Mon, Nov 17, 2008 at 11:48:19AM +0100, Frank Seidel wrote:
> From: Zhu Yi <yi.zhu@intel.com>
> 
> Fixes Oops in ipw2200:ipw_tx_skb when pinging through
> a WPA enterprise connection.
> 
> Signed-off-by: Zhu Yi <yi.zhu@intel.com>
> Tested-by: Frank Seidel <fseidel@suse.de>
> Signed-off-by: Ffrank Seidel <fseidel@suse.de>
> 
> ---
>  drivers/net/wireless/ipw2200.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> --- a/drivers/net/wireless/ipw2200.c
> +++ b/drivers/net/wireless/ipw2200.c
> @@ -10190,6 +10190,11 @@ static int ipw_tx_skb(struct ipw_priv *p
>  	u16 remaining_bytes;
>  	int fc;
>  
> +	if (!(priv->status & STATUS_ASSOCIATED)) {
> +		IPW_DEBUG_TX("Tx attempt while not associated.\n");
> +		goto drop;
> +	}
> +
>  	hdr_len = ieee80211_get_hdrlen(le16_to_cpu(hdr->frame_ctl));
>  	switch (priv->ieee->iw_mode) {
>  	case IW_MODE_ADHOC:
> 

Well, I'm sorry to be a PITA...but the changelog doesn't really
explain how the patch works or what it is doing.  Also, this still
seems to me more like a band-aid than a real fix...?

John
-- 
John W. Linville		Linux should be at the core
linville@tuxdriver.com			of your literate lifestyle.

  reply	other threads:[~2008-11-18 19:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-06 15:34 Problem with Kernel Oops in ipw2200 Frank Seidel
2008-11-06 15:46 ` Frank Seidel
2008-11-12 21:33   ` John W. Linville
2008-11-13  9:16     ` Frank Seidel
2008-11-13 16:03       ` John W. Linville
2008-11-14  2:58       ` Zhu Yi
2008-11-14 10:07         ` Frank Seidel
2008-11-14 14:45         ` Frank Seidel
2008-11-17 10:48         ` [PATCH] " Frank Seidel
2008-11-18 19:23           ` John W. Linville [this message]
2008-11-18 19:34             ` reinette chatre
2008-11-21 19:39           ` reinette chatre
2008-11-24 12:44             ` Frank Seidel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081118192321.GC21772@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=davem@davemloft.net \
    --cc=fseidel@suse.de \
    --cc=hschaa@suse.de \
    --cc=ipw2100-devel@lists.sourceforge.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=reinette.chatre@intel.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).