linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Tomas Winkler <tomasw@gmail.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] mac80211: remove ieee80211_notify_mac
Date: Tue, 18 Nov 2008 14:46:52 -0500	[thread overview]
Message-ID: <20081118194652.GD21772@tuxdriver.com> (raw)
In-Reply-To: <1226944799.3902.52.camel@johannes.berg>

On Mon, Nov 17, 2008 at 06:59:59PM +0100, Johannes Berg wrote:
> On Mon, 2008-11-17 at 19:34 +0200, Tomas Winkler wrote:
> 
> > There actually complains about slow reconnection, 
> 
> Ok I guess then I haven't seen them for some reason.
> 
> Either way, here's a quick summary:
>  * locking issues with the callback are fixed by removing it
>  * callback is incorrect when you're only suspended for a very short
>    time
>  * callback is incorrect when you're in non-STA modes
>  * suspend/resume cannot be implemented well through this callback, at
>    least not the way it is written now and needs to do a whole lot more
>  * there's no "slow" issue when you actually resume in a different
>    location where the AP is not around any more
>  * there should be no "slow" issue when the AP properly deauthenticates
>    when receiving data frames
> 
> This was an RFC. I'm convinced it should go in, but I don't make those
> decisions anyway. I've outlined my reasons for it.

I agree that it seems to solve problems, and there is little benefit
tokeeping the callback in question.  I'm going to send this upstream.

John
-- 
John W. Linville		Linux should be at the core
linville@tuxdriver.com			of your literate lifestyle.

  parent reply	other threads:[~2008-11-18 20:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-17  9:59 [RFC] mac80211: remove ieee80211_notify_mac Johannes Berg
2008-11-17 14:32 ` Tomas Winkler
2008-11-17 14:45   ` Johannes Berg
2008-11-17 15:14     ` Tomas Winkler
2008-11-17 17:28       ` Johannes Berg
     [not found]         ` <1ba2fa240811170934u34fa6e28m1411715690fd24b9@mail.gmail.com>
2008-11-17 17:59           ` Johannes Berg
2008-11-17 18:12             ` Tomas Winkler
2008-11-17 19:46               ` Johannes Berg
2008-11-18 14:20                 ` Tomas Winkler
2008-11-18 19:46             ` John W. Linville [this message]
2008-11-18 23:08               ` Tomas Winkler
2008-12-05 23:53                 ` mohamed salim abbas
2008-12-06  3:27                   ` John W. Linville
2008-12-06  9:05                   ` Johannes Berg
2008-12-07  5:16                     ` mohamed salim abbas
2008-12-07 14:19                       ` Bob Copeland
2008-12-08  5:55                         ` mohamed salim abbas
2008-12-11 23:00                           ` mohamed salim abbas
2008-12-12 17:37                             ` Bob Copeland
2008-12-13  0:28                               ` mohamed salim abbas
2008-11-18  8:40         ` Marcel Holtmann
2008-11-17 17:08 ` Bob Copeland
2008-11-17 17:26   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081118194652.GD21772@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tomasw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).