From: Matthew Garrett <mjg59@srcf.ucam.org>
To: drago01 <drago01@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Ivo van Doorn <ivdoorn@gmail.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
linux-wireless@vger.kernel.org,
Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Subject: Re: [GIT PATCH] rfkill fixes for 2.6.28-rc3
Date: Thu, 20 Nov 2008 16:31:24 +0000 [thread overview]
Message-ID: <20081120163124.GA10899@srcf.ucam.org> (raw)
In-Reply-To: <f6ca9fed0811200827y3e07bb6ag8c46e61c44fbc610@mail.gmail.com>
On Thu, Nov 20, 2008 at 05:27:38PM +0100, drago01 wrote:
> On Wed, Nov 12, 2008 at 10:15 PM, John W. Linville
> <linville@tuxdriver.com> wrote:
> > So I keep looking at these patches, and I'm not sure about them.
> > It seems that they restore the rfkill state after resume to what it
> > was before the suspend.
>
> Wouldn't this break hw kill switches?
> If I move the switch while the system is suspended it will ignore this
> event but the hw will still not work.
Whichever driver is responsible for listening to the hardware events
should handle that in its own resume method. The rfkill state
restoration code will only be relevant for restoring state set by
sofware.
> Well the above scenario would be just broken.
> Unless the driver rereads the real hw state and updates the rfkill
> state on resume.
Quite. How else are you going to know if a switch has moved in the
intervening time?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2008-11-20 16:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-03 16:42 [GIT PATCH] rfkill fixes for 2.6.28-rc3 Henrique de Moraes Holschuh
2008-11-03 16:42 ` [PATCH 1/2] rfkill: preserve state across suspend Henrique de Moraes Holschuh
2008-11-03 17:20 ` Ivo van Doorn
2008-11-03 16:42 ` [PATCH 2/2] rfkill: always call get_state() hook on resume Henrique de Moraes Holschuh
2008-11-03 17:20 ` Ivo van Doorn
2008-11-03 16:47 ` [GIT PATCH] rfkill fixes for 2.6.28-rc3 Ivo van Doorn
2008-11-03 17:02 ` Henrique de Moraes Holschuh
2008-11-03 17:20 ` Ivo van Doorn
2008-11-12 21:15 ` John W. Linville
2008-11-14 0:16 ` Henrique de Moraes Holschuh
2008-11-20 2:00 ` John W. Linville
2008-11-20 10:51 ` Henrique de Moraes Holschuh
2008-11-20 15:03 ` John W. Linville
2008-11-21 22:40 ` [PATCH 1/2] rfkill: preserve state across suspend Henrique de Moraes Holschuh
2008-11-21 22:40 ` [PATCH 2/2] rfkill: always call get_state() hook on resume Henrique de Moraes Holschuh
2008-11-20 16:27 ` [GIT PATCH] rfkill fixes for 2.6.28-rc3 drago01
2008-11-20 16:31 ` Matthew Garrett [this message]
2008-11-20 16:54 ` drago01
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081120163124.GA10899@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=drago01@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).