Re: [ath5k-devel] [Bug 11749] Ath5k driver has too many interrupts per second at idle

["John W. Linville" <linville@tuxdriver.com>]

On Thu, Nov 20, 2008 at 11:13:18AM +0800, Xu, Martin wrote:
> Hi Bob:
> Please review below patch thanks.
> 
> From: Martin Xu <martin.xu@intel.com>
> Subject: disable beacon filter when station is not associated with any AP.
> 
> Ath5k driver has too many interrupts per second at idle
> http://bugzilla.kernel.org/show_bug.cgi?id=11749
> 
> Signed-off-by: Martin Xu <martin.xu@intel.com>
> 
> diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
> index 34cd1a4..37da7cc 100644
> --- a/drivers/net/wireless/ath5k/base.c
> +++ b/drivers/net/wireless/ath5k/base.c
> @@ -241,6 +241,10 @@ static int ath5k_get_tx_stats(struct ieee80211_hw *hw,
>  static u64 ath5k_get_tsf(struct ieee80211_hw *hw);
>  static void ath5k_reset_tsf(struct ieee80211_hw *hw);
>  static int ath5k_beacon_update(struct ath5k_softc *sc, struct sk_buff *skb);
> +static void ath5k_bss_info_changed(struct ieee80211_hw *hw,
> +				struct ieee80211_vif *vif,
> +				struct ieee80211_bss_conf *bss_conf,
> +				u32 changes);
>  
>  static struct ieee80211_ops ath5k_hw_ops = {
>  	.tx 		= ath5k_tx,

This patch defines ath5k_bss_info_changed, but doesn't use it.
Is that really what you meant to do?

John
-- 
John W. Linville		Linux should be at the core
linville@tuxdriver.com			of your literate lifestyle.