linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Fix warning in info.c with gcc 4.3 (Ubuntu 8.10)
@ 2008-11-23 18:09 Alejandro Riveira Fernández
  2008-11-23 19:58 ` Johannes Berg
  0 siblings, 1 reply; 2+ messages in thread
From: Alejandro Riveira Fernández @ 2008-11-23 18:09 UTC (permalink / raw)
  To: johannes; +Cc: linux-wireless


 fix this warning i got with last pull

info.c: In function 'print_flag':
info.c:19: warning: format not a string literal and no format arguments
---
 info.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/info.c b/info.c
index 9b04719..a9c23a4 100644
--- a/info.c
+++ b/info.c
@@ -16,7 +16,7 @@ static void print_flag(const char *name, int *open)
                printf(" (");
        else
                printf(", ");
-       printf(name);
+       printf("%s\n",name);
        *open = 1;
 }
 
-- 
1.6.0.4.766.g6fc4a

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix warning in info.c with gcc 4.3 (Ubuntu 8.10)
  2008-11-23 18:09 [PATCH] Fix warning in info.c with gcc 4.3 (Ubuntu 8.10) Alejandro Riveira Fernández
@ 2008-11-23 19:58 ` Johannes Berg
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2008-11-23 19:58 UTC (permalink / raw)
  To: Alejandro Riveira Fernández; +Cc: linux-wireless

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

On Sun, 2008-11-23 at 19:09 +0100, Alejandro Riveira Fernández wrote:
> fix this warning i got with last pull
> 
> info.c: In function 'print_flag':
> info.c:19: warning: format not a string literal and no format arguments

The \n you added shouldn't be there, I've committed an equivalent fix.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-11-23 19:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-23 18:09 [PATCH] Fix warning in info.c with gcc 4.3 (Ubuntu 8.10) Alejandro Riveira Fernández
2008-11-23 19:58 ` Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).