From: Pavel Machek <pavel@suse.cz>
To: Ian Schram <ischram@telenet.be>
Cc: gregkh@suse.de, greg@kroah.com, linux-wireless@vger.kernel.org
Subject: Re: patch staging-add-w35und-wifi-driver.patch added to gregkh-2.6 tree
Date: Mon, 24 Nov 2008 09:49:15 +0100 [thread overview]
Message-ID: <20081124084915.GA30173@elf.ucw.cz> (raw)
In-Reply-To: <48E40225.60204@telenet.be>
On Thu 2008-10-02 01:05:09, Ian Schram wrote:
> > +
> > +static int wbsoft_tx(struct ieee80211_hw *dev, struct sk_buff *skb,
> > + struct ieee80211_tx_control *control)
> > +{
> > + char *buffer = kmalloc(skb->len, GFP_ATOMIC);
> > + printk("Sending frame %d bytes\n", skb->len);
> > + memcpy(buffer, skb->data, skb->len);
> > + if (1 == MLMESendFrame(my_adapter, buffer, skb->len, FRAME_TYPE_802_11_MANAGEMENT))
> > + printk("frame sent ok (%d bytes)?\n", skb->len);
> > + return NETDEV_TX_OK;
> > +}
> > +
>
> Looks to me, that this is an Oops waiting to happen, might be cautious to check
> if kmalloc succeeded, before copying to the address.
This was fixed -- not by me :-).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-11-24 8:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 12:36 w35und wifi driver for linux-staging Pavel Machek
2008-10-01 11:34 ` Luis R. Rodriguez
2008-10-01 18:53 ` Greg KH
2008-10-01 12:52 ` Christoph Hellwig
2008-10-02 19:12 ` Dan Williams
2008-11-19 11:28 ` Pavel Machek
2008-10-01 19:39 ` patch staging-add-w35und-wifi-driver.patch added to gregkh-2.6 tree gregkh
2008-10-01 23:05 ` Ian Schram
2008-10-01 23:10 ` Greg KH
2008-11-24 8:49 ` Pavel Machek [this message]
2008-10-02 9:57 ` Pavel Machek
2008-10-18 21:19 ` w35und wifi driver for linux-staging Arjan van de Ven
2008-10-20 16:57 ` Dan Williams
2008-10-20 17:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081124084915.GA30173@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=ischram@telenet.be \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).